Mace polar#687
Conversation
|
https://github.com/ACEsuit/mace/releases/tag/v0.3.16 should makes things a little easier and resolve the thread above |
|
I had a quick go building this branch, bumping the requirement to
With these addressed it looks like it is working (although I don't have anything to test against) |
|
The
|
ElliottKasoar
left a comment
There was a problem hiding this comment.
Other than maybe being consistent with the Colab install commands, this looks great
ElliottKasoar
left a comment
There was a problem hiding this comment.
Couple of small fixes actually.
The return from our SinglePoint.run is a custom dictionary of results corresponding to what the user asked for (e.g. energy, forces, stresses, hessian), not a copy of the calc.results dict, so we need to access this to get the dipole etc.
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
one note here i think we shall copy all the calc.results info onto the atoms.info and similar in new ase4 this will have to be done explicity anyhow |
ElliottKasoar
left a comment
There was a problem hiding this comment.
Looks good, and the tutorials run locally for me, so hopefully a release should work
No description provided.