Skip to content

Mace polar#687

Merged
ElliottKasoar merged 28 commits into
stfc:mainfrom
alinelena:mace_polar
Jul 18, 2026
Merged

Mace polar#687
ElliottKasoar merged 28 commits into
stfc:mainfrom
alinelena:mace_polar

Conversation

@alinelena

Copy link
Copy Markdown
Member

No description provided.

Comment thread janus_core/helpers/mlip_calculators.py Outdated
Comment thread pyproject.toml Outdated
@alinelena
alinelena marked this pull request as draft March 20, 2026 15:26
@ElliottKasoar ElliottKasoar added the dependencies Upgrades or fixes to dependencies label Apr 10, 2026
@ElliottKasoar

Copy link
Copy Markdown
Member

https://github.com/ACEsuit/mace/releases/tag/v0.3.16 should makes things a little easier and resolve the thread above

@trdurrant

trdurrant commented Jun 22, 2026

Copy link
Copy Markdown
Member

I had a quick go building this branch, bumping the requirement to mace-torch==0.3.16 and hit two issues (which you most likely already know about):

  • The graph_longrange dependency is needed
  • The default model polar-1-s isn't included in mace v0.3.16 release (which has polar-1-m and polar-1-l) My mistake, it looks like this is included in the repo, but not part of the paper or documentation Model details for MACE-POLAR-1-S ACEsuit/mace-foundations#65

With these addressed it looks like it is working (although I don't have anything to test against)

@trdurrant

Copy link
Copy Markdown
Member

The mace_polar charges do not seem to be directly available in the results, but I didn't have any problem fishing them out of the atoms object as given in the example here #673:

charges = atoms.calc.results['charges']

@alinelena alinelena self-assigned this Jul 17, 2026
@alinelena
alinelena marked this pull request as ready for review July 17, 2026 21:29
Comment thread docs/source/tutorials/python/single_point.ipynb

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than maybe being consistent with the Colab install commands, this looks great

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small fixes actually.

The return from our SinglePoint.run is a custom dictionary of results corresponding to what the user asked for (e.g. energy, forces, stresses, hessian), not a copy of the calc.results dict, so we need to access this to get the dipole etc.

Comment thread docs/source/tutorials/python/single_point.ipynb Outdated
Comment thread docs/source/tutorials/python/single_point.ipynb Outdated
@alinelena

Copy link
Copy Markdown
Member Author

Couple of small fixes actually.

The return from our SinglePoint.run is a custom dictionary of results corresponding to what the user asked for (e.g. energy, forces, stresses, hessian), not a copy of the calc.results dict, so we need to access this to get the dipole etc.

one note here i think we shall copy all the calc.results info onto the atoms.info and similar in new ase4 this will have to be done explicity anyhow

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the tutorials run locally for me, so hopefully a release should work

@ElliottKasoar
ElliottKasoar merged commit 3b9c114 into stfc:main Jul 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Upgrades or fixes to dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants