test: remove bootstrap test that hangs locally

[stickerdaniel]

Summary

• Remove test_cancelled_setup_task_retries_cleanly which calls ensure_tool_ready_or_raise without mocking _run_browser_setup, spawning a real patchright install chromium subprocess as a side effect
• This causes the test suite to hang indefinitely when run without -n auto (xdist), as the leaked background task blocks the event loop
• The scenario it covers (retry after cancelled setup task) is marginal and partially covered by test_setup_in_progress_raises and test_reset_bootstrap_cancels_running_tasks

Test plan

• uv run pytest tests/ -n auto -q — 370 passed in 3.6s, no hang
• uv run pytest tests/test_bootstrap.py -v — completes without hanging
• uv run ruff check . — passes
  Prompt: check issue #304 → investigated hanging tests → removed broken test

[Copilot]

Pull request overview

Removes a locally hanging bootstrap test that could spawn a real browser-install subprocess and leak a background task, blocking the event loop in non-xdist runs.

Changes:

• Removed test_cancelled_setup_task_retries_cleanly, which could trigger real _run_browser_setup side effects.
• Removed the now-unused asyncio import from tests/test_bootstrap.py.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greptile-apps]

Greptile Summary

Removes test_cancelled_setup_task_retries_cleanly, a test that called ensure_tool_ready_or_raise without mocking _run_browser_setup, causing it to spawn a real patchright install chromium subprocess and hang the event loop indefinitely outside of xdist. The unused import asyncio is correctly cleaned up alongside the removal.

Confidence Score: 5/5

Safe to merge — removes a single broken test with no production-code changes.

The change is purely a test deletion plus a now-unused import removal. No logic changes, no new risks, and the removed test was actively causing suite hangs. The marginal scenario it covered (retry after cancelled setup task) remains partially addressed by existing tests.

No files require special attention.

Important Files Changed

Filename	Overview
tests/test_bootstrap.py	Removed the hanging test_cancelled_setup_task_retries_cleanly test and the now-unused import asyncio; all remaining tests are well-isolated with mocks or MagicMock stubs.

Sequence Diagram

sequenceDiagram
    participant T as Test
    participant E as ensure_tool_ready_or_raise
    participant B as _run_browser_setup
    participant P as patchright subprocess

    Note over T,P: Removed test — problematic flow
    T->>T: create_task(sleep(10)) → cancel → await CancelledError
    T->>T: state.setup_task = cancelled_task
    T->>E: ensure_tool_ready_or_raise("search_jobs")
    E->>B: cancelled task detected → restart setup
    B->>P: spawn "patchright install chromium"
    P-->>B: (never returns — hangs event loop)

    Note over T,P: Remaining tests — properly mocked
    T->>T: state.setup_state = RUNNING, setup_task = MagicMock(done=False)
    T->>E: ensure_tool_ready_or_raise("search_jobs")
    E-->>T: raises BrowserSetupInProgressError ✓

Loading

_{Reviews (4): Last reviewed commit: "test: remove bootstrap test that hangs l..." | Re-trigger Greptile}

[stickerdaniel]

Merge activity

• Apr 4, 11:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 4, 11:27 PM UTC: @stickerdaniel merged this pull request with Graphite.