Skip to content

fix(bootstrap): stream patchright install output in real-time#565

Open
ibtisam-12 wants to merge 2 commits into
stickerdaniel:mainfrom
ibtisam-12:feature/533-browser-install-progress
Open

fix(bootstrap): stream patchright install output in real-time#565
ibtisam-12 wants to merge 2 commits into
stickerdaniel:mainfrom
ibtisam-12:feature/533-browser-install-progress

Conversation

@ibtisam-12

Copy link
Copy Markdown

Instead of silently capturing subprocess output and discarding it, patchright install progress is now streamed line-by-line to logger.debug. This lets users see download progress (MB downloaded, percentage) when running with --log-level DEBUG.

CLI modes (--login, --status, --import-from-browser) additionally get live output via print() so the user is never left staring at a blank line.

The background task completion handler (_refresh_background_task_state) now logs the elapsed time, giving operators a clear signal that setup finished.

Fixes #533

Instead of silently capturing subprocess output and discarding it, patchright
install progress is now streamed line-by-line to logger.debug. This lets users
see download progress (MB downloaded, percentage) when running with
--log-level DEBUG.

CLI modes (--login, --status, --import-from-browser) additionally get live
output via print() so the user is never left staring at a blank line.

The background task completion handler (_refresh_background_task_state) now
logs the elapsed time, giving operators a clear signal that setup finished.

Fixes stickerdaniel#533
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes Patchright browser setup output visible while installs are running. The main changes are:

  • Streams Patchright subprocess output to debug logs.
  • Prints install output in CLI setup modes.
  • Logs elapsed time when background browser setup completes.
  • Updates install helper tests for the new callback argument.
  • Adds an optional VS Code task for launching opencode.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
linkedin_mcp_server/bootstrap.py Streams Patchright install output, forwards CLI callbacks, and normalizes setup timestamps before elapsed-time logging.
tests/test_bootstrap.py Updates install stubs to accept the new keyword callback argument.
.vscode/tasks.json Adds an optional editor task for launching opencode.

Reviews (2): Last reviewed commit: "fix(bootstrap): use +00:00 instead of st..." | Re-trigger Greptile

Comment thread linkedin_mcp_server/bootstrap.py
…parsing

utcnow_iso() returns a Z-suffixed timestamp. Stripping Z makes fromisooutput() return a naive datetime, which raises TypeError when subtracted from datetime.now(timezone.utc). Replacing Z with +00:00 preserves timezone awareness so elapsed time is computed correctly.

Fixes Greptile review finding on PR stickerdaniel#565.
alexeynesteruk pushed a commit to alexeynesteruk/linkedin-mcp-server that referenced this pull request Jul 13, 2026
- Expand collapsed job descriptions via main "See more" (stickerdaniel#559; EN locale)
- search_people: geo_urn facet, string list coercion, max_pages (stickerdaniel#568/stickerdaniel#517/stickerdaniel#527)
- Stream patchright install output and log setup elapsed time (stickerdaniel#565)
alexeynesteruk pushed a commit to alexeynesteruk/linkedin-mcp-server that referenced this pull request Jul 13, 2026
- Expand collapsed job descriptions via main "See more" (stickerdaniel#559; EN locale)
- search_people: geo_urn facet, string list coercion, max_pages (stickerdaniel#568/stickerdaniel#517/stickerdaniel#527)
- Stream patchright install output and log setup elapsed time (stickerdaniel#565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Installation Patchright browser download in background tool Error not showing progress

1 participant