Remove Interrupted(StoredId) method from IFunctionStore

Replace test usages with GetInterruptedFunctions() and GetFunction().
The method was only used in tests and is now redundant.

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/StoreTests.cs

@@ -689,14 +689,14 @@ public async Task RestartingFunctionShouldSetInterruptedToFalse(Task<IFunctionSt
         session.ShouldBeNull();
 
         await store.Interrupt(functionId).ShouldBeTrueAsync();
-        await store.Interrupted(functionId).ShouldBeAsync(true);
+        (await store.GetInterruptedFunctions()).Any(id => id == functionId).ShouldBeTrue();
 
         await store.RestartExecution(
-            functionId, 
+            functionId,
             owner: ReplicaId.NewId()
         ).ShouldNotBeNullAsync();
-       
-        await store.Interrupted(functionId).ShouldBeAsync(false);
+
+        (await store.GetInterruptedFunctions()).Any(id => id == functionId).ShouldBeFalse();
     }
 
     public abstract Task MessagesCanBeFetchedAfterFunctionWithInitialMessagesHasBeenCreated();
@@ -1039,7 +1039,7 @@ protected async Task InterruptCountForNonExistingFunctionIsNull(Task<IFunctionSt
     {
         var functionId = TestStoredId.Create();
         var store = await storeTask;
-        (await store.Interrupted(functionId)).ShouldBeNull();
+        (await store.GetFunction(functionId)).ShouldBeNull();
     }
 
     public abstract Task DefaultStateCanSetAndFetchedAfterwards();

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/WatchDogsTests/CrashableFunctionStore.cs

@@ -189,11 +189,6 @@ public Task<bool> Interrupt(StoredId storedId)
 
     public Task ResetInterrupted(IReadOnlyList<StoredId> storedIds) => _inner.ResetInterrupted(storedIds);
 
-    public Task<bool?> Interrupted(StoredId storedId) 
-        => _crashed
-            ? Task.FromException<bool?>(new TimeoutException())
-            : _inner.Interrupted(storedId);
-    
     public Task<bool> SetParameters(StoredId storedId, byte[]? storedParameter, byte[]? storedResult, ReplicaId? expectedReplica)
         => _crashed
             ? Task.FromException<bool>(new TimeoutException())

Core/Cleipnir.ResilientFunctions/Storage/IFunctionStore.cs

@@ -105,7 +105,6 @@ Task<bool> SuspendFunction(
     Task<bool> Interrupt(StoredId storedId);
     Task Interrupt(IReadOnlyList<StoredId> storedIds);
     Task ResetInterrupted(IReadOnlyList<StoredId> storedIds);
-    Task<bool?> Interrupted(StoredId storedId);
 
     Task<Status?> GetFunctionStatus(StoredId storedId);
     Task<IReadOnlyList<StatusAndId>> GetFunctionsStatus(IEnumerable<StoredId> storedIds);

Core/Cleipnir.ResilientFunctions/Storage/InMemoryFunctionStore.cs

@@ -462,17 +462,6 @@ public Task ResetInterrupted(IReadOnlyList<StoredId> storedIds)
         return Task.CompletedTask;
     }
 
-    public Task<bool?> Interrupted(StoredId storedId)
-    {
-        lock (_sync)
-        {
-            if (!_states.ContainsKey(storedId))
-                return Task.FromResult(default(bool?));
-
-            return ((bool?) _states[storedId].Interrupted).ToTask();
-        }
-    }
-
     public Task<Status?> GetFunctionStatus(StoredId storedId)
     {
         lock (_sync)

Samples/Sample.ConsoleApp/Utils/CrashableFunctionStore.cs

@@ -175,11 +175,6 @@ public Task ResetInterrupted(IReadOnlyList<StoredId> storedIds)
             ? Task.FromException(new TimeoutException())
             : _inner.ResetInterrupted(storedIds);
 
-    public Task<bool?> Interrupted(StoredId storedId)
-        => _crashed
-            ? Task.FromException<bool?>(new TimeoutException())
-            : _inner.Interrupted(storedId);
-    
     public Task<Status?> GetFunctionStatus(StoredId storedId)
         => _crashed
             ? Task.FromException<Status?>(new TimeoutException())

Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB/MariaDbFunctionStore.cs

@@ -719,26 +719,6 @@ public async Task<bool> SetParameters(
         return affectedRows == 1;
     }
 
-    private string? _getInterruptCountSql;
-    public async Task<bool?> Interrupted(StoredId storedId)
-    {
-        await using var conn = await CreateOpenConnection(_connectionString);
-        
-        _getInterruptCountSql ??= $@"
-            SELECT interrupted 
-            FROM {_tablePrefix}
-            WHERE id = ?;";
-
-        await using var command = new MySqlCommand(_getInterruptCountSql, conn)
-        {
-            Parameters =
-            {
-                new() { Value = storedId.AsGuid.ToString("N") },
-            }
-        };
-        
-        return (bool?) await command.ExecuteScalarAsync();
-    }
 
     private string? _getFunctionStatusSql;
     public async Task<Status?> GetFunctionStatus(StoredId storedId)

Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlFunctionStore.cs

@@ -684,24 +684,6 @@ public async Task ResetInterrupted(IReadOnlyList<StoredId> storedIds)
         await command.ExecuteNonQueryAsync();
     }
 
-    private string? _interruptedSql;
-    public async Task<bool?> Interrupted(StoredId storedId)
-    {
-        await using var conn = await CreateConnection();
-
-        _interruptedSql ??= $@"
-                SELECT interrupted 
-                FROM {_tableName}
-                WHERE id = $1";
-        await using var command = new NpgsqlCommand(_interruptedSql, conn)
-        {
-            Parameters =
-            {
-                new() { Value = storedId.AsGuid },
-            }
-        };
-        return (bool?) await command.ExecuteScalarAsync();
-    }
 
     private string? _getFunctionStatusSql;
     public async Task<Status?> GetFunctionStatus(StoredId storedId)

Stores/SqlServer/Cleipnir.ResilientFunctions.SqlServer/SqlServerFunctionStore.cs

@@ -772,22 +772,7 @@ public async Task<bool> SetParameters(
         var affectedRows = await command.ExecuteNonQueryAsync();
         return affectedRows > 0;
     }
-    
-    private string? _interruptedSql;
-    public async Task<bool?> Interrupted(StoredId storedId)
-    {
-        await using var conn = await _connFunc();
-        _interruptedSql ??= @$"
-                SELECT Interrupted 
-                FROM {_tableName}            
-                WHERE Id = @Id;";
 
-        await using var command = new SqlCommand(_interruptedSql, conn);
-        command.Parameters.AddWithValue("@Id", storedId.AsGuid);
-
-        var interrupted = await command.ExecuteScalarAsync();
-        return (bool?) interrupted;
-    }
 
     private string? _getFunctionStatusSql;
     public async Task<Status?> GetFunctionStatus(StoredId storedId)