Rename RestartExecution/s to ClaimFunction/s and add owner-guarded SetFunction

The store's RestartExecution/RestartExecutions really take over ownership of a flow and hand back its current state, so rename them to ClaimFunction/ClaimFunctions across the IFunctionStore interface, all four stores and their SqlGenerators, the test doubles and the store test templates. The higher-level FlowsManager.RestartExecutions(messages) orchestration, InvocationHelper.RestartFunction and the RestartedFunction record keep their names; only their store calls are repointed.

Add IFunctionStore.SetFunction: an owner-guarded general state-setter that writes status, owner (null releases) and, when provided, the effects snapshot in a single UPDATE guarded by owner = expectedReplica. expectedReplica is non-nullable - the caller must already own the flow - matching the terminal writers. Its final IStorageSession? parameter is the store's forward-carried per-flow context (typically handed back by ClaimFunction); when supplied it is kept coherent with the persisted effect snapshot, mirroring each store's EffectsStore.SetEffectResults bookkeeping. Together with ClaimFunction this gives a claim-commit-release primitive without bespoke SQL.

Surface the flow's current result bytes on the claim result by adding Result to StoredFlowWithEffects (StorageSession kept last), populated from result_json (SQL stores) and the in-memory state, so a caller can pass it straight into SetFunction without nulling the result.

Build clean; InMemory 521 passed; ClaimFunction/SetFunction green on Postgres/SqlServer/MariaDB; full PostgreSQL suite 373 passed.

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/StoreCrudTests.cs

@@ -58,25 +58,45 @@ public override Task ParameterAndStateAreNotUpdatedWhenEpochDoesNotMatch()
 
 
     [TestMethod]
-    public override Task RestartExecutionsReturnsEmptyDictionaryWhenNoFlowsAreEligible()
-        => RestartExecutionsReturnsEmptyDictionaryWhenNoFlowsAreEligible(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsReturnsEmptyDictionaryWhenNoFlowsAreEligible()
+        => ClaimFunctionsReturnsEmptyDictionaryWhenNoFlowsAreEligible(FunctionStoreFactory.Create());
 
 
 
 
     [TestMethod]
-    public override Task RestartExecutionsRestartsMultipleUnownedFlows()
-        => RestartExecutionsRestartsMultipleUnownedFlows(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsRestartsMultipleUnownedFlows()
+        => ClaimFunctionsRestartsMultipleUnownedFlows(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionsRestartsOnlyUnownedFlows()
-        => RestartExecutionsRestartsOnlyUnownedFlows(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsRestartsOnlyUnownedFlows()
+        => ClaimFunctionsRestartsOnlyUnownedFlows(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionsReturnsEmptyDictionaryForEmptyInput()
-        => RestartExecutionsReturnsEmptyDictionaryForEmptyInput(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsReturnsEmptyDictionaryForEmptyInput()
+        => ClaimFunctionsReturnsEmptyDictionaryForEmptyInput(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionsIncludesExistingEffects()
-        => RestartExecutionsIncludesExistingEffects(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsIncludesExistingEffects()
+        => ClaimFunctionsIncludesExistingEffects(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task SetFunctionUpdatesStatusOwnerAndEffectsWhenGuardMatches()
+        => SetFunctionUpdatesStatusOwnerAndEffectsWhenGuardMatches(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task SetFunctionReturnsFalseAndNoOpsWhenExpectedReplicaDoesNotMatch()
+        => SetFunctionReturnsFalseAndNoOpsWhenExpectedReplicaDoesNotMatch(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task SetFunctionWithNullOwnerReleasesOwnership()
+        => SetFunctionWithNullOwnerReleasesOwnership(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task SetFunctionWithNullEffectsLeavesEffectsUntouched()
+        => SetFunctionWithNullEffectsLeavesEffectsUntouched(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task SetFunctionKeepsPassedSessionCoherentWithPersistedEffects()
+        => SetFunctionKeepsPassedSessionCoherentWithPersistedEffects(FunctionStoreFactory.Create());
 }

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/StoreTests.cs

@@ -171,12 +171,16 @@ public override Task FunctionCanBeCreatedWithEffectsOnly()
         => FunctionCanBeCreatedWithEffectsOnly(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionReturnsEffects()
-        => RestartExecutionReturnsEffects(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionReturnsEffects()
+        => ClaimFunctionReturnsEffects(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionWorksWithEmptyEffects()
-        => RestartExecutionWorksWithEmptyEffects(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionWorksWithEmptyEffects()
+        => ClaimFunctionWorksWithEmptyEffects(FunctionStoreFactory.Create());
+
+    [TestMethod]
+    public override Task ClaimFunctionSurfacesResult()
+        => ClaimFunctionSurfacesResult(FunctionStoreFactory.Create());
 
     [TestMethod]
     public override Task FunctionOwnedByReplicaIsPostponedAfterRescheduleFunctionsInvocation()
@@ -212,14 +216,14 @@ public override Task GetResultsReturnsOnlyExistingFunctionResults()
 
 
     [TestMethod]
-    public override Task RestartExecutionsDoesNotReturnFlowClaimedByPreviousCall()
-        => RestartExecutionsDoesNotReturnFlowClaimedByPreviousCall(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsDoesNotReturnFlowClaimedByPreviousCall()
+        => ClaimFunctionsDoesNotReturnFlowClaimedByPreviousCall(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionsDoesNotClaimSucceededFlow()
-        => RestartExecutionsDoesNotClaimSucceededFlow(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsDoesNotClaimSucceededFlow()
+        => ClaimFunctionsDoesNotClaimSucceededFlow(FunctionStoreFactory.Create());
 
     [TestMethod]
-    public override Task RestartExecutionsClaimsSuspendedFlow()
-        => RestartExecutionsClaimsSuspendedFlow(FunctionStoreFactory.Create());
+    public override Task ClaimFunctionsClaimsSuspendedFlow()
+        => ClaimFunctionsClaimsSuspendedFlow(FunctionStoreFactory.Create());
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/EffectStoreTests.cs

@@ -614,7 +614,7 @@ protected async Task StoreCanHandleMultipleEffectsWithSameIdOnDifferentSessions(
         );
 
         await store.RescheduleCrashedFunctions(crashingReplicaId);
-        var storageSession2 = await store.RestartExecution(
+        var storageSession2 = await store.ClaimFunction(
             storedId,
             owner: ReplicaId.NewId()
         ).SelectAsync(s => s!.StorageSession);