InitialEffect: change Id from int to EffectId

Allows seeding nested-context effects in InitialState, not just root-level ones.

Author: stidsborg

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/FunctionTests/SunshineTests.cs

@@ -356,7 +356,7 @@ await registration.Run(
             param: "hello",
             initialState: new InitialState(
                 Messages: [new MessageAndIdempotencyKey("InitialMessage")],
-                Effects: [new InitialEffect(Id: 0, Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
+                Effects: [new InitialEffect(Id: 0.ToEffectId(), Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
             )
         );
 
@@ -394,7 +394,7 @@ await registration.Run(
             param: "hello",
             initialState: new InitialState(
                 Messages: [new MessageAndIdempotencyKey("InitialMessage")],
-                Effects: [new InitialEffect(Id: 0, Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
+                Effects: [new InitialEffect(Id: 0.ToEffectId(), Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
             )
         );
 
@@ -431,7 +431,7 @@ await registration.Run(
             flowInstance: "hello",
             initialState: new InitialState(
                 Messages: [new MessageAndIdempotencyKey("InitialMessage")],
-                Effects: [new InitialEffect(Id: 0, Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
+                Effects: [new InitialEffect(Id: 0.ToEffectId(), Value: "InitialEffectValue", Exception: null, Alias: "InitialEffectId")]
             )
         );
 
@@ -468,7 +468,7 @@ await registration.Run(
             flowInstance: "hello",
             initialState: new InitialState(
                 Messages: [],
-                Effects: [new InitialEffect(Id: "InitialEffectId".GetHashCode(), Status: WorkStatus.Started)]
+                Effects: [new InitialEffect(Id: "InitialEffectId".GetHashCode().ToEffectId(), Status: WorkStatus.Started)]
             )
         );
 
@@ -503,7 +503,7 @@ await registration.Run(
                 flowInstance: "hello",
                 initialState: new InitialState(
                     Messages: [],
-                    Effects: [new InitialEffect(Id: 0, Exception: new TimeoutException())]
+                    Effects: [new InitialEffect(Id: 0.ToEffectId(), Exception: new TimeoutException())]
                 )
             );
             Assert.Fail("Expected TimeoutException");

Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/InvocationHelper.cs

@@ -470,14 +470,14 @@ public IReadOnlyList<StoredEffect> MapInitialEffects(IEnumerable<InitialEffect>
                 if (e.Value != null)
                     resultBytes = Serializer.Serialize(e.Value, e.Value.GetType());
                 return new StoredEffect(
-                    e.Id.ToEffectId(),
+                    e.Id,
                     e.Status ?? WorkStatus.Completed,
                     Result: resultBytes,
                     StoredException: null,
-                    Alias: e.Alias ?? e.Id.ToString());
+                    Alias: e.Alias ?? e.Id.Serialize().ToStringValue());
             }
             return new StoredEffect(
-                e.Id.ToEffectId(),
+                e.Id,
                 WorkStatus.Failed,
                 Result: null,
                 StoredException: FatalWorkflowException.CreateNonGeneric(flowId, e.Exception).ToStoredException(),

Core/Cleipnir.ResilientFunctions/Domain/InitialState.cs

@@ -13,4 +13,4 @@ public static InitialState CreateWithMessagesOnly(IEnumerable<MessageAndIdempote
         => new(messages, Effects: []);
 }
 
-public record InitialEffect(int Id, object? Value = null, Exception? Exception = null, WorkStatus? Status = null, string? Alias = null);
+public record InitialEffect(EffectId Id, object? Value = null, Exception? Exception = null, WorkStatus? Status = null, string? Alias = null);

Stores/StressTests/StressTests/RestartSuspensionTest.cs

@@ -40,7 +40,7 @@ await registration.Run(
                 instance,
                 new InitialState(
                     [new MessageAndIdempotencyKey("Hello")],
-                    [new InitialEffect(0, Guid.NewGuid())]
+                    [new InitialEffect(0.ToEffectId(), Guid.NewGuid())]
                 )
             );