Interrupt-driven message fetch; merge FetchedMessages into QueueManager#150
Merged
Conversation
Wires up InterruptedWatchdog -> FlowsManager.Interrupt -> QueueManager.Interrupt so message fetching becomes event-driven instead of relying on a per-flow FetchLoop background task. Each Subscribe schedules its own per-subscription Task.Delay for timeout/suspend handling, replacing the centralized FireTimeouts scan. Also merges FetchedMessages into QueueManager - the split was an artifact of the previous polling architecture and a single class better describes "the message queue for a single flow."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchLooppolling task with an event-driven model.InterruptedWatchdog→FlowsManager.Interrupt→QueueManager.Interrupt→FetchAndNotify. Cuts a backgroundTask.Runper flow and removes theMessagesPullFrequencylatency floor on delivery.Subscribeschedules its ownTask.Delaywith aCancellationTokenSource, cancelled when the message arrives. Replaces the centralizedFireTimeoutsscan. The continuation only runsOnlyOnRanToCompletionand guards on_subscriptions.Remove(...)to prevent overwriting a delivered message with a null capture.FetchedMessagesintoQueueManager. The split was an artifact of the polling architecture. A single class better describes "the message queue for a single flow."MessageDatais nowQueueManager.MessageData(public nested record used byQueueClient's capture callback)._effect.RegisterQueueManager(this)and_flowState.QueueManager = thisare now set after initialization completes, so theInterruptedWatchdogcan't reachFetchAndNotifywhile idempotency-key state and delivered-position cleanup are still being set up.Test plan
dotnet test ./Core/Cleipnir.ResilientFunctions.Tests --filter "FullyQualifiedName~InMemoryTests")