Effect: hold FlowState directly instead of FlowsManager + StoredId#153
Merged
Conversation
RunParallelle now calls flowState.SubflowStarted/Completed directly, skipping the per-call dictionary lookup and lock in FlowsManager. FlowsManager.StartThread/CompleteThread are removed as unused. Reordered Invoker.PrepareFor(Re)Invocation so CreateFlow runs before CreateEffect, since Effect now requires the FlowState at construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effectnow stores aFlowStatereference instead ofFlowsManager+StoredId.RunParallellecallsflowState.SubflowStarted/Completeddirectly, skipping the dictionary lookup + lock thatFlowsManager.StartThread/CompleteThreaddid on every call.FlowsManager.StartThread/FlowsManager.CompleteThread.Invoker.PrepareForInvocation/PrepareForReInvocationso_flowsManager.CreateFlow(...)runs beforeCreateEffect(...), sinceEffectnow requires theFlowStateat construction time.Test plan
dotnet build Cleipnir.ResilientFunctions.slncleanEffectTestsandPrintEffectsTests(48 tests) passRunParallelleTestpasses