Skip to content

Make ProcessMessages synchronous now that it no longer awaits #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stidsborg merged 1 commit into from
Jun 27, 2026
Merged

Make ProcessMessages synchronous now that it no longer awaits #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Core/Cleipnir.ResilientFunctions/Queuing/QueueManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public async Task Push(IReadOnlyList<StoredMessage> messages)
if (_thrownException != null)
return;

await ProcessMessages(messages);
ProcessMessages(messages);
}
finally
{
Expand Down Expand Up @@ -200,7 +200,7 @@ private async Task FetchAndNotify()
skipPositions = _fetchedPositions.ToList();

var messages = await _messageStore.GetMessages(_storedId, skipPositions);
await ProcessMessages(messages);
ProcessMessages(messages);
}
finally
{
Expand All @@ -211,7 +211,7 @@ private async Task FetchAndNotify()

// Caller must hold _fetchSemaphore. Deserializes, dedups by idempotency-key and by already-fetched
// position (so pushes are idempotent), and stages messages for delivery.
private async Task ProcessMessages(IReadOnlyList<StoredMessage> messages)
private void ProcessMessages(IReadOnlyList<StoredMessage> messages)
{
foreach (var (messageContent, messageType, position, _, idempotencyKey, sender, receiver) in messages)
{
Expand Down