Add IsLeader property to ClusterInfo#182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the concept of a cluster leader: the replica with the lowest replica id (guid) is the leader.
Rather than storing a separate flag,
ClusterInfo.IsLeaderis derived from state theReplicaWatchdogalready maintains —CalculateOffsetorders all replica ids ascending, so the replica with the lowest guid is exactly the one withOffset == 0. Leadership therefore updates automatically each watchdog iteration as replicas join or crash.A
ReplicaCount > 0guard ensures a replica does not report itself as leader beforeReplicaWatchdog.Initializehas run.The existing
ReplicaIdOffsetIsUpdatedWhenNodeIsAddedAndDeletedtemplate test is extended withIsLeaderassertions, verifying leadership hand-off as replicas are added and deleted across all four store implementations (in-memory, PostgreSQL, MariaDB, SqlServer).🤖 Generated with Claude Code