Internal: Remove ability to export to csv directly from sharedTasksCSV ireport #4862 [autosync]

Author: github-actions[bot]

Solutions/sharedTasks/README.md

@@ -2,7 +2,7 @@
 
 Calls graphs with global objects are useful for finding all global objects accessed by a call tree. But, what if you want to find which global objects are shared between multiple call trees? The shared tasks plugins find global objects accessed from multiple call trees.
 
-The plugin [sharedTasksGraph.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksGraph.upy) displays all the call trees and objects in a single graph, highlighting global objects that are accessed from multiple root functions. The plugin [sharedTasksObjectGraph.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksObjectGraph.upy) does is the reverse - it starts from objects and goes to root functions. The plugin [sharedTasksCSV.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksCSV.upy) displays each reference in a table in an interactive report. It can also export a CSV file at the same time as the interactive report or when run directly from the command line.
+The plugin [sharedTasksGraph.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksGraph.upy) displays all the call trees and objects in a single graph, highlighting global objects that are accessed from multiple root functions. The plugin [sharedTasksObjectGraph.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksObjectGraph.upy) does is the reverse - it starts from objects and goes to root functions. The plugin [sharedTasksCSV.upy](https://raw.githubusercontent.com/stinb/plugins/main/Solutions/sharedTasks/sharedTasksCSV.upy) displays each reference in a table in an interactive report. It can also export a CSV file when run directly from the command line.
 
 ![image](.doc/338366919-ff1f01b2-4970-4c34-ad12-ada42ee13c22.png)
 
@@ -49,10 +49,10 @@ There are a lot of options for building an architecture:
 
 # Exports
 
-The interactive report plugin can be used to generate a CSV file while running the report or from the command line.
+The interactive report plugin can be used to generate a CSV file from the command line.
 
 ```sh
-upython sharedTasksCSV.upy -h
+upython sharedTasksCSV.py -h
 ```
 
-To have a dynamic file name, you can add {arch}, {date}, or {time} (case-insensitive) to the "CSV file name" option (IReport) or `-csvFileName` argument (command line)
+To have a dynamic file name, you can add {arch}, {date}, or {time} (case-insensitive) to the `-csvFileName` command-line argument.

Solutions/sharedTasks/sharedTasksCSV.upy

@@ -1,4 +1,7 @@
-# Command line interface for creating a CSV of an architecture of shared tasks
+# Interactive report listing objects accessed from multiple call trees, with
+# one row per task/function/object reference. Use the report's built-in CSV
+# export (GUI export button or `und report -format csv`) to save the table to
+# disk.
 
 
 from sharedTasksCSV import *
@@ -8,7 +11,7 @@ def name() -> str:
     return 'Shared Tasks CSV'
 
 def description():
-    return '''Export a CSV report of objects accessed from multiple call trees.
+    return '''Interactive report of objects accessed from multiple call trees.
 
     <p>Architectures are used to tag the root functions defining the call trees.
     This report runs on such architectures to highlight global objects accessed
@@ -90,7 +93,7 @@ def test_architecture(arch: Arch) -> bool:
 
 
 def init(report: ReportContext):
-    for option in CSV_OPTIONS:
+    for option in COMMON_OPTIONS:
         # Checkbox
         if option.choices == OPTION_BOOL_CHOICES:
             report.options().checkbox(option.key, option.name, option.default == OPTION_BOOL_TRUE)
@@ -105,11 +108,13 @@ def init(report: ReportContext):
 def generate(report: ReportContext, target: Arch | Ent | Db):
     # Options
     options = dict() # type: dict[str, str | bool]
-    for option in CSV_OPTIONS:
+    for option in COMMON_OPTIONS:
         value = report.options().lookup(option.key)
         if option.choices == OPTION_DEPTH_CHOICES and value != 'All':
             value = int(value)
         options[option.key] = value
+    # Suppress the on-disk CSV path in generateCSV(); rely on the GUI/CLI
+    # CSV export of the rendered table instead.
+    options[AUTO_EXPORT] = False
 
-    # Export file and print lines to report
     generateCSV(report.db(), target, options, report)