Fix clippy errors

Author: stippi

crates/code_assistant/src/agent/runner.rs

@@ -702,15 +702,11 @@ impl Agent {
         let parser = parser.as_ref();
         let mut removed = 0usize;
 
-        loop {
-            let Some(last_assistant_idx) = self
-                .message_history
-                .iter()
-                .rposition(|message| message.role == MessageRole::Assistant)
-            else {
-                break;
-            };
-
+        while let Some(last_assistant_idx) = self
+            .message_history
+            .iter()
+            .rposition(|message| message.role == MessageRole::Assistant)
+        {
             let last_assistant = &self.message_history[last_assistant_idx];
 
             if !parser.message_contains_tool_invocation(last_assistant) {
@@ -1876,7 +1872,7 @@ impl Agent {
         }
 
         // Sort descending by size
-        sizes.sort_by(|a, b| b.1.cmp(&a.1));
+        sizes.sort_by_key(|item| std::cmp::Reverse(item.1));
 
         // Replace results that are above a minimum threshold (50KB) — there is no
         // point replacing tiny results since they are unlikely to be the cause.

crates/code_assistant/src/persistence.rs

@@ -672,7 +672,7 @@ impl FileSessionPersistence {
             };
 
         // Sort by updated_at in descending order (newest first)
-        metadata_list.sort_by(|a, b| b.updated_at.cmp(&a.updated_at));
+        metadata_list.sort_by_key(|item| std::cmp::Reverse(item.updated_at));
 
         Ok(metadata_list)
     }

crates/code_assistant/src/session/instance.rs

@@ -833,11 +833,9 @@ impl UserInterface for ProxyUI {
             UiEvent::UpdateSessionActivityState {
                 session_id,
                 activity_state,
-            } => {
-                if session_id == &self.session_id {
-                    self.update_activity_state(activity_state.clone());
-                    return Ok(());
-                }
+            } if session_id == &self.session_id => {
+                self.update_activity_state(activity_state.clone());
+                return Ok(());
             }
             _ => {}
         }

crates/code_assistant/src/ui/gpui/elements.rs

@@ -1514,7 +1514,7 @@ impl BlockView {
             && (block.status == ToolStatus::Pending || block.status == ToolStatus::Running);
 
         // --- Build the element ---
-        let mut container = div().w_full();
+        let mut container = div().w_full().mt_0p5();
 
         // Header line: clickable area with icon + description + chevron-on-hover
         let header = div()
@@ -1629,6 +1629,7 @@ impl Render for BlockView {
     fn render(&mut self, window: &mut gpui::Window, cx: &mut Context<Self>) -> impl IntoElement {
         match self.block.clone() {
             BlockData::TextBlock(block) => div()
+                .mt_3()
                 .text_color(cx.theme().foreground)
                 .child(self.markdown_view(&block.content, true, cx))
                 .into_any_element(),
@@ -1664,6 +1665,7 @@ impl Render for BlockView {
                 let text_color = cx.theme().info_foreground;
 
                 div()
+                    .mt_2()
                     .rounded_md()
                     .bg(thinking_bg)
                     .flex()
@@ -1828,24 +1830,29 @@ impl Render for BlockView {
                                     window,
                                     cx,
                                 ) {
-                                    return element;
+                                    return div().mt_2().child(element).into_any_element();
                                 }
                                 // Renderer returned None (e.g. parameters still
                                 // streaming) — show a skeleton card with just
                                 // the header so we don't flash a raw "[name]"
                                 // placeholder.
-                                return self.render_card_skeleton(
-                                    &block,
-                                    renderer.as_ref(),
-                                    &theme,
-                                );
+                                return div()
+                                    .mt_2()
+                                    .child(self.render_card_skeleton(
+                                        &block,
+                                        renderer.as_ref(),
+                                        &theme,
+                                    ))
+                                    .into_any_element();
                             }
                         }
                     } else {
                         tracing::warn!("No ToolBlockRenderer registered for tool '{}'", block.name);
                     }
                 }
+
                 div()
+                    .mt_0p5()
                     .px_2()
                     .py_1()
                     .text_color(cx.theme().muted_foreground)
@@ -1926,6 +1933,7 @@ impl Render for BlockView {
                 }
 
                 div()
+                    .mt_2()
                     .rounded_md()
                     .border_1()
                     .border_color(cx.theme().border)
@@ -1939,8 +1947,8 @@ impl Render for BlockView {
             }
             BlockData::ImageBlock(block) => {
                 if let Some(image) = &block.image {
-                    // Render the actual image - margins/spacing handled by parent container
                     div()
+                        .mt_2()
                         .flex_none() // Don't grow or shrink
                         .child(
                             div()
@@ -1960,6 +1968,7 @@ impl Render for BlockView {
                 } else {
                     // Fallback to placeholder if image parsing failed
                     div()
+                        .mt_2()
                         .flex_none()
                         .p_2()
                         .bg(cx.theme().warning.opacity(0.1))

crates/code_assistant/src/ui/gpui/messages.rs

@@ -553,18 +553,25 @@ impl MessagesView {
         };
 
         // Create message container with appropriate styling.
-        // p_3 provides interior padding. max_w is applied via the centering
-        // wrapper returned at the end of this function.
-        let mut message_container = div().w_full().p_3().flex().flex_col().gap(rems(0.625));
-
-        if is_user_message {
-            message_container = message_container
+        // max_w is applied via the centering wrapper returned at the end.
+        // For user messages: uniform padding + gap between children.
+        // For assistant messages: only horizontal padding; each block controls
+        // its own vertical margin so inline tools can be tighter than text.
+        let message_container = if is_user_message {
+            div()
+                .w_full()
+                .p_3()
+                .flex()
+                .flex_col()
+                .gap(rems(0.625))
                 .bg(cx.theme().muted)
                 .border_1()
                 .border_color(cx.theme().border)
                 .rounded_md()
-                .shadow_xs();
-        }
+                .shadow_xs()
+        } else {
+            div().w_full().px_3().pb_1().flex().flex_col()
+        };
 
         // Create message container with user badge and edit button if needed
         let message_container = if is_user_message {

crates/code_assistant/src/ui/gpui/mod.rs

@@ -2422,6 +2422,9 @@ impl Gpui {
                 // Trigger a re-render so the sidebar picks up the change.
                 cx.refresh();
             }
+            BackendResponse::ProjectAlreadyExists { project_name } => {
+                info!("Project '{}' already exists — nothing to do", project_name);
+            }
         }
     }
 }

crates/code_assistant/src/ui/streaming/test_utils.rs

@@ -60,13 +60,9 @@ impl TestUI {
                     value: new_value,
                     tool_id: new_id,
                 },
-            ) => {
-                if last_name == new_name && last_id == new_id {
-                    last_value.push_str(new_value);
-                    true
-                } else {
-                    false
-                }
+            ) if last_name == new_name && last_id == new_id => {
+                last_value.push_str(new_value);
+                true
             }
 
             // No other fragments can be merged