feat: Migrate git backend to gix#117
Open
davidkna-sap wants to merge 1 commit into
Open
Conversation
Owner
|
Hey, thrilled to get a PR from you! I am on vacation and left any computer at home. So will take a closer look with a slight delay. The git stuff is currently not very well tested. I wanted to add worktree support (the dropdown below the input area) but then worked in projects that have no git at the root for the most part. Feel free to come up with ideas for UX towards supporting that setup. Checkpoints and a "diff view" are also on my mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
git2with rust-nativegix.Authored via CC as this project not fully working on my system, and as such mostly tested via the unit test setup.
Possible regressions:
gixdoes not yet fully support reftable, sparse indices and sha256 repos, thought some of these are also lacking in libgit2 iirc.Also optimised
GitBinary::commandwithGIT_OPTIONAL_LOCKSa bit. By the way I would argue disablingcore.fsmonitoris less useful If you are still executing git hooks.