fix(#260): enhance Nova module validation commands and logging

- Introduced new functions for command generation and execution
- Improved error handling for validation command failures
- Updated logging to capture command execution details

Author: stiwicourage

scripts/build/ci/Invoke-NovaModuleToolsCI.ps1

@@ -16,29 +16,58 @@ function Copy-NovaModuleToolsArtifactIfPresent {
     }
 }
 
+function ConvertTo-NovaSingleQuotedPowerShellLiteral {
+    param(
+        [Parameter(Mandatory)][string]$Value
+    )
+
+    return "'$($Value.Replace("'", "''") )'"
+}
+
+function Get-NovaModuleToolsValidationCommand {
+    param(
+        [Parameter(Mandatory)][string]$BuiltModulePath,
+        [Parameter(Mandatory)][string]$CommandName,
+        [string[]]$ExcludeTag = @()
+    )
+
+    $commandLine = $CommandName
+    if (@($ExcludeTag).Count -gt 0) {
+        $excludeTagLiteral = @($ExcludeTag | ForEach-Object {ConvertTo-NovaSingleQuotedPowerShellLiteral -Value ([string]$_)}) -join ', '
+        $commandLine += " -ExcludeTagFilter @($excludeTagLiteral)"
+    }
+
+    return "Import-Module $( ConvertTo-NovaSingleQuotedPowerShellLiteral -Value $BuiltModulePath ) -Force -ErrorAction Stop; $commandLine"
+}
+
+function Invoke-NovaModuleToolsFreshValidationCommand {
+    param(
+        [Parameter(Mandatory)][string]$Command
+    )
+
+    & pwsh -NoLogo -NoProfile -Command $Command
+    if ($LASTEXITCODE -ne 0) {
+        throw "Validation command failed: $Command"
+    }
+}
+
 $repoRoot = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..' '..' '..')).Path
 Set-Location $repoRoot
 New-Item -ItemType Directory -Path $OutputDirectory -Force | Out-Null
 
 Import-Module NovaModuleTools -ErrorAction Stop
 
-Invoke-NovaBuild
-
-$projectInfo = Get-NovaProjectInfo
-$builtModulePath = $projectInfo.OutputModuleDir
-Remove-Module $projectInfo.ProjectName -ErrorAction SilentlyContinue
-Import-Module $builtModulePath -Force
 $projectInfo = Get-NovaProjectInfo
+Invoke-NovaBuild
+$builtModulePath = Join-Path $projectInfo.OutputModuleDir "$( $projectInfo.ProjectName ).psd1"
 
 $novaModuleToolsTestFailed = $false
 try {
-    if (@($ExcludeTag).Count -gt 0) {
-        Invoke-NovaTest -ExcludeTagFilter $ExcludeTag
-        Test-NovaBuild -ExcludeTagFilter $ExcludeTag
-    } else {
-        Invoke-NovaTest
-        Test-NovaBuild
-    }
+    $unitTestCommand = Get-NovaModuleToolsValidationCommand -BuiltModulePath $builtModulePath -CommandName 'Invoke-NovaTest' -ExcludeTag $ExcludeTag
+    Invoke-NovaModuleToolsFreshValidationCommand -Command $unitTestCommand
+
+    $buildValidationCommand = Get-NovaModuleToolsValidationCommand -BuiltModulePath $builtModulePath -CommandName 'Test-NovaBuild' -ExcludeTag $ExcludeTag
+    Invoke-NovaModuleToolsFreshValidationCommand -Command $buildValidationCommand
 } catch {
     $novaModuleToolsTestFailed = $true
     Write-Warning "Nova test workflow failed: $( $_.Exception.Message )"

tests/Invoke-NovaModuleToolsCI.Tests.ps1

@@ -37,7 +37,7 @@ Describe 'Invoke-NovaModuleToolsCI' {
         $projectRoot = Join-Path $TestDrive 'project'
         $outputDirectory = Join-Path $TestDrive 'artifacts-out'
         $callLogPath = Join-Path $TestDrive 'call-log.txt'
-        $excludeTagLogPath = Join-Path $TestDrive 'exclude-tags.txt'
+        $commandLogPath = Join-Path $TestDrive 'commands.txt'
         $unitResultPath = Join-Path $projectRoot 'artifacts/UnitTestResults.xml'
         $integrationResultPath = Join-Path $projectRoot 'artifacts/TestResults.xml'
 
@@ -64,24 +64,24 @@ function Get-NovaProjectInfo {
     }
 }
 
-function Remove-Module {
+function pwsh {
     [CmdletBinding()]
-    param([string]`$Name)
-}
-
-function Invoke-NovaTest {
-    [CmdletBinding()]
-    param([string[]]`$ExcludeTagFilter)
+    param(
+        [switch]`$NoLogo,
+        [switch]`$NoProfile,
+        [string]`$Command
+    )
 
-    Add-Content -LiteralPath '$callLogPath' -Value 'Invoke-NovaTest'
-    Set-Content -LiteralPath '$excludeTagLogPath' -Value (`$ExcludeTagFilter -join ',') -Encoding utf8
-}
+    Add-Content -LiteralPath '$commandLogPath' -Value `$Command
+    if (`$Command -match 'Invoke-NovaTest') {
+        Add-Content -LiteralPath '$callLogPath' -Value 'Invoke-NovaTest'
+    }
 
-function Test-NovaBuild {
-    [CmdletBinding()]
-    param([string[]]`$ExcludeTagFilter)
+    if (`$Command -match 'Test-NovaBuild') {
+        Add-Content -LiteralPath '$callLogPath' -Value 'Test-NovaBuild'
+    }
 
-    Add-Content -LiteralPath '$callLogPath' -Value 'Test-NovaBuild'
+    `$global:LASTEXITCODE = 0
 }
 
 & '$script:novaModuleToolsCiScriptPath' -OutputDirectory '$outputDirectory' -ExcludeTag 'slow','integration'
@@ -90,7 +90,10 @@ function Test-NovaBuild {
 
         $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)
         (Get-Content -LiteralPath $callLogPath) | Should -Be @('Invoke-NovaTest', 'Test-NovaBuild')
-        (Get-Content -LiteralPath $excludeTagLogPath -Raw).Trim() | Should -Be 'slow,integration'
+        $commands = Get-Content -LiteralPath $commandLogPath
+        $commands | Should -HaveCount 2
+        $commands[0] | Should -Match "Import-Module '.*/dist/NovaModuleTools/NovaModuleTools\.psd1' -Force -ErrorAction Stop; Invoke-NovaTest -ExcludeTagFilter @\('slow', 'integration'\)"
+        $commands[1] | Should -Match "Import-Module '.*/dist/NovaModuleTools/NovaModuleTools\.psd1' -Force -ErrorAction Stop; Test-NovaBuild -ExcludeTagFilter @\('slow', 'integration'\)"
         (Get-Content -LiteralPath (Join-Path $outputDirectory 'novamoduletools-unit-nunit.xml') -Raw).Trim() | Should -Be '<unit-test-results />'
         (Get-Content -LiteralPath (Join-Path $outputDirectory 'novamoduletools-integration-nunit.xml') -Raw).Trim() | Should -Be '<integration-test-results />'
     }
@@ -122,24 +125,29 @@ function Get-NovaProjectInfo {
     }
 }
 
-function Remove-Module {
+function pwsh {
     [CmdletBinding()]
-    param([string]`$Name)
-}
+    param(
+        [switch]`$NoLogo,
+        [switch]`$NoProfile,
+        [string]`$Command
+    )
 
-function Invoke-NovaTest {
-    throw 'boom'
-}
+    if (`$Command -match 'Invoke-NovaTest') {
+        `$global:LASTEXITCODE = 1
+        return
+    }
 
-function Test-NovaBuild {}
+    `$global:LASTEXITCODE = 0
+}
 
 & '$script:novaModuleToolsCiScriptPath' -OutputDirectory '$outputDirectory'
 "@
         $result = Invoke-NovaModuleToolsCIRunner -RunnerContent $runnerContent
         $outputText = $result.Output -join [Environment]::NewLine
 
         $result.ExitCode | Should -Be 1
-        $outputText | Should -Match 'Nova test workflow failed: boom'
+        $outputText | Should -Match 'Nova test workflow failed: Validation command failed: .*Invoke-NovaTest'
         (Get-Content -LiteralPath (Join-Path $outputDirectory 'novamoduletools-unit-nunit.xml') -Raw).Trim() | Should -Be '<failed-unit-test-results />'
         Test-Path -LiteralPath (Join-Path $outputDirectory 'novamoduletools-integration-nunit.xml') | Should -BeFalse
     }