feat(#194): simplify CI to single test run with JaCoCo coverage upload

 - Remove second Invoke-Pester run from Invoke-NovaModuleToolsCI.ps1;
   Test-NovaBuild now runs once and produces artifacts/coverage.xml
 - Remove Cobertura conversion helpers, SetSourcePath guard, and
   Get-CiPesterConfiguration/Get-CiTestPath functions from CI script
 - Update Invoke-CodeSceneAnalysis.ps1 to resolve artifacts/coverage.xml
   as the default JaCoCo coverage path instead of *.cobertura.xml
 - Upload coverage twice: --format jacoco --metric line-coverage and
   --metric branch-coverage
 - Add --format jacoco to cs-coverage check in check-coverage action
 - Update Tests.yml coverage-files glob to **/coverage.xml
 - Update CodeSceneAnalysis tests for JaCoCo double-upload behaviour
 - Update testing-policy instructions to document single-run JaCoCo flow

Author: stiwicourage

.github/actions/check-coverage/action.yml

@@ -30,5 +30,5 @@ runs:
         CS_ACCESS_TOKEN: ${{ inputs.access-token }}
       run: |
         set -euo pipefail
-        find "$(pwd)" -name '*.cobertura.xml' -print
+        find "$(pwd)" -name 'coverage.xml' -print
         "$(pwd)/cs-coverage" check --verbose --coverage-files "${{ inputs.coverage-files }}"

.github/instructions/testing-policy.instructions.md

@@ -36,7 +36,9 @@ Use this file when changing production code, tests, coverage behavior, or CI tes
 ## Coverage and CodeScene
 
 - CI coverage is generated by `./scripts/build/ci/Invoke-NovaModuleToolsCI.ps1`.
-- The Cobertura artifact is reused by the CodeScene PR coverage gate and by the develop/manual CodeScene analysis flow.
+- `Test-NovaBuild` runs once and produces a JaCoCo coverage report at `artifacts/coverage.xml`.
+- The JaCoCo artifact is reused by the CodeScene PR coverage gate and by the develop/manual CodeScene analysis flow.
+- The CodeScene analysis upload sends coverage twice: once for `line-coverage` and once for `branch-coverage`.
 - If CodeScene flags coverage or duplication, fix the underlying test design instead of suppressing the warning casually.
 
 ## Common pitfalls

.github/workflows/Tests.yml

@@ -119,7 +119,7 @@ jobs:
         with:
           access-token: ${{ secrets.CS_ACCESS_TOKEN }}
           project-url: ${{ format('{0}/v2/projects/{1}', vars.CS_URL, vars.CS_PROJECT_ID) }}
-          coverage-files: '**/pester-coverage.cobertura.xml'
+          coverage-files: '**/coverage.xml'
 
   codescene-analysis:
     runs-on: ubuntu-latest

scripts/build/ci/Invoke-CodeSceneAnalysis.ps1

@@ -58,18 +58,12 @@ function Resolve-CodeSceneCoveragePath {
         return (Resolve-Path -LiteralPath $CoveragePath -ErrorAction Stop).Path
     }
 
-    $artifactsDir = Join-Path (Get-Location) 'artifacts'
-    $coverageCandidates = @(Get-ChildItem -LiteralPath $artifactsDir -Filter '*.cobertura.xml' -File -Recurse -ErrorAction SilentlyContinue | Sort-Object FullName)
-    if (-not $coverageCandidates) {
-        throw "No Cobertura coverage file was found under '$artifactsDir'. Provide -CoveragePath explicitly or run the CI coverage workflow first."
+    $defaultPath = Join-Path (Get-Location) 'artifacts' 'coverage.xml'
+    if (-not (Test-Path -LiteralPath $defaultPath)) {
+        throw "No JaCoCo coverage file was found at '$defaultPath'. Provide -CoveragePath explicitly or run the CI coverage workflow first."
     }
 
-    if ($coverageCandidates.Count -gt 1) {
-        $candidateList = ($coverageCandidates | ForEach-Object FullName) -join ', '
-        throw "Multiple Cobertura coverage files were found under '$artifactsDir'. Provide -CoveragePath explicitly. Candidates: $candidateList"
-    }
-
-    return $coverageCandidates[0].FullName
+    return $defaultPath
 }
 
 function Invoke-CodeSceneAnalysisTrigger {
@@ -128,9 +122,14 @@ if ($shouldUploadCoverage) {
         throw "The 'cs-coverage' CLI was not found on PATH. Install the CodeScene coverage upload tool before running this script."
     }
 
-    & cs-coverage upload --format 'cobertura' --metric 'line-coverage' $resolvedCoveragePath
+    & cs-coverage upload --format 'jacoco' --metric 'line-coverage' $resolvedCoveragePath
+    if ($LASTEXITCODE -ne 0) {
+        throw "CodeScene line-coverage upload failed with exit code $LASTEXITCODE."
+    }
+
+    & cs-coverage upload --format 'jacoco' --metric 'branch-coverage' $resolvedCoveragePath
     if ($LASTEXITCODE -ne 0) {
-        throw "CodeScene coverage upload failed with exit code $LASTEXITCODE."
+        throw "CodeScene branch-coverage upload failed with exit code $LASTEXITCODE."
     }
 }
 

scripts/build/ci/Invoke-NovaModuleToolsCI.ps1

@@ -5,42 +5,6 @@ param(
 
 Set-StrictMode -Version Latest
 
-. (Join-Path $PSScriptRoot 'CodeSceneCoverageMap.ps1')
-. (Join-Path $PSScriptRoot 'CodeSceneCoverageXml.ps1')
-. (Join-Path $PSScriptRoot 'CoverageLowReport.ps1')
-
-function Get-CiTestPath {
-    param([Parameter(Mandatory)][pscustomobject]$ProjectInfo)
-
-    if ($ProjectInfo.BuildRecursiveFolders) {
-        return $ProjectInfo.TestsDir
-    }
-
-    return [System.IO.Path]::Join($ProjectInfo.TestsDir, '*.Tests.ps1')
-}
-
-function Get-CiPesterConfiguration {
-    param(
-        [Parameter(Mandatory)][pscustomobject]$ProjectInfo,
-        [Parameter(Mandatory)][string]$ArtifactsDirectory,
-        [string[]]$ExcludedTags = @()
-    )
-
-    $configuration = New-PesterConfiguration
-    $configuration.Run.Path = Get-CiTestPath -ProjectInfo $ProjectInfo
-    $configuration.Run.PassThru = $true
-    $configuration.Filter.ExcludeTag = @($ExcludedTags)
-    $configuration.TestResult.Enabled = $true
-    $configuration.TestResult.OutputFormat = 'JUnitXml'
-    $configuration.TestResult.OutputPath = (Join-Path $ArtifactsDirectory 'pester-junit.xml')
-    $configuration.CodeCoverage.Enabled = $true
-    $configuration.CodeCoverage.Path = @($ProjectInfo.ModuleFilePSM1)
-    $configuration.CodeCoverage.OutputFormat = 'Cobertura'
-    $configuration.CodeCoverage.OutputPath = (Join-Path $ArtifactsDirectory 'pester-coverage.cobertura.xml')
-
-    return $configuration
-}
-
 function Copy-NovaModuleToolsTestResultIfPresent {
     param(
         [Parameter(Mandatory)][string]$ProjectRoot,
@@ -58,7 +22,6 @@ Set-Location $repoRoot
 New-Item -ItemType Directory -Path $OutputDirectory -Force | Out-Null
 
 Import-Module NovaModuleTools -ErrorAction Stop
-Import-Module Pester -ErrorAction Stop
 
 Invoke-NovaBuild
 
@@ -68,10 +31,6 @@ Remove-Module $projectInfo.ProjectName -ErrorAction SilentlyContinue
 Import-Module $builtModulePath -Force
 $projectInfo = Get-NovaProjectInfo
 
-if (-not $projectInfo.SetSourcePath) {
-    throw "Code coverage upload requires project.json to set SetSourcePath=true so dist line coverage can be remapped back to src/ files for CodeScene."
-}
-
 $novaModuleToolsTestFailed = $false
 try {
     if (@($ExcludeTag).Count -gt 0) {
@@ -86,11 +45,6 @@ try {
     Copy-NovaModuleToolsTestResultIfPresent -ProjectRoot $projectInfo.ProjectRoot -ArtifactsDirectory $OutputDirectory
 }
 
-$configuration = Get-CiPesterConfiguration -ProjectInfo $projectInfo -ArtifactsDirectory $OutputDirectory -ExcludedTags $ExcludeTag
-$result = Invoke-Pester -Configuration $configuration
-Convert-CoberturaCoverageToSourcePath -CoveragePath (Join-Path $OutputDirectory 'pester-coverage.cobertura.xml') -BuiltModulePath $projectInfo.ModuleFilePSM1 -RepoRoot $projectInfo.ProjectRoot
-Write-CoverageLowReport -CoveragePath (Join-Path $OutputDirectory 'pester-coverage.cobertura.xml') -OutputPath (Join-Path $OutputDirectory 'coverage-low.txt')
-
-if ($novaModuleToolsTestFailed -or $result.FailedCount -gt 0) {
+if ($novaModuleToolsTestFailed) {
     exit 1
 }

src/resources/agentic-copilot/.github/instructions/testing-policy.instructions.md

@@ -36,7 +36,9 @@ Use this file when changing production code, tests, coverage behavior, or CI tes
 ## Coverage and quality tooling
 
 - CI coverage is generated by the repository-specific CI helper when one exists.
-- Coverage artifacts should stay compatible with the repository quality flow when one exists.
+- `Test-NovaBuild` runs once and produces a JaCoCo coverage report at `artifacts/coverage.xml`.
+- The JaCoCo artifact is reused by the quality tooling PR coverage gate and by the develop/manual quality tooling analysis flow.
+- The quality tooling analysis upload sends coverage twice: once for `line-coverage` and once for `branch-coverage`.
 - If quality tooling flags coverage or duplication, fix the underlying test design instead of suppressing the warning casually.
 
 ## Common pitfalls

tests/CodeSceneAnalysis.Tests.ps1

@@ -82,15 +82,15 @@ function Invoke-WebRequest {
     }
 
     It 'still uploads coverage when CoveragePath is provided' {
-        $coveragePath = Join-Path $TestDrive 'pester-coverage.cobertura.xml'
+        $coveragePath = Join-Path $TestDrive 'coverage.xml'
         $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload.txt'
-        Set-Content -LiteralPath $coveragePath -Value '<coverage />' -Encoding utf8
+        Set-Content -LiteralPath $coveragePath -Value '<report />' -Encoding utf8
 
         $runnerContent = @"
 function cs-coverage {
     param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
 
-    Set-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
+    Add-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
     `$global:LASTEXITCODE = 0
 }
 
@@ -104,21 +104,23 @@ function cs-coverage {
         $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
 
         $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)
-        (Get-Content -LiteralPath $uploadLogPath -Raw) | Should -BeLike "upload --format cobertura --metric line-coverage $coveragePath*"
+        $uploadLog = Get-Content -LiteralPath $uploadLogPath -Raw
+        $uploadLog | Should -BeLike "upload --format jacoco --metric line-coverage $coveragePath*"
+        $uploadLog | Should -Match 'upload --format jacoco --metric branch-coverage'
     }
 
     It 'uploads coverage from the artifacts folder when UploadCoverage is requested without CoveragePath' {
         $artifactsDir = Join-Path $TestDrive 'artifacts'
-        $coveragePath = Join-Path $artifactsDir 'ci-generated.cobertura.xml'
+        $coveragePath = Join-Path $artifactsDir 'coverage.xml'
         $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload-discovered.txt'
         New-Item -ItemType Directory -Path $artifactsDir -Force | Out-Null
-        Set-Content -LiteralPath $coveragePath -Value '<coverage />' -Encoding utf8
+        Set-Content -LiteralPath $coveragePath -Value '<report />' -Encoding utf8
 
         $runnerContent = @"
 function cs-coverage {
     param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
 
-    Set-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
+    Add-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
     `$global:LASTEXITCODE = 0
 }
 
@@ -133,10 +135,12 @@ Set-Location '$TestDrive'
         $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
 
         $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)
-        (Get-Content -LiteralPath $uploadLogPath -Raw) | Should -BeLike "upload --format cobertura --metric line-coverage $coveragePath*"
+        $uploadLog = Get-Content -LiteralPath $uploadLogPath -Raw
+        $uploadLog | Should -BeLike "upload --format jacoco --metric line-coverage $coveragePath*"
+        $uploadLog | Should -Match 'upload --format jacoco --metric branch-coverage'
     }
 
-    It 'fails clearly when UploadCoverage is requested but no Cobertura artifact exists' {
+    It 'fails clearly when UploadCoverage is requested but no JaCoCo artifact exists' {
         $emptyWorkingDir = Join-Path $TestDrive 'no-coverage-artifacts'
         New-Item -ItemType Directory -Path $emptyWorkingDir -Force | Out-Null
 
@@ -156,6 +160,6 @@ Set-Location '$emptyWorkingDir'
         $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
 
         $result.ExitCode | Should -Not -Be 0
-        ($result.Output -join [Environment]::NewLine) | Should -Match 'No Cobertura coverage file was found under'
+        ($result.Output -join [Environment]::NewLine) | Should -Match 'No JaCoCo coverage file was found at'
     }
 }