fix(#138): update no-update messages for clarity

- Simplify output for no updates available
- Remove outdated information about update candidates

Author: stiwicourage

CHANGELOG.md

@@ -34,8 +34,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     usage.
   - Uses the stored prerelease update preference to decide whether prerelease self-updates are eligible.
   - Requires explicit confirmation before a prerelease self-update proceeds.
-  - `% nova update` now reports the current `PSGallery` lookup candidate in no-update output instead of claiming the
-    installed version is universally the newest available.
 - Add `% nova version --installed` / `% nova version -i` so users can compare the locally installed version of the
   current project/module with the current project version from `project.json`, while keeping `% nova --version` /
   `% nova -v` dedicated to the installed NovaModuleTools version.

README.md

@@ -107,9 +107,6 @@ preference to decide whether prerelease self-updates are eligible. When prerelea
 self-update stays on stable releases. When they are enabled, self-update may target a prerelease, but it asks for
 explicit confirmation before proceeding.
 
-`% nova update` checks PowerShell Gallery (`PSGallery`) for its current update candidate. When no update is applied,
-the CLI reports the installed version together with the candidate returned from that lookup instead of claiming the
-installed version is universally the newest available.
 
 Successful `Update-NovaModuleTool`, CLI:`% nova update`, and `Install-NovaCli` runs print the release notes link from
 the

src/private/cli/FormatNovaCliCommandResult.ps1

@@ -50,21 +50,6 @@ function Format-NovaCliVersionUpdateResult {
     return "$summaryPrefix $( $Result.PreviousVersion ) -> $( $Result.NewVersion ) | Label: $( $Result.Label ) | Commits: $( $Result.CommitCount )"
 }
 
-function Get-NovaCliNoUpdateDetail {
-    [CmdletBinding()]
-    param([Parameter(Mandatory)][object]$Result)
-
-    if (-not [string]::IsNullOrWhiteSpace($Result.LookupCandidateVersion) -and -not [string]::IsNullOrWhiteSpace($Result.LookupRepository)) {
-        return "Installed: $( $Result.ModuleName ) $( $Result.CurrentVersion ). $( $Result.LookupRepository ) currently reports $( $Result.LookupCandidateVersion ) as the latest update candidate checked."
-    }
-
-    if (-not [string]::IsNullOrWhiteSpace($Result.LookupCandidateVersion)) {
-        return "Installed: $( $Result.ModuleName ) $( $Result.CurrentVersion ). The current update lookup reports $( $Result.LookupCandidateVersion ) as the latest candidate checked."
-    }
-
-    return "Installed: $( $Result.ModuleName ) $( $Result.CurrentVersion ). No update candidate is currently available from the configured update source."
-}
-
 function Format-NovaCliCommandResult {
     [CmdletBinding()]
     param(
@@ -74,8 +59,8 @@ function Format-NovaCliCommandResult {
 
     if (Test-NovaCliNoUpdateResult -Command $Command -Result $Result) {
         return @(
-            'No update was applied.'
-            (Get-NovaCliNoUpdateDetail -Result $Result)
+            "You're up to date!"
+            "$( $Result.ModuleName ) $( $Result.CurrentVersion ) is currently the newest version available."
         )
     }
 

tests/UpdateNotification.Tests.ps1

@@ -596,8 +596,8 @@ Describe 'Update notification behavior' {
             $result = @(Invoke-NovaCli update)
 
             $result | Should -HaveCount 2
-            $result[0] | Should -Be 'No update was applied.'
-            $result[1] | Should -Be 'Installed: NovaModuleTools 2.0.0-prerelease3. PSGallery currently reports 2.0.0-beta as the latest update candidate checked.'
+            $result[0] | Should -Be "You're up to date!"
+            $result[1] | Should -Be 'NovaModuleTools 2.0.0-prerelease3 is currently the newest version available.'
             Assert-MockCalled Update-NovaModuleTool -Times 1
         }
     }