feat(#133): enhance test coverage and fix CLI help errors

stiwicourage · stiwicourage · commit 2d98dc6e3154 · 2026-04-28T17:59:40.000+02:00
- Fix unsupported `nova` help invocations to return structured CLI validation errors
- Align manifest/package helper edge cases with intended behavior
- Add tests for CLI helper functions and project manifest resolution
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -81,6 +81,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fix unsupported `nova` help invocations so they now return Nova's structured CLI validation error instead of a
+  PowerShell parameter-binding failure.
+- Keep manifest/package helper edge cases aligned with their intended behavior.
+    - Manifest settings resolution now accepts ordered dictionary metadata shapes in addition to plain hashtables.
+    - `New-NovaPackageArtifacts` now accepts an empty metadata list and returns an empty artifact result instead of
+      failing during parameter binding.
 - Centralize delivery configuration resolution so raw package upload, update notification settings, and PSGallery
   publishing now follow one explicit precedence model without surfacing configured secrets in error text.
     - Raw upload now resolves command overrides before named repository settings, then package defaults.
diff --git a/src/private/cli/GetNovaCliHelpRequest.ps1 b/src/private/cli/GetNovaCliHelpRequest.ps1
@@ -44,7 +44,7 @@ function Get-NovaCliRootHelpRequest {
         return Get-NovaCliResolvedHelpRequest -Command $Arguments[0] -View Long -TargetType Command
     }
 
-    Assert-NovaCliHelpUsageSupported -Tokens @('--help') + $Arguments
+    Assert-NovaCliHelpUsageSupported -Tokens (@('--help') + $Arguments)
 }
 
 function Get-NovaCliSubcommandHelpRequest {
@@ -63,7 +63,7 @@ function Get-NovaCliSubcommandHelpRequest {
     }
 
     if (@($Arguments | Where-Object {Test-NovaCliHelpToken -Argument $_}).Count -gt 0) {
-        Assert-NovaCliHelpUsageSupported -Tokens @($Command) + $Arguments
+        Assert-NovaCliHelpUsageSupported -Tokens (@($Command) + $Arguments)
     }
 
     return $null
diff --git a/src/private/package/NewNovaPackageArtifacts.ps1 b/src/private/package/NewNovaPackageArtifacts.ps1
@@ -4,7 +4,7 @@ function New-NovaPackageArtifacts {
     [CmdletBinding()]
     param(
         [Parameter(Mandatory)][pscustomobject]$ProjectInfo,
-        [Parameter(Mandatory)][object[]]$PackageMetadataList
+        [Parameter(Mandatory)][AllowEmptyCollection()][object[]]$PackageMetadataList
     )
 
     $resolvedPackageMetadataList = @($PackageMetadataList)
diff --git a/src/private/shared/GetNovaResolvedProjectManifestSettings.ps1 b/src/private/shared/GetNovaResolvedProjectManifestSettings.ps1
@@ -5,7 +5,7 @@ function Get-NovaResolvedProjectManifestSettings {
         [Parameter(Mandatory)][hashtable]$ProjectData
     )
 
-    if ($ProjectData.ContainsKey('Manifest') -and $ProjectData['Manifest'] -is [hashtable]) {
+    if ($ProjectData.ContainsKey('Manifest') -and $ProjectData['Manifest'] -is [System.Collections.IDictionary]) {
         return [ordered]@{} + $ProjectData['Manifest']
     }
 
diff --git a/tests/CliHelperCoverage.Tests.ps1 b/tests/CliHelperCoverage.Tests.ps1
@@ -0,0 +1,130 @@
+$script:coverageGapsCliTestSupportPath = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot 'CoverageGaps.Cli.TestSupport.ps1')).Path
+$global:cliHelperCoverageSupportFunctionNameList = @(
+    'Assert-TestStructuredCliError'
+)
+. $script:coverageGapsCliTestSupportPath
+
+foreach ($functionName in $global:cliHelperCoverageSupportFunctionNameList) {
+    $scriptBlock = (Get-Command -Name $functionName -CommandType Function -ErrorAction Stop).ScriptBlock
+    Set-Item -Path "function:global:$functionName" -Value $scriptBlock
+}
+
+BeforeAll {
+    $here = Split-Path -Parent $PSCommandPath
+    $script:repoRoot = Split-Path -Parent $here
+    $script:moduleName = (Get-Content -LiteralPath (Join-Path $script:repoRoot 'project.json') -Raw | ConvertFrom-Json).ProjectName
+    $script:distModuleDir = Join-Path $script:repoRoot "dist/$script:moduleName"
+    $coverageGapsCliTestSupportPath = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot 'CoverageGaps.Cli.TestSupport.ps1')).Path
+
+    if (-not (Test-Path -LiteralPath $script:distModuleDir)) {
+        throw "Expected built $script:moduleName module at: $script:distModuleDir. Run Invoke-NovaBuild in the repo root first."
+    }
+
+    . $coverageGapsCliTestSupportPath
+    foreach ($functionName in $global:cliHelperCoverageSupportFunctionNameList) {
+        $scriptBlock = (Get-Command -Name $functionName -CommandType Function -ErrorAction Stop).ScriptBlock
+        Set-Item -Path "function:global:$functionName" -Value $scriptBlock
+    }
+
+    Remove-Module $script:moduleName -ErrorAction SilentlyContinue
+    Import-Module $script:distModuleDir -Force
+}
+
+Describe 'Targeted coverage for smaller CLI helper internals' {
+    It 'CLI help helpers expose the usage text, unsupported usage errors, empty examples, and direct option accumulation' {
+        InModuleScope $script:moduleName {
+            Get-NovaCliHelpUsageText | Should -Be "Use 'nova --help', 'nova -h', 'nova --help <command>', 'nova -h <command>', or 'nova <command> --help'/'nova <command> -h'."
+            Get-NovaCliExampleText -Examples @() | Should -Be '  (none)'
+
+            $options = @{}
+            Add-NovaCliOptionValue -Options $options -Name 'path' -Value '/tmp/one'
+            Add-NovaCliOptionValue -Options $options -Name 'path' -Value '/tmp/two'
+
+            $options.path | Should -Be @('/tmp/one', '/tmp/two')
+
+            $directHelpUsageError = $null
+            try {
+                Assert-NovaCliHelpUsageSupported -Tokens @('--help', 'build')
+            }
+            catch {
+                $directHelpUsageError = $_
+            }
+
+            Assert-TestStructuredCliError -ThrownError $directHelpUsageError -ExpectedError ([pscustomobject]@{
+                Message = "Unsupported help usage. Use 'nova --help', 'nova -h', 'nova --help <command>', 'nova -h <command>', or 'nova <command> --help'/'nova <command> -h'."
+                ErrorId = 'Nova.Validation.UnsupportedCliHelpUsage'
+                Category = [System.Management.Automation.ErrorCategory]::InvalidArgument
+                TargetObject = '--help build'
+            })
+
+            $rootHelpUsageError = $null
+            try {
+                Get-NovaCliHelpRequest -Command '--help' -Arguments @('--help')
+            }
+            catch {
+                $rootHelpUsageError = $_
+            }
+
+            Assert-TestStructuredCliError -ThrownError $rootHelpUsageError -ExpectedError ([pscustomobject]@{
+                Message = "Unsupported help usage. Use 'nova --help', 'nova -h', 'nova --help <command>', 'nova -h <command>', or 'nova <command> --help'/'nova <command> -h'."
+                ErrorId = 'Nova.Validation.UnsupportedCliHelpUsage'
+                Category = [System.Management.Automation.ErrorCategory]::InvalidArgument
+                TargetObject = '--help --help'
+            })
+
+            $subcommandHelpUsageError = $null
+            try {
+                Get-NovaCliHelpRequest -Command 'build' -Arguments @('--help', 'extra')
+            }
+            catch {
+                $subcommandHelpUsageError = $_
+            }
+
+            Assert-TestStructuredCliError -ThrownError $subcommandHelpUsageError -ExpectedError ([pscustomobject]@{
+                Message = "Unsupported help usage. Use 'nova --help', 'nova -h', 'nova --help <command>', 'nova -h <command>', or 'nova <command> --help'/'nova <command> -h'."
+                ErrorId = 'Nova.Validation.UnsupportedCliHelpUsage'
+                Category = [System.Management.Automation.ErrorCategory]::InvalidArgument
+                TargetObject = 'build --help extra'
+            })
+        }
+    }
+
+    It 'Get-NovaCliForwardingParameterSet includes verbose and should-process options directly when requested' {
+        InModuleScope $script:moduleName {
+            $previousWhatIfPreference = $WhatIfPreference
+            try {
+                $WhatIfPreference = $true
+                $result = Get-NovaCliForwardingParameterSet -BoundParameters @{Verbose = $true; Confirm = $false} -IncludeShouldProcess
+
+                $result.Verbose | Should -BeTrue
+                $result.WhatIf | Should -BeTrue
+                $result.Confirm | Should -BeFalse
+            }
+            finally {
+                $WhatIfPreference = $previousWhatIfPreference
+            }
+        }
+    }
+
+    It 'Get-NovaCliInstalledVersion returns the stable version when prerelease metadata is blank or missing' {
+        InModuleScope $script:moduleName {
+            $blankPrereleaseModule = [pscustomobject]@{
+                Version = [version]'2.0.0'
+                PrivateData = [pscustomobject]@{
+                    PSData = [pscustomobject]@{
+                        Prerelease = '   '
+                    }
+                }
+            }
+            $missingPrereleaseModule = [pscustomobject]@{
+                Version = [version]'2.0.1'
+                PrivateData = [pscustomobject]@{
+                    PSData = [pscustomobject]@{}
+                }
+            }
+
+            Get-NovaCliInstalledVersion -Module $blankPrereleaseModule | Should -Be '2.0.0'
+            Get-NovaCliInstalledVersion -Module $missingPrereleaseModule | Should -Be '2.0.1'
+        }
+    }
+}
diff --git a/tests/CoverageGaps.ReleaseInternals.Tests.ps1 b/tests/CoverageGaps.ReleaseInternals.Tests.ps1
@@ -436,6 +436,28 @@ Describe 'Coverage gaps for release and git internals' {
         }
     }
 
+    It 'Get-NovaInstalledProjectManifestPath resolves the default project info when ProjectInfo is omitted' {
+        InModuleScope $script:moduleName {
+            Mock Get-NovaProjectInfo {
+                [pscustomobject]@{ProjectName = 'AzureDevOpsAgentInstaller'; ProjectRoot = '/tmp/project'}
+            }
+            Mock Resolve-NovaLocalPublishPath {'/tmp/default-modules'}
+            Mock Get-NovaPublishedLocalManifestPath {
+                $PublishInvocation.IsLocal | Should -BeTrue
+                $PublishInvocation.Target | Should -Be '/tmp/default-modules'
+                $PublishInvocation.Parameters.ProjectInfo.ProjectName | Should -Be 'AzureDevOpsAgentInstaller'
+                return '/tmp/default-modules/AzureDevOpsAgentInstaller/AzureDevOpsAgentInstaller.psd1'
+            }
+
+            $result = Get-NovaInstalledProjectManifestPath
+
+            $result | Should -Be '/tmp/default-modules/AzureDevOpsAgentInstaller/AzureDevOpsAgentInstaller.psd1'
+            Assert-MockCalled Get-NovaProjectInfo -Times 1
+            Assert-MockCalled Resolve-NovaLocalPublishPath -Times 1
+            Assert-MockCalled Get-NovaPublishedLocalManifestPath -Times 1
+        }
+    }
+
     It 'Get-NovaResolvedPublishParameterMap copies publish parameters and lets workflow values override matching keys' {
         InModuleScope $script:moduleName {
             $publishInvocation = [pscustomobject]@{
diff --git a/tests/CoverageGaps.Tests.ps1 b/tests/CoverageGaps.Tests.ps1
@@ -507,6 +507,28 @@ Describe 'Coverage gaps for scaffold internals' {
         }
     }
 
+    It 'Initialize-NovaModule defaults Path to the current location when Path is omitted' {
+        InModuleScope $script:moduleName {
+            Mock Get-Location {[pscustomobject]@{Path = '/tmp/default-scaffold-root'}}
+            Mock Get-NovaModuleInitializationWorkflowContext {
+                [pscustomobject]@{
+                    Target = '/tmp/default-scaffold-root/NovaDelegation'
+                    Action = 'Create Nova module scaffold'
+                }
+            }
+            Mock Invoke-NovaModuleInitializationWorkflow {}
+
+            Initialize-NovaModule -Confirm:$false
+
+            Assert-MockCalled Get-NovaModuleInitializationWorkflowContext -Times 1 -ParameterFilter {
+                $Path -eq '/tmp/default-scaffold-root' -and -not $Example
+            }
+            Assert-MockCalled Invoke-NovaModuleInitializationWorkflow -Times 1 -ParameterFilter {
+                $WorkflowContext.Target -eq '/tmp/default-scaffold-root/NovaDelegation'
+            }
+        }
+    }
+
     It 'Initialize-NovaModule -Example creates the packaged example scaffold without asking about Pester' {
         InModuleScope $script:moduleName {
             $answer = @{
diff --git a/tests/RemainingHelperCoverage.Tests.ps1 b/tests/RemainingHelperCoverage.Tests.ps1
@@ -207,6 +207,72 @@ Describe 'Coverage for remaining manifest, JSON, and help-locale helpers' {
         }
     }
 
+    It 'Get-NovaModulePsDataValue returns null for null PSData and reads object properties when present' {
+        InModuleScope $script:moduleName {
+            $nullPsDataModule = [pscustomobject]@{
+                PrivateData = [pscustomobject]@{PSData = $null}
+            }
+            $objectPsDataModule = [pscustomobject]@{
+                PrivateData = [pscustomobject]@{
+                    PSData = [pscustomobject]@{
+                        Prerelease = 'preview'
+                    }
+                }
+            }
+
+            Get-NovaModulePsDataValue -Name 'Prerelease' -Module $nullPsDataModule | Should -BeNullOrEmpty
+            Get-NovaModulePsDataValue -Name 'Prerelease' -Module $objectPsDataModule | Should -Be 'preview'
+            Get-NovaModulePsDataValue -Name 'ReleaseNotes' -Module $objectPsDataModule | Should -BeNullOrEmpty
+        }
+    }
+
+    It 'Get-NovaResolvedProjectManifestSettings returns a copy for manifest hashtables and an empty ordered table otherwise' {
+        InModuleScope $script:moduleName {
+            $projectDataWithManifest = @{
+                Manifest = [ordered]@{
+                    Author = 'Nova Author'
+                    Description = 'Manifest description'
+                }
+            }
+            $resolvedManifest = Get-NovaResolvedProjectManifestSettings -ProjectData $projectDataWithManifest
+
+            $resolvedManifest['Author'] | Should -Be 'Nova Author'
+            $resolvedManifest['Description'] | Should -Be 'Manifest description'
+            $resolvedManifest.GetType().Name | Should -Be 'OrderedDictionary'
+
+            $resolvedManifest['Author'] = 'Changed'
+            $projectDataWithManifest.Manifest.Author | Should -Be 'Nova Author'
+
+            (Get-NovaResolvedProjectManifestSettings -ProjectData @{}).Count | Should -Be 0
+            (Get-NovaResolvedProjectManifestSettings -ProjectData @{Manifest = 'invalid'}).Count | Should -Be 0
+        }
+    }
+
+    It 'Get-NovaProjectPackageOutputDirectorySettingsTable returns dictionary copies and wraps scalar paths' {
+        InModuleScope $script:moduleName {
+            $dictionarySettings = [ordered]@{
+                OutputDirectory = [ordered]@{
+                    Path = 'artifacts/packages'
+                    Clean = $true
+                }
+            }
+            $resolvedDictionarySettings = Get-NovaProjectPackageOutputDirectorySettingsTable -PackageSettings $dictionarySettings
+
+            $resolvedDictionarySettings.Path | Should -Be 'artifacts/packages'
+            $resolvedDictionarySettings.Clean | Should -BeTrue
+            $resolvedDictionarySettings.GetType().Name | Should -Be 'OrderedDictionary'
+
+            $resolvedDictionarySettings['Path'] = 'changed'
+            $dictionarySettings.OutputDirectory.Path | Should -Be 'artifacts/packages'
+
+            $resolvedStringSettings = Get-NovaProjectPackageOutputDirectorySettingsTable -PackageSettings @{OutputDirectory = 'dist/packages'}
+            $resolvedStringSettings.Path | Should -Be 'dist/packages'
+
+            $resolvedMissingSettings = Get-NovaProjectPackageOutputDirectorySettingsTable -PackageSettings @{}
+            $resolvedMissingSettings.Path | Should -BeNullOrEmpty
+        }
+    }
+
     It 'Test-ProjectSchema validates the Build schema' {
         InModuleScope $script:moduleName {
             Mock Get-ResourceFilePath {
@@ -385,11 +451,20 @@ Describe 'Coverage for remaining manifest, JSON, and help-locale helpers' {
     It 'Get-NovaPackageAuthorList normalizes string and enumerable author values' {
         InModuleScope $script:moduleName {
             @(Get-NovaPackageAuthorList -AuthorValue $null) | Should -Be @()
+            @(Get-NovaPackageAuthorList -AuthorValue '   ') | Should -Be @()
             @(Get-NovaPackageAuthorList -AuthorValue '  Nova Author  ') | Should -Be @('Nova Author')
             @(Get-NovaPackageAuthorList -AuthorValue @(' Author A ', 'Author B', 'Author A', ' ')) | Should -Be @('Author A', 'Author B')
         }
     }
 
+    It 'Get-NovaManifestValue reads dictionaries, objects, and returns null for missing object properties' {
+        InModuleScope $script:moduleName {
+            Get-NovaManifestValue -Manifest @{Author = 'Dictionary Author'} -Name 'Author' | Should -Be 'Dictionary Author'
+            Get-NovaManifestValue -Manifest ([pscustomobject]@{Author = 'Object Author'}) -Name 'Author' | Should -Be 'Object Author'
+            Get-NovaManifestValue -Manifest ([pscustomobject]@{Author = 'Object Author'}) -Name 'Tags' | Should -BeNullOrEmpty
+        }
+    }
+
     It 'Get-NovaPackageAuthorList rejects unsupported author value types' {
         InModuleScope $script:moduleName {
             $thrown = $null
@@ -575,7 +650,7 @@ Describe 'Coverage for remaining manifest, JSON, and help-locale helpers' {
             Get-NovaPackageArtifactType -PackagePath '/tmp/Nova.Package.nupkg' | Should -Be 'NuGet'
             Get-NovaPackageArtifactType -PackagePath '/tmp/Nova.Package.zip' | Should -Be 'Zip'
 
-            foreach ($packagePath in @('/tmp/Nova.Package', '/tmp/Nova.Package.tar.gz')) {
+            foreach ($packagePath in @('/tmp/package', '/tmp/Nova.Package', '/tmp/Nova.Package.tar.gz')) {
                 $thrown = $null
                 try {
                     Get-NovaPackageArtifactType -PackagePath $packagePath
@@ -590,6 +665,21 @@ Describe 'Coverage for remaining manifest, JSON, and help-locale helpers' {
         }
     }
 
+    It 'New-NovaPackageArtifacts returns an empty list when no package metadata was requested' {
+        InModuleScope $script:moduleName {
+            Mock Assert-NovaPackageMetadata {}
+            Mock Initialize-NovaPackageOutputDirectory {}
+            Mock New-NovaPackageArtifact {}
+
+            $result = @(New-NovaPackageArtifacts -ProjectInfo ([pscustomobject]@{ProjectName = 'NovaModuleTools'}) -PackageMetadataList @())
+
+            $result | Should -Be @()
+            Assert-MockCalled Assert-NovaPackageMetadata -Times 0
+            Assert-MockCalled Initialize-NovaPackageOutputDirectory -Times 0
+            Assert-MockCalled New-NovaPackageArtifact -Times 0
+        }
+    }
+
     It 'Get-NovaPackageOutputDirectory returns rooted paths unchanged and resolves relative paths from the project root' {
         InModuleScope $script:moduleName {
             $relativeProject = [pscustomobject]@{ProjectRoot = '/tmp/project'; Package = [pscustomobject]@{OutputDirectory = [pscustomobject]@{Path = 'artifacts/packages'}}}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function Get-NovaCliRootHelpRequest {`
`44`	`44`	`return Get-NovaCliResolvedHelpRequest -Command $Arguments[0] -View Long -TargetType Command`
`45`	`45`	`}`
`46`	`46`
`47`		`- Assert-NovaCliHelpUsageSupported -Tokens @('--help') + $Arguments`
	`47`	`+ Assert-NovaCliHelpUsageSupported -Tokens (@('--help') + $Arguments)`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`function Get-NovaCliSubcommandHelpRequest {`
`@@ -63,7 +63,7 @@ function Get-NovaCliSubcommandHelpRequest {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if (@($Arguments \| Where-Object {Test-NovaCliHelpToken -Argument $_}).Count -gt 0) {`
`66`		`- Assert-NovaCliHelpUsageSupported -Tokens @($Command) + $Arguments`
	`66`	`+ Assert-NovaCliHelpUsageSupported -Tokens (@($Command) + $Arguments)`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`return $null`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ function New-NovaPackageArtifacts {`
`4`	`4`	`[CmdletBinding()]`
`5`	`5`	`param(`
`6`	`6`	`[Parameter(Mandatory)][pscustomobject]$ProjectInfo,`
`7`		`- [Parameter(Mandatory)][object[]]$PackageMetadataList`
	`7`	`+ [Parameter(Mandatory)][AllowEmptyCollection()][object[]]$PackageMetadataList`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`$resolvedPackageMetadataList = @($PackageMetadataList)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ function Get-NovaResolvedProjectManifestSettings {`
`5`	`5`	`[Parameter(Mandatory)][hashtable]$ProjectData`
`6`	`6`	`)`
`7`	`7`
`8`		`- if ($ProjectData.ContainsKey('Manifest') -and $ProjectData['Manifest'] -is [hashtable]) {`
	`8`	`+ if ($ProjectData.ContainsKey('Manifest') -and $ProjectData['Manifest'] -is [System.Collections.IDictionary]) {`
`9`	`9`	`return [ordered]@{} + $ProjectData['Manifest']`
`10`	`10`	`}`
`11`	`11`