feat(#205): mirror package helper tests

 Add focused, dot-source-first Pester tests under tests/private/package/
 for unit-level package helpers (metadata, content, NuGet/Zip artifacts,
 upload option/target/headers/auth, file resolution, request, and per-type
 upload helpers). Multi-step package workflow orchestrators stay covered
 by the existing cross-cutting package tests.

 closes Migrate package domain tests (6)
 Fixes #205

Author: stiwicourage

CHANGELOG.md

@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - Added mirrored, dot-source-first Pester test files for build and shared private helpers (`src/private/build/*.ps1`, `src/private/build/manifest/*.ps1`, and `src/private/shared/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/build/`, `tests/private/build/manifest/`, or `tests/private/shared/` instead of being covered only through broad legacy coverage files.
 - Added mirrored, dot-source-first Pester test files for CLI private helpers (`src/private/cli/*.ps1`), so most CLI argument parsers, prompt helpers, and per-command CLI wrappers now have a focused test file under `tests/private/cli/`. Large cross-cutting CLI orchestrators (`InvokeNovaCliCommandRoute.ps1`, `GetNovaCliArgumentRoutingState.ps1`, `FormatNovaCliCommandHelp.ps1`, `ConfirmNovaCliAction.ps1`, `GetNovaCliInvocationContext.ps1`) stay covered by the existing cross-cutting CLI tests.
 - Added mirrored, dot-source-first Pester test files for release private helpers (`src/private/release/*.ps1`), so most release, publish, and version-update helpers (local publish path resolution, publish parameter mapping, version label inference, version part calculation, prerelease label handling, release request shaping, and per-step write/import helpers) now have a focused test file under `tests/private/release/`. Multi-step release/publish/version-update workflow orchestrators (`InvokeNovaReleaseWorkflow.ps1`, `InvokeNovaPublishWorkflow.ps1`, `GetNovaVersionUpdateWorkflowContext.ps1`) stay covered by the existing cross-cutting release tests.
+- Added mirrored, dot-source-first Pester test files for package private helpers (`src/private/package/*.ps1`), so most package metadata, archive-content, NuGet/Zip artifact, upload option, upload target, upload header/auth, upload file-resolution, upload request, and per-type upload helpers now have a focused test file under `tests/private/package/`. Multi-step package workflow orchestrators (`InvokeNovaPackageWorkflow.ps1`, `InvokeNovaPackageUploadWorkflow.ps1`, `GetNovaPackageWorkflowContext.ps1`, `GetNovaPackageUploadWorkflowContext.ps1`, `InvokeNovaPackageArtifactCreation.ps1`, `NewNovaPackageArtifacts.ps1`) stay covered by the existing cross-cutting package tests.
 
 
 ### Changed

tests/private/package/AddNovaZipFileEntry.Tests.ps1

@@ -0,0 +1,31 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/AddNovaZipFileEntry.ps1')
+}
+
+Describe 'Add-NovaZipFileEntry' {
+    It 'copies file content into the zip entry path' {
+        $zipPath = Join-Path ([System.IO.Path]::GetTempPath()) ("nova-{0}.zip" -f [guid]::NewGuid())
+        $sourcePath = Join-Path ([System.IO.Path]::GetTempPath()) ("nova-{0}.txt" -f [guid]::NewGuid())
+        Set-Content -LiteralPath $sourcePath -Value 'hello' -NoNewline
+        try {
+            $fs = [System.IO.File]::Open($zipPath, [System.IO.FileMode]::CreateNew)
+            $archive = [System.IO.Compression.ZipArchive]::new($fs, [System.IO.Compression.ZipArchiveMode]::Create, $false)
+            try {
+                Add-NovaZipFileEntry -Archive $archive -EntryPath 'a/b.txt' -SourcePath $sourcePath
+            } finally {
+                $archive.Dispose(); $fs.Dispose()
+            }
+            $archive2 = [System.IO.Compression.ZipFile]::OpenRead($zipPath)
+            try {
+                $entry = $archive2.GetEntry('a/b.txt')
+                $entry | Should -Not -BeNullOrEmpty
+                $reader = [System.IO.StreamReader]::new($entry.Open())
+                try {$reader.ReadToEnd() | Should -Be 'hello'} finally {$reader.Dispose()}
+            } finally {$archive2.Dispose()}
+        } finally {
+            Remove-Item -LiteralPath $zipPath -ErrorAction SilentlyContinue
+            Remove-Item -LiteralPath $sourcePath -ErrorAction SilentlyContinue
+        }
+    }
+}

tests/private/package/AddNovaZipTextEntry.Tests.ps1

@@ -0,0 +1,20 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/AddNovaZipTextEntry.ps1')
+}
+
+Describe 'Add-NovaZipTextEntry' {
+    It 'writes UTF-8 text without BOM into the zip entry' {
+        $zipPath = Join-Path ([System.IO.Path]::GetTempPath()) ("nova-{0}.zip" -f [guid]::NewGuid())
+        try {
+            $fs = [System.IO.File]::Open($zipPath, [System.IO.FileMode]::CreateNew)
+            $archive = [System.IO.Compression.ZipArchive]::new($fs, [System.IO.Compression.ZipArchiveMode]::Create, $false)
+            try {Add-NovaZipTextEntry -Archive $archive -EntryPath 'note.txt' -Content 'hello'} finally {$archive.Dispose(); $fs.Dispose()}
+            $archive2 = [System.IO.Compression.ZipFile]::OpenRead($zipPath)
+            try {
+                $reader = [System.IO.StreamReader]::new($archive2.GetEntry('note.txt').Open())
+                try {$reader.ReadToEnd() | Should -Be 'hello'} finally {$reader.Dispose()}
+            } finally {$archive2.Dispose()}
+        } finally {Remove-Item -LiteralPath $zipPath -ErrorAction SilentlyContinue}
+    }
+}

tests/private/package/AssertNovaPackageMetadata.Tests.ps1

@@ -0,0 +1,23 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/AssertNovaPackageMetadata.ps1')
+
+    function Stop-NovaOperation {param($Message, $ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Assert-NovaPackageMetadata' {
+    It 'returns silently when all required fields are present' {
+        $meta = [pscustomobject]@{Type='NuGet'; Id='X'; Version='1.0.0'; Description='d'; OutputDirectory='/o'; PackageFileName='X.nupkg'; PackagePath='/o/X.nupkg'; Authors=@('a')}
+        {Assert-NovaPackageMetadata -PackageMetadata $meta} | Should -Not -Throw
+    }
+
+    It 'throws when a required field is missing' {
+        $meta = [pscustomobject]@{Type='NuGet'; Id=''; Version='1.0.0'; Description='d'; OutputDirectory='/o'; PackageFileName='X.nupkg'; PackagePath='/o/X.nupkg'; Authors=@('a')}
+        {Assert-NovaPackageMetadata -PackageMetadata $meta} | Should -Throw '*Id*'
+    }
+
+    It 'throws when Authors is empty' {
+        $meta = [pscustomobject]@{Type='NuGet'; Id='X'; Version='1.0.0'; Description='d'; OutputDirectory='/o'; PackageFileName='X.nupkg'; PackagePath='/o/X.nupkg'; Authors=@()}
+        {Assert-NovaPackageMetadata -PackageMetadata $meta} | Should -Throw '*Authors*'
+    }
+}

tests/private/package/AssertNovaPackageOutputDirectoryCanBeCleared.Tests.ps1

@@ -0,0 +1,27 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/AssertNovaPackageOutputDirectoryCanBeCleared.ps1')
+
+    function Stop-NovaOperation {param($Message, $ErrorId, $Category, $TargetObject) throw $Message}
+    function Test-NovaPathContainsPath {param($ParentPath, $ChildPath) return $false}
+}
+
+Describe 'Assert-NovaPackageOutputDirectoryCanBeCleared' {
+    It 'returns silently for a normal directory that is not a parent of protected paths' {
+        $project = [pscustomobject]@{ProjectRoot='/proj'; OutputModuleDir='/proj/dist'}
+        {Assert-NovaPackageOutputDirectoryCanBeCleared -ProjectInfo $project -OutputDirectory ([System.IO.Path]::GetTempPath())} | Should -Not -Throw
+    }
+
+    It 'throws when output directory contains a protected path' {
+        Mock Test-NovaPathContainsPath {return $true}
+        $project = [pscustomobject]@{ProjectRoot='/proj'; OutputModuleDir='/proj/dist'}
+        {Assert-NovaPackageOutputDirectoryCanBeCleared -ProjectInfo $project -OutputDirectory ([System.IO.Path]::GetTempPath())} | Should -Throw '*required project content*'
+    }
+
+    It 'throws when the resolved output directory is a filesystem root' {
+        $root = [System.IO.Path]::GetPathRoot([System.IO.Path]::GetFullPath([System.IO.Path]::GetTempPath()))
+        if (-not $root) {Set-ItResult -Skipped -Because 'No root path available on this platform'}
+        $project = [pscustomobject]@{ProjectRoot='/proj'; OutputModuleDir='/proj/dist'}
+        {Assert-NovaPackageOutputDirectoryCanBeCleared -ProjectInfo $project -OutputDirectory $root} | Should -Throw '*root*'
+    }
+}

tests/private/package/ClearNovaPackageOutputDirectory.Tests.ps1

@@ -0,0 +1,23 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/ClearNovaPackageOutputDirectory.ps1')
+
+    function Assert-NovaPackageOutputDirectoryCanBeCleared {param($ProjectInfo, $OutputDirectory)}
+}
+
+Describe 'Clear-NovaPackageOutputDirectory' {
+    It 'removes the existing output directory' {
+        $dir = Join-Path ([System.IO.Path]::GetTempPath()) ([guid]::NewGuid())
+        New-Item -ItemType Directory -Path $dir | Out-Null
+        Set-Content -LiteralPath (Join-Path $dir 'a.txt') -Value 'x'
+        try {
+            Clear-NovaPackageOutputDirectory -ProjectInfo ([pscustomobject]@{}) -OutputDirectory $dir
+            Test-Path -LiteralPath $dir | Should -BeFalse
+        } finally {Remove-Item -LiteralPath $dir -Recurse -Force -ErrorAction SilentlyContinue}
+    }
+
+    It 'returns silently when the directory does not exist' {
+        $dir = Join-Path ([System.IO.Path]::GetTempPath()) ([guid]::NewGuid())
+        {Clear-NovaPackageOutputDirectory -ProjectInfo ([pscustomobject]@{}) -OutputDirectory $dir} | Should -Not -Throw
+    }
+}

tests/private/package/GetNovaManifestValue.Tests.ps1

@@ -0,0 +1,18 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/GetNovaManifestValue.ps1')
+}
+
+Describe 'Get-NovaManifestValue' {
+    It 'returns dictionary entry by key' {
+        Get-NovaManifestValue -Manifest @{Tags='a'} -Name 'Tags' | Should -Be 'a'
+    }
+
+    It 'returns object property by name' {
+        Get-NovaManifestValue -Manifest ([pscustomobject]@{Tags='b'}) -Name 'Tags' | Should -Be 'b'
+    }
+
+    It 'returns $null when the property is missing on an object' {
+        Get-NovaManifestValue -Manifest ([pscustomobject]@{Other='x'}) -Name 'Tags' | Should -BeNullOrEmpty
+    }
+}

tests/private/package/GetNovaPackageArtifactPatternInfo.Tests.ps1

@@ -0,0 +1,23 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/GetNovaPackageArtifactPatternInfo.ps1')
+
+    function Get-NovaPackageSettingValue {param($InputObject, $Name) return $InputObject.$Name}
+    function ConvertTo-NovaPackageType {param($Type) if ($Type -match 'zip') {'Zip'} else {'NuGet'}}
+}
+
+Describe 'Get-NovaPackageArtifactPatternInfo' {
+    It 'derives pattern from PackageId when FileNamePattern is empty' {
+        $project = [pscustomobject]@{Package=[pscustomobject]@{FileNamePattern=''; Id='X'}}
+        $info = Get-NovaPackageArtifactPatternInfo -ProjectInfo $project
+        $info.Pattern | Should -Be 'X*'
+        $info.ExplicitPackageType | Should -BeNullOrEmpty
+    }
+
+    It 'returns the explicit package type when the pattern ends with a known extension' {
+        $project = [pscustomobject]@{Package=[pscustomobject]@{FileNamePattern='X*.zip'; Id='X'}}
+        $info = Get-NovaPackageArtifactPatternInfo -ProjectInfo $project
+        $info.Pattern | Should -Be 'X*.zip'
+        $info.ExplicitPackageType | Should -Be 'Zip'
+    }
+}

tests/private/package/GetNovaPackageArtifactSearchPattern.Tests.ps1

@@ -0,0 +1,18 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/GetNovaPackageArtifactSearchPattern.ps1')
+
+    function Get-NovaPackageArtifactPatternInfo {param($ProjectInfo) return [pscustomobject]@{Pattern='X*'; ExplicitPackageType=$null}}
+    function Get-NovaPackageTypeExtension {param($PackageType) return '.nupkg'}
+}
+
+Describe 'Get-NovaPackageArtifactSearchPattern' {
+    It 'returns the explicit pattern unchanged when ExplicitPackageType is set' {
+        Mock Get-NovaPackageArtifactPatternInfo {return [pscustomobject]@{Pattern='X*.zip'; ExplicitPackageType='Zip'}}
+        Get-NovaPackageArtifactSearchPattern -ProjectInfo ([pscustomobject]@{}) -PackageType 'Zip' | Should -Be 'X*.zip'
+    }
+
+    It 'appends the type extension when no explicit type is configured' {
+        Get-NovaPackageArtifactSearchPattern -ProjectInfo ([pscustomobject]@{}) -PackageType 'NuGet' | Should -Be 'X*.nupkg'
+    }
+}

tests/private/package/GetNovaPackageArtifactType.Tests.ps1

@@ -0,0 +1,27 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/package/GetNovaPackageArtifactType.ps1')
+
+    function Stop-NovaOperation {param($Message, $ErrorId, $Category, $TargetObject) throw $Message}
+    function ConvertTo-NovaPackageType {param($Type)
+        switch -Regex ($Type) {'\.zip$' {'Zip'; break} '\.nupkg$' {'NuGet'; break} default {throw "bad: $Type"}}
+    }
+}
+
+Describe 'Get-NovaPackageArtifactType' {
+    It 'returns NuGet for .nupkg' {
+        Get-NovaPackageArtifactType -PackagePath '/o/x.nupkg' | Should -Be 'NuGet'
+    }
+
+    It 'returns Zip for .zip' {
+        Get-NovaPackageArtifactType -PackagePath '/o/x.zip' | Should -Be 'Zip'
+    }
+
+    It 'throws when extension is unknown' {
+        {Get-NovaPackageArtifactType -PackagePath '/o/x.tar'} | Should -Throw '*Unsupported package file extension*'
+    }
+
+    It 'throws when no extension is present' {
+        {Get-NovaPackageArtifactType -PackagePath '/o/x'} | Should -Throw '*Unsupported package file extension*'
+    }
+}