Skip to content

Commit 4a996ef

Browse files
authored
Fix deployment help links and coverage gaps (#232)
* fix(#215): restore deploy help related links * fix(#215): close raw upload coverage gaps * #215 fix: nomalize command help related links
1 parent 7fb5186 commit 4a996ef

19 files changed

Lines changed: 108 additions & 37 deletions

.github/instructions/platyps-help.instructions.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ Import-MarkdownCommandHelp -Path ./docs/NovaModuleTools/en-US/<CommandName>.md |
6666
- The `external help file` field must always use the module name, not the command name: `NovaModuleTools-Help.xml`. The `Module Name` field must match the project name. When both fields use the module name, Nova build produces a single `<ModuleName>-Help.xml` under `dist/<ModuleName>/en-US/`. If either field contains a command name instead, the build produces per-command XML files and the module manifest cannot find its help.
6767
- Keep the H1 title equal to the exact command name.
6868
- Preserve the standard PlatyPS section order with uppercase H2 headers: `SYNOPSIS`, `SYNTAX`, optional `ALIASES`, `DESCRIPTION`, `EXAMPLES`, `PARAMETERS`, `INPUTS`, `OUTPUTS`, `NOTES`, and `RELATED LINKS`.
69+
- In `## RELATED LINKS`, use only a bulleted list of Markdown links. Do not use bare URLs or backticked command names as list items.
70+
- Prefer relative links to sibling command-help files when the related topic has a matching file in `docs/NovaModuleTools/en-US/`, for example `[Invoke-NovaBuild](./Invoke-NovaBuild.md)`.
71+
- Do not use GitHub blob URLs in shipped command help. If a relative command-help link is not suitable after PlatyPS validation, use the related topic's `novamoduletools.com` `HelpUri` instead.
6972
- Keep at least one example under `## EXAMPLES`.
7073
- Keep parameter sections as `### -ParameterName` blocks with the PlatyPS-generated YAML metadata code block.
7174
- Only hand-edit parameter metadata when PlatyPS cannot infer it correctly, especially `DefaultValue` and `SupportsWildcards`.
@@ -82,6 +85,7 @@ Import-MarkdownCommandHelp -Path ./docs/NovaModuleTools/en-US/<CommandName>.md |
8285
- Use `Update-MarkdownCommandHelp` after command or parameter changes so syntax, aliases, and parameter metadata stay synchronized with the implementation.
8386
- Use `Test-MarkdownCommandHelp` as the quick structural gate before handoff; use `Import-MarkdownCommandHelp` diagnostics when you need more detail.
8487
- Use existing valid files under `docs/NovaModuleTools/en-US/` as the structural template before inventing a new layout.
88+
- Validate any new `RELATED LINKS` target style through the real PlatyPS import/export path before applying it repo-wide.
8589
- Keep command help separate from contributor docs and project/site docs.
8690

8791
## Review expectations
@@ -90,4 +94,5 @@ Import-MarkdownCommandHelp -Path ./docs/NovaModuleTools/en-US/<CommandName>.md |
9094
- Reviewers should flag help files where `external help file` contains a command name (e.g., `Get-Something-Help.xml`) instead of the module name (`NovaModuleTools-Help.xml`). This produces per-command XML files that the module manifest cannot locate at runtime.
9195
- Reviewers should flag help files that would fail `Test-MarkdownCommandHelp` or produce diagnostics/errors when imported with `Import-MarkdownCommandHelp`.
9296
- Reviewers should flag any new public entry point that does not add its matching command-help file in the same change.
97+
- Reviewers should flag `RELATED LINKS` entries that use GitHub blob URLs, plain URLs, or bare/backticked command names instead of Markdown links.
9398
- Treat build errors from `Import-MarkdownCommandHelp` as a sign that the file is not valid PlatyPS help yet.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
2626
### Fixed
2727

2828
- `Test-NovaBuild` now expands configured Pester coverage globs into concrete source files before invoking Pester, so nested helpers remain measurable in `artifacts/coverage.xml` while repository and scaffolded `project.json` defaults can stay on the simpler `src/private/**/*.ps1` entry.
29+
- PowerShell command help `RELATED LINKS` now use valid PlatyPS Markdown links and point to shipped help topics instead of GitHub blob pages.
2930

3031
### Security
3132

RELEASE_NOTE.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ This file summarizes the release notes for NovaModuleTools. **UNRELEASED** chang
2121

2222
### Fixed
2323

24+
- PowerShell command help `RELATED LINKS` now use valid help-topic links instead of GitHub blob pages.
25+
2426
### Security
2527

2628
## [3.0.1] - 2026-05-18

docs/NovaModuleTools/en-US/Deploy-NovaPackage.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,5 +382,5 @@ If no upload target can be resolved, `Deploy-NovaPackage` fails fast with a clea
382382

383383
## RELATED LINKS
384384

385-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/New-NovaModulePackage.md
386-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Publish-NovaModule.md
385+
- [New-NovaModulePackage](./New-NovaModulePackage.md)
386+
- [Publish-NovaModule](./Publish-NovaModule.md)

docs/NovaModuleTools/en-US/Get-NovaProjectInfo.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,6 @@ This command throws a clear error when `project.json` is missing or empty.
189189

190190
## RELATED LINKS
191191

192-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Invoke-NovaBuild.md
193-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Test-NovaBuild.md
194-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Update-NovaModuleVersion.md
192+
- [Invoke-NovaBuild](./Invoke-NovaBuild.md)
193+
- [Test-NovaBuild](./Test-NovaBuild.md)
194+
- [Update-NovaModuleVersion](./Update-NovaModuleVersion.md)

docs/NovaModuleTools/en-US/Get-NovaUpdateNotificationPreference.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,6 @@ When prerelease notifications are enabled again, `Update-NovaModuleTool` / `Upda
8181

8282
## RELATED LINKS
8383

84-
- `Invoke-NovaBuild`
85-
- `Set-NovaUpdateNotificationPreference`
86-
- `Update-NovaModuleTool`
84+
- [Invoke-NovaBuild](./Invoke-NovaBuild.md)
85+
- [Set-NovaUpdateNotificationPreference](./Set-NovaUpdateNotificationPreference.md)
86+
- [Update-NovaModuleTool](./Update-NovaModuleTools.md)

docs/NovaModuleTools/en-US/Initialize-NovaModule.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,5 +152,5 @@ Generated projects start with NovaModuleTools defaults for recursive discovery,
152152

153153
## RELATED LINKS
154154

155-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Invoke-NovaBuild.md
156-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Get-NovaProjectInfo.md
155+
- [Invoke-NovaBuild](./Invoke-NovaBuild.md)
156+
- [Get-NovaProjectInfo](./Get-NovaProjectInfo.md)

docs/NovaModuleTools/en-US/Install-NovaCli.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,4 +172,4 @@ After running `Install-NovaCli`, add the destination directory to your shell `PA
172172

173173
## RELATED LINKS
174174

175-
- `Publish-NovaModule`
175+
- [Publish-NovaModule](./Publish-NovaModule.md)

docs/NovaModuleTools/en-US/Invoke-NovaAgenticCopilotScaffold.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,5 +203,5 @@ This workflow does not persist `ShortName` to `project.json` and does not infer
203203

204204
## RELATED LINKS
205205

206-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Initialize-NovaModule.md
207-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Get-NovaProjectInfo.md
206+
- [Initialize-NovaModule](./Initialize-NovaModule.md)
207+
- [Get-NovaProjectInfo](./Get-NovaProjectInfo.md)

docs/NovaModuleTools/en-US/Invoke-NovaBuild.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ Files under `src/public` are expected to contain exactly one top-level function
174174

175175
## RELATED LINKS
176176

177-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Get-NovaProjectInfo.md
178-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Test-NovaBuild.md
179-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Publish-NovaModule.md
180-
- https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Update-NovaModuleTools.md
177+
- [Get-NovaProjectInfo](./Get-NovaProjectInfo.md)
178+
- [Test-NovaBuild](./Test-NovaBuild.md)
179+
- [Publish-NovaModule](./Publish-NovaModule.md)
180+
- [Update-NovaModuleTool](./Update-NovaModuleTools.md)

0 commit comments

Comments
 (0)