Skip to content

Commit 4d50c4a

Browse files
committed
feat(#207): retire legacy coverage-bucket test files
Move the pre-migration broad coverage-bucket suites (CoverageGaps*, CoverageCompletion*, Remaining*Coverage*, broad NovaCommandModel*) and their legacy-only support sidecars to tests/_legacy/ and rename the .Tests.ps1 suffix to .LegacyReference.ps1 so Pester discovery no longer runs them. The mirrored tests/public/ and tests/private/<domain>/ suites added in #200#206 now own that coverage. The retired files stay readable as a reference until coverage measurement is re-enabled and confirms no regression. Active tests that still consume RemainingHelperCoverage.TestSupport.ps1 and CoverageGaps.Cli.TestSupport.ps1 keep their existing support files in place.
1 parent 6c368b5 commit 4d50c4a

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
3131

3232

3333
### Changed
34+
- Retired the pre-migration broad coverage-bucket suites (`CoverageGaps*`, `CoverageCompletion*`, `Remaining*Coverage*`, broad `NovaCommandModel*`) by moving them to `tests/_legacy/` and renaming the `.Tests.ps1` suffix to `.LegacyReference.ps1` so Pester discovery no longer runs them. The mirrored `tests/public/` and `tests/private/<domain>/` suites added in #200#206 now own that coverage; the retired files stay readable as a reference until coverage measurement is re-enabled and confirms no regression. Active tests that still consume `RemainingHelperCoverage.TestSupport.ps1` (`PackageLatestPolicy.Tests.ps1`) and `CoverageGaps.Cli.TestSupport.ps1` (`CliHelperCoverage.Tests.ps1`, `CliSharedParser.Tests.ps1`) keep their existing support files in place.
3435
- Test-loading guidance for NovaModuleTools' own tests and for generated Agentic Copilot scaffolds now follows a source-mirrored, dot-source-first pattern: new mirrored tests dot-source the relevant `src/**/*.ps1` files directly in `BeforeAll` instead of importing the built `dist` module or wrapping assertions in `InModuleScope`, so tests run against source files and JaCoCo coverage references real source paths.
3536
- `project.json` `Pester.CodeCoverage.Enabled` is temporarily `false` while the existing test suite migrates to the new dot-source pattern; the configured `90` percent target stays in place and is re-enabled once migration completes.
3637
- The architect/design flow now surfaces settled vs unresolved design items before finalization, offers explicit choices for full finalization vs design-package-only handoff, clarifies how to use design notes versus the paste-ready GitHub issue draft, and requires finalization output to follow the project Markdown authoring guidance.

tests/_legacy/README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# `tests/_legacy/` — retired coverage-bucket suites
2+
3+
These files were the broad pre-migration coverage buckets (`CoverageGaps*`,
4+
`CoverageCompletion*`, `Remaining*Coverage*`, broad `NovaCommandModel*`)
5+
that existed before each `src/**/*.ps1` helper got its own mirrored test
6+
file under `tests/public/` and `tests/private/<domain>/`.
7+
8+
After the source-mirrored test migration (issues #200#206), their
9+
assertions are covered by the mirrored tests. They are kept here, with
10+
the `.Tests.ps1` suffix renamed to `.LegacyReference.ps1`, so:
11+
12+
- Pester discovery (which only picks up `*.Tests.ps1`) skips them and they
13+
no longer run as part of `Test-NovaBuild` or the repository quality
14+
loop.
15+
- If a behavior is later found to be missing from the mirrored suites,
16+
the original assertion is still readable here as a reference and can
17+
be ported to the right mirrored or cross-cutting test home.
18+
19+
These files are not maintained. They will be deleted once coverage
20+
measurement is re-enabled and confirms no regression against the
21+
mirrored test layout.

0 commit comments

Comments
 (0)