feat(#208): enhance CodeScene analysis and coverage reporting

- skip branch-coverage upload if no BRANCH counters are present in JaCoCo report
- update tests to validate branch-coverage upload behavior

Author: stiwicourage

CHANGELOG.md

@@ -54,6 +54,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - `Test-NovaBuild` and `% nova test` no longer emit `Remove-Item -Recurse` progress bars during the Pester run; `$global:ProgressPreference` is saved and restored around the test execution so CI logs stay clean.
 - Code coverage in `Test-NovaBuild` now runs against the source files, instead of the built `dist/<ModuleName>/<ModuleName>.psm1` file so measured coverage percentages and line numbers align with the deployed module.
 - `Invoke-CodeSceneAnalysis.ps1` now normalizes Pester's JaCoCo output before upload so the `<class sourcefilename>` and `<sourcefile name>` entries are bare filenames and `package + sourcefile` resolves to real repository paths. This fixes the CodeScene `cs-coverage upload` failure "The coverage data does not contains any records related to the current repo" that appeared after the source-mirrored coverage migration.
+- `Invoke-CodeSceneAnalysis.ps1` now only invokes the `cs-coverage upload … --metric branch-coverage` step when the JaCoCo report actually contains `<counter type="BRANCH">` entries, so Pester reports that only emit line counters no longer fail the CodeScene step with "Requested metric is not present in coverage data".
 
 
 ### Security

scripts/build/ci/Invoke-CodeSceneAnalysis.ps1

@@ -133,6 +133,13 @@ function Repair-PesterJaCoCoCoveragePath {
     }
 }
 
+function Test-JaCoCoBranchCoverageAvailable {
+    param([Parameter(Mandatory)][string]$Path)
+
+    [xml]$document = Get-Content -LiteralPath $Path -Raw
+    return $null -ne $document.SelectSingleNode('//counter[@type="BRANCH"]')
+}
+
 $shouldUploadCoverage = Test-CodeSceneCoverageUploadRequested -CoveragePath $CoveragePath -UploadCoverage:$UploadCoverage
 $shouldRunAnalysis = $TriggerAnalysis.IsPresent
 
@@ -158,9 +165,14 @@ if ($shouldUploadCoverage) {
         throw "CodeScene line-coverage upload failed with exit code $LASTEXITCODE."
     }
 
-    & cs-coverage upload --format 'jacoco' --metric 'branch-coverage' $resolvedCoveragePath
-    if ($LASTEXITCODE -ne 0) {
-        throw "CodeScene branch-coverage upload failed with exit code $LASTEXITCODE."
+    if (Test-JaCoCoBranchCoverageAvailable -Path $resolvedCoveragePath) {
+        & cs-coverage upload --format 'jacoco' --metric 'branch-coverage' $resolvedCoveragePath
+        if ($LASTEXITCODE -ne 0) {
+            throw "CodeScene branch-coverage upload failed with exit code $LASTEXITCODE."
+        }
+    }
+    else {
+        Write-Host "Skipping branch-coverage upload: '$resolvedCoveragePath' does not contain <counter type=`"BRANCH`"> entries."
     }
 }
 

tests/CodeSceneAnalysis.Tests.ps1

@@ -84,7 +84,7 @@ function Invoke-WebRequest {
     It 'still uploads coverage when CoveragePath is provided' {
         $coveragePath = Join-Path $TestDrive 'coverage.xml'
         $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload.txt'
-        Set-Content -LiteralPath $coveragePath -Value '<report />' -Encoding utf8
+        Set-Content -LiteralPath $coveragePath -Value '<report><counter type="BRANCH" missed="1" covered="1" /></report>' -Encoding utf8
 
         $runnerContent = @"
 function cs-coverage {
@@ -114,7 +114,7 @@ function cs-coverage {
         $coveragePath = Join-Path $artifactsDir 'coverage.xml'
         $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload-discovered.txt'
         New-Item -ItemType Directory -Path $artifactsDir -Force | Out-Null
-        Set-Content -LiteralPath $coveragePath -Value '<report />' -Encoding utf8
+        Set-Content -LiteralPath $coveragePath -Value '<report><counter type="BRANCH" missed="1" covered="1" /></report>' -Encoding utf8
 
         $runnerContent = @"
 function cs-coverage {
@@ -200,4 +200,33 @@ function cs-coverage {
         $sourcefile = $rewritten.SelectSingleNode('//sourcefile[@name]')
         $sourcefile.GetAttribute('name') | Should -Be 'Foo.ps1'
     }
+
+    It 'skips branch-coverage upload when the JaCoCo report has no BRANCH counters' {
+        $coveragePath = Join-Path $TestDrive 'coverage-no-branch.xml'
+        $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload-no-branch.txt'
+        Set-Content -LiteralPath $coveragePath -Value '<report><counter type="LINE" missed="0" covered="1" /></report>' -Encoding utf8
+
+        $runnerContent = @"
+function cs-coverage {
+    param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
+
+    Add-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
+    `$global:LASTEXITCODE = 0
+}
+
+[Environment]::SetEnvironmentVariable('CS_URL', 'https://codescene.example.test')
+[Environment]::SetEnvironmentVariable('CS_PROJECT_ID', '123')
+[Environment]::SetEnvironmentVariable('CS_ACCESS_TOKEN', 'token')
+
+& '$codeSceneAnalysisScriptPath' -CoveragePath '$coveragePath'
+"@
+
+        $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
+
+        $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)
+        $uploadLog = Get-Content -LiteralPath $uploadLogPath -Raw
+        $uploadLog | Should -Match 'upload --format jacoco --metric line-coverage'
+        $uploadLog | Should -Not -Match 'branch-coverage'
+        ($result.Output -join [Environment]::NewLine) | Should -Match 'Skipping branch-coverage upload'
+    }
 }