feat(#203): mirror CLI helper tests

Closes Migrate CLI domain tests (4)
Fixes #203

Author: stiwicourage

CHANGELOG.md

@@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - Added a non-blocking `scripts/build/Get-TestMirrorStatus.ps1` helper that reports `src/**/*.ps1` files without a matching mirrored test file under `tests/`, to support the migration to the source-mirrored, dot-source-first test layout.
 - Added mirrored, dot-source-first Pester test files for scaffold and update private helpers (`src/private/scaffold/*.ps1` and `src/private/update/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/scaffold/` or `tests/private/update/` instead of being covered only through broad legacy coverage files.
 - Added mirrored, dot-source-first Pester test files for build and shared private helpers (`src/private/build/*.ps1`, `src/private/build/manifest/*.ps1`, and `src/private/shared/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/build/`, `tests/private/build/manifest/`, or `tests/private/shared/` instead of being covered only through broad legacy coverage files.
+- Added mirrored, dot-source-first Pester test files for CLI private helpers (`src/private/cli/*.ps1`), so most CLI argument parsers, prompt helpers, and per-command CLI wrappers now have a focused test file under `tests/private/cli/`. Large cross-cutting CLI orchestrators (`InvokeNovaCliCommandRoute.ps1`, `GetNovaCliArgumentRoutingState.ps1`, `FormatNovaCliCommandHelp.ps1`, `ConfirmNovaCliAction.ps1`, `GetNovaCliInvocationContext.ps1`) stay covered by the existing cross-cutting CLI tests.
 
 
 ### Changed

tests/private/cli/AddNovaCliHeaderOption.Tests.ps1

@@ -0,0 +1,28 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/AddNovaCliHeaderOption.ps1')
+
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Add-NovaCliHeaderOption' {
+    It 'parses Name=Value into the Headers map' {
+        $options = @{}
+        Add-NovaCliHeaderOption -Options $options -HeaderArgument 'X-Trace=abc'
+        $options.Headers['X-Trace'] | Should -Be 'abc'
+    }
+
+    It 'preserves values that contain "=" after the first separator' {
+        $options = @{}
+        Add-NovaCliHeaderOption -Options $options -HeaderArgument 'X-Token=a=b=c'
+        $options.Headers['X-Token'] | Should -Be 'a=b=c'
+    }
+
+    It 'rejects header arguments without a name part' {
+        {Add-NovaCliHeaderOption -Options @{} -HeaderArgument '=value'} | Should -Throw '*Invalid header argument*'
+    }
+
+    It 'rejects header arguments without a separator' {
+        {Add-NovaCliHeaderOption -Options @{} -HeaderArgument 'noseparator'} | Should -Throw '*Invalid header argument*'
+    }
+}

tests/private/cli/AddNovaCliOptionValue.Tests.ps1

@@ -0,0 +1,21 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/AddNovaCliOptionValue.ps1')
+}
+
+Describe 'Add-NovaCliOptionValue' {
+    It 'creates a single-entry array when the option is new' {
+        $options = @{}
+        Add-NovaCliOptionValue -Options $options -Name 'PackagePath' -Value 'a'
+        ,$options.PackagePath | Should -BeOfType ([System.Array])
+        $options.PackagePath.Count | Should -Be 1
+        $options.PackagePath[0] | Should -Be 'a'
+    }
+
+    It 'appends additional values into the existing option array' {
+        $options = @{PackagePath = 'a'}
+        Add-NovaCliOptionValue -Options $options -Name 'PackagePath' -Value 'b'
+        $options.PackagePath.Count | Should -Be 2
+        $options.PackagePath[1] | Should -Be 'b'
+    }
+}

tests/private/cli/ConvertFromNovaBuildCliArgument.Tests.ps1

@@ -0,0 +1,15 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaBuildCliArgument.ps1')
+
+    function ConvertFrom-NovaCliSwitchArgument {param([string[]]$Arguments, [hashtable]$TokenMap) return @{TokenMap = $TokenMap; Arguments = $Arguments}}
+}
+
+Describe 'ConvertFrom-NovaBuildCliArgument' {
+    It 'maps build switches to canonical options' {
+        $result = ConvertFrom-NovaBuildCliArgument -Arguments @('-i')
+        $result.TokenMap['--continuous-integration'] | Should -Be 'ContinuousIntegration'
+        $result.TokenMap['-o'] | Should -Be 'OverrideWarning'
+        $result.TokenMap['--override-warning'] | Should -Be 'OverrideWarning'
+    }
+}

tests/private/cli/ConvertFromNovaBumpCliArgument.Tests.ps1

@@ -0,0 +1,16 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaBumpCliArgument.ps1')
+
+    function ConvertFrom-NovaCliSwitchArgument {param([string[]]$Arguments, [hashtable]$TokenMap) return $TokenMap}
+}
+
+Describe 'ConvertFrom-NovaBumpCliArgument' {
+    It 'maps bump switches to canonical options' {
+        $tokenMap = ConvertFrom-NovaBumpCliArgument -Arguments @()
+        $tokenMap['--preview'] | Should -Be 'Preview'
+        $tokenMap['-p'] | Should -Be 'Preview'
+        $tokenMap['--continuous-integration'] | Should -Be 'ContinuousIntegration'
+        $tokenMap['--override-warning'] | Should -Be 'OverrideWarning'
+    }
+}

tests/private/cli/ConvertFromNovaCliArgument.Tests.ps1

@@ -0,0 +1,50 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaCliArgument.ps1')
+    . (Join-Path $projectRoot 'src/private/cli/GetNovaCliRequiredArgumentValue.ps1')
+
+    function ConvertTo-NovaCliArgumentArray {param([hashtable]$BoundParameters, [string[]]$Arguments) return @($Arguments | Where-Object {$_})}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Add-NovaCliDeliveryOption' {
+    It 'adds the option when allowed' {
+        $options = @{}
+        Add-NovaCliDeliveryOption -Options $options -AllowedOptionNameList @('Local') -Option ([pscustomobject]@{Name='Local';Value=$true}) -Token '--local'
+        $options.Local | Should -BeTrue
+    }
+
+    It 'throws when option is not in allowed list' {
+        {Add-NovaCliDeliveryOption -Options @{} -AllowedOptionNameList @('Other') -Option ([pscustomobject]@{Name='Local';Value=$true}) -Token '--local'} | Should -Throw '*Unknown argument: --local*'
+    }
+}
+
+Describe 'ConvertFrom-NovaCliArgument' {
+    It 'parses common delivery flags using the default allowed list' {
+        $options = ConvertFrom-NovaCliArgument -Arguments @('--local', '--repository', 'feed', '--api-key', 'KEY', '--skip-tests')
+        $options.Local | Should -BeTrue
+        $options.Repository | Should -Be 'feed'
+        $options.ApiKey | Should -Be 'KEY'
+        $options.SkipTests | Should -BeTrue
+    }
+
+    It 'throws when a flag is not in the allowed list' {
+        {ConvertFrom-NovaCliArgument -Arguments @('--local') -AllowedOptionNameList @('Other')} | Should -Throw '*Unknown argument*'
+    }
+
+    It 'throws for unknown flags' {
+        {ConvertFrom-NovaCliArgument -Arguments @('--bogus')} | Should -Throw '*Unknown argument: --bogus*'
+    }
+}
+
+Describe 'ConvertFrom-NovaPackageCliArgument' {
+    It 'restricts the allowed options to package-relevant flags' {
+        $options = ConvertFrom-NovaPackageCliArgument -Arguments @('--skip-tests', '--override-warning')
+        $options.SkipTests | Should -BeTrue
+        $options.OverrideWarning | Should -BeTrue
+    }
+
+    It 'rejects flags outside the package allow list' {
+        {ConvertFrom-NovaPackageCliArgument -Arguments @('--local')} | Should -Throw '*Unknown argument*'
+    }
+}

tests/private/cli/ConvertFromNovaCliModeArgument.Tests.ps1

@@ -0,0 +1,39 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaCliModeArgument.ps1')
+
+    function ConvertTo-NovaCliArgumentArray {param([hashtable]$BoundParameters, [string[]]$Arguments) return ,@(@($Arguments) | Where-Object {$_})}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Get-NovaCliModeArgumentValue' {
+    BeforeEach {
+        $script:def = [pscustomobject]@{
+            EmptyResult = 'empty'
+            TokenMap = @{'--on' = 'on'; '--off' = 'off'}
+            Usage = [pscustomobject]@{Message = 'usage failure'; ErrorId = 'Nova.Test.Usage'}
+            UnknownArgumentUsesUsageError = $true
+        }
+    }
+
+    It 'returns EmptyResult when no arguments are provided' {
+        Get-NovaCliModeArgumentValue -Arguments @() -Definition $script:def | Should -Be 'empty'
+    }
+
+    It 'returns the mapped token value for a known argument' {
+        Get-NovaCliModeArgumentValue -Arguments @('--on') -Definition $script:def | Should -Be 'on'
+    }
+
+    It 'throws the usage error when too many arguments are given' {
+        {Get-NovaCliModeArgumentValue -Arguments @('--on', '--off') -Definition $script:def} | Should -Throw '*usage failure*'
+    }
+
+    It 'throws the usage error for unknown arguments when configured' {
+        {Get-NovaCliModeArgumentValue -Arguments @('--unknown') -Definition $script:def} | Should -Throw '*usage failure*'
+    }
+
+    It 'throws a generic unknown argument error when usage routing is disabled' {
+        $script:def.UnknownArgumentUsesUsageError = $false
+        {Get-NovaCliModeArgumentValue -Arguments @('--bogus') -Definition $script:def} | Should -Throw '*Unknown argument: --bogus*'
+    }
+}

tests/private/cli/ConvertFromNovaCliSwitchArgument.Tests.ps1

@@ -0,0 +1,30 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaCliSwitchArgument.ps1')
+
+    function ConvertTo-NovaCliArgumentArray {param([hashtable]$BoundParameters, [string[]]$Arguments) return @($Arguments | Where-Object {$_})}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Get-NovaCliSwitchOptionName' {
+    It 'returns the mapped option name' {
+        Get-NovaCliSwitchOptionName -TokenMap @{'-x' = 'Foo'} -Token '-x' | Should -Be 'Foo'
+    }
+
+    It 'throws for unknown tokens' {
+        {Get-NovaCliSwitchOptionName -TokenMap @{} -Token '-y'} | Should -Throw '*Unknown argument: -y*'
+    }
+}
+
+Describe 'ConvertFrom-NovaCliSwitchArgument' {
+    It 'sets each token-mapped option to $true' {
+        $tokenMap = @{'-a' = 'AOpt'; '-b' = 'BOpt'}
+        $options = ConvertFrom-NovaCliSwitchArgument -Arguments @('-a', '-b') -TokenMap $tokenMap
+        $options.AOpt | Should -BeTrue
+        $options.BOpt | Should -BeTrue
+    }
+
+    It 'throws when an argument is not in the token map' {
+        {ConvertFrom-NovaCliSwitchArgument -Arguments @('-z') -TokenMap @{}} | Should -Throw '*Unknown argument*'
+    }
+}

tests/private/cli/ConvertFromNovaDeployCliArgument.Tests.ps1

@@ -0,0 +1,39 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaDeployCliArgument.ps1')
+    . (Join-Path $projectRoot 'src/private/cli/AddNovaCliOptionValue.ps1')
+    . (Join-Path $projectRoot 'src/private/cli/AddNovaCliHeaderOption.ps1')
+    . (Join-Path $projectRoot 'src/private/cli/GetNovaCliRequiredArgumentValue.ps1')
+
+    function ConvertTo-NovaCliArgumentArray {param([hashtable]$BoundParameters, [string[]]$Arguments) return @($Arguments | Where-Object {$_})}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'ConvertFrom-NovaDeployCliArgument' {
+    It 'parses all known deploy flags' {
+        $options = ConvertFrom-NovaDeployCliArgument -Arguments @(
+            '--repository', 'feed',
+            '--url', 'https://nuget',
+            '--path', 'a.nupkg',
+            '--type', 'NuGet',
+            '--upload-path', '/sub',
+            '--token', 'tok',
+            '--token-env', 'TOK',
+            '--auth-scheme', 'Bearer',
+            '--header', 'X-A=1'
+        )
+        $options.Repository | Should -Be 'feed'
+        $options.Url | Should -Be 'https://nuget'
+        $options.PackagePath[0] | Should -Be 'a.nupkg'
+        $options.PackageType[0] | Should -Be 'NuGet'
+        $options.UploadPath | Should -Be '/sub'
+        $options.Token | Should -Be 'tok'
+        $options.TokenEnvironmentVariable | Should -Be 'TOK'
+        $options.AuthenticationScheme | Should -Be 'Bearer'
+        $options.Headers['X-A'] | Should -Be '1'
+    }
+
+    It 'throws for unknown flags' {
+        {ConvertFrom-NovaDeployCliArgument -Arguments @('--bogus')} | Should -Throw '*Unknown argument*'
+    }
+}

tests/private/cli/ConvertFromNovaInitCliArgument.Tests.ps1

@@ -0,0 +1,27 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/cli/ConvertFromNovaInitCliArgument.ps1')
+    . (Join-Path $projectRoot 'src/private/cli/GetNovaCliRequiredArgumentValue.ps1')
+
+    function ConvertTo-NovaCliArgumentArray {param([hashtable]$BoundParameters, [string[]]$Arguments) return @($Arguments | Where-Object {$_})}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'ConvertFrom-NovaInitCliArgument' {
+    It 'reads --path value' {
+        $options = ConvertFrom-NovaInitCliArgument -Arguments @('--path', '/tmp/x')
+        $options.Path | Should -Be '/tmp/x'
+    }
+
+    It 'sets Example when --example/-e provided' {
+        (ConvertFrom-NovaInitCliArgument -Arguments @('-e')).Example | Should -BeTrue
+    }
+
+    It 'throws for unknown switches' {
+        {ConvertFrom-NovaInitCliArgument -Arguments @('--bogus')} | Should -Throw '*Unknown argument*'
+    }
+
+    It 'rejects positional path tokens with a guided message' {
+        {ConvertFrom-NovaInitCliArgument -Arguments @('positional')} | Should -Throw '*positional paths are no longer accepted*'
+    }
+}