feat(#204): mirror release helper tests

Closes Migrate release domain tests (5)
Fixes #204

Author: stiwicourage

CHANGELOG.md

@@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - Added mirrored, dot-source-first Pester test files for scaffold and update private helpers (`src/private/scaffold/*.ps1` and `src/private/update/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/scaffold/` or `tests/private/update/` instead of being covered only through broad legacy coverage files.
 - Added mirrored, dot-source-first Pester test files for build and shared private helpers (`src/private/build/*.ps1`, `src/private/build/manifest/*.ps1`, and `src/private/shared/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/build/`, `tests/private/build/manifest/`, or `tests/private/shared/` instead of being covered only through broad legacy coverage files.
 - Added mirrored, dot-source-first Pester test files for CLI private helpers (`src/private/cli/*.ps1`), so most CLI argument parsers, prompt helpers, and per-command CLI wrappers now have a focused test file under `tests/private/cli/`. Large cross-cutting CLI orchestrators (`InvokeNovaCliCommandRoute.ps1`, `GetNovaCliArgumentRoutingState.ps1`, `FormatNovaCliCommandHelp.ps1`, `ConfirmNovaCliAction.ps1`, `GetNovaCliInvocationContext.ps1`) stay covered by the existing cross-cutting CLI tests.
+- Added mirrored, dot-source-first Pester test files for release private helpers (`src/private/release/*.ps1`), so most release, publish, and version-update helpers (local publish path resolution, publish parameter mapping, version label inference, version part calculation, prerelease label handling, release request shaping, and per-step write/import helpers) now have a focused test file under `tests/private/release/`. Multi-step release/publish/version-update workflow orchestrators (`InvokeNovaReleaseWorkflow.ps1`, `InvokeNovaPublishWorkflow.ps1`, `GetNovaVersionUpdateWorkflowContext.ps1`) stay covered by the existing cross-cutting release tests.
 
 
 ### Changed

tests/private/release/FindLocalModulePathMatch.Tests.ps1

@@ -0,0 +1,24 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/FindLocalModulePathMatch.ps1')
+
+    function Stop-NovaOperation {param($Message, $ErrorId, $Category, $TargetObject) throw $Message}
+}
+
+Describe 'Find-LocalModulePathMatch' {
+    It 'returns the first existing path matching the pattern' {
+        $tmp = [System.IO.Path]::GetTempPath().TrimEnd([System.IO.Path]::DirectorySeparatorChar)
+        $details = [pscustomobject]@{Message='m'; ErrorId='e'; Category=[System.Management.Automation.ErrorCategory]::ObjectNotFound; TargetObject='t'}
+        Find-LocalModulePathMatch -ModulePaths @($tmp) -MatchPattern '.*' -ErrorDetails $details | Should -Be $tmp
+    }
+
+    It 'throws when no entry matches the pattern' {
+        $details = [pscustomobject]@{Message='not found'; ErrorId='e'; Category=[System.Management.Automation.ErrorCategory]::ObjectNotFound; TargetObject='t'}
+        {Find-LocalModulePathMatch -ModulePaths @('/a') -MatchPattern '^nope$' -ErrorDetails $details} | Should -Throw '*not found*'
+    }
+
+    It 'throws when the matched entry does not exist on disk' {
+        $details = [pscustomobject]@{Message='missing'; ErrorId='e'; Category=[System.Management.Automation.ErrorCategory]::ObjectNotFound; TargetObject='t'}
+        {Find-LocalModulePathMatch -ModulePaths @('/does/not/exist/abc') -MatchPattern '.*' -ErrorDetails $details} | Should -Throw '*missing*'
+    }
+}

tests/private/release/GetGitCommitMessagesForVersionBump.Tests.ps1

@@ -0,0 +1,52 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetGitCommitMessagesForVersionBump.ps1')
+
+    function Test-GitRepositoryIsAvailable {param($ProjectRoot) return $true}
+    function Invoke-NovaGitCommand {param($ProjectRoot, $Arguments) return [pscustomobject]@{ExitCode=0; Output=@()}}
+    function Get-NovaGitCommandOutputText {param($Result) return ($Result.Output -join "`n")}
+}
+
+Describe 'Get-GitCommitMessageForVersionBump' {
+    It 'returns an empty array when no git repository is available' {
+        Mock Test-GitRepositoryIsAvailable {return $false}
+        $messages = Get-GitCommitMessageForVersionBump -ProjectRoot '/proj'
+        @($messages).Count | Should -Be 0
+    }
+
+    It 'returns parsed commit messages when git is available' {
+        Mock Invoke-NovaGitCommand {return [pscustomobject]@{ExitCode=0; Output=@('feat: a','body','--END-COMMIT--','fix: b','--END-COMMIT--')}}
+        $messages = Get-GitCommitMessageForVersionBump -ProjectRoot '/proj'
+        @($messages).Count | Should -BeGreaterThan 0
+    }
+}
+
+Describe 'Get-NovaVersionBumpCommitLogResult' {
+    It 'uses lastTag..HEAD range when a last tag was detected' {
+        Mock Invoke-NovaGitCommand {return [pscustomobject]@{ExitCode=0; Output=@('out')}}
+        $tagResult = [pscustomobject]@{ExitCode=0; Output=@('v1.0.0')}
+        $result = Get-NovaVersionBumpCommitLogResult -ProjectRoot '/proj' -Format 'f' -LastTagResult $tagResult
+        $result.ExitCode | Should -Be 0
+        Should -Invoke Invoke-NovaGitCommand -ParameterFilter {$Arguments -contains 'v1.0.0..HEAD'}
+    }
+
+    It 'falls back to plain log when no tag is found' {
+        Mock Invoke-NovaGitCommand {return [pscustomobject]@{ExitCode=0; Output=@()}}
+        $tagResult = [pscustomobject]@{ExitCode=128; Output=@()}
+        Get-NovaVersionBumpCommitLogResult -ProjectRoot '/proj' -Format 'f' -LastTagResult $tagResult | Out-Null
+        Should -Invoke Invoke-NovaGitCommand -ParameterFilter {-not ($Arguments -match '\.\.HEAD$')}
+    }
+}
+
+Describe 'ConvertFrom-NovaVersionBumpCommitLogResult' {
+    It 'returns an empty array when the result has a non-zero exit code' {
+        $result = [pscustomobject]@{ExitCode=1; Output=@('feat: x')}
+        @((ConvertFrom-NovaVersionBumpCommitLogResult -Result $result)).Count | Should -Be 0
+    }
+
+    It 'splits commits on the --END-COMMIT-- delimiter and trims them' {
+        $result = [pscustomobject]@{ExitCode=0; Output=@('feat: a','body','--END-COMMIT--','fix: b','--END-COMMIT--')}
+        $commits = ConvertFrom-NovaVersionBumpCommitLogResult -Result $result
+        @($commits).Count | Should -BeGreaterThan 0
+    }
+}

tests/private/release/GetLocalModulePath.Tests.ps1

@@ -0,0 +1,16 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetLocalModulePath.ps1')
+
+    function Get-LocalModulePathEntryList {return @('/a')}
+    function Get-LocalModulePathPattern {return 'pattern'}
+    function Get-LocalModulePathErrorMessage {param($MatchPattern) return "no $MatchPattern"}
+    function Find-LocalModulePathMatch {param($ModulePaths, $MatchPattern, $ErrorDetails) return "match-of-$MatchPattern"}
+}
+
+Describe 'Get-LocalModulePath' {
+    It 'delegates to Find-LocalModulePathMatch with the assembled error details' {
+        Mock Find-LocalModulePathMatch {return "ok-$($ErrorDetails.ErrorId)"}
+        Get-LocalModulePath | Should -Be 'ok-Nova.Environment.LocalModulePathNotFound'
+    }
+}

tests/private/release/GetLocalModulePathEntryList.Tests.ps1

@@ -0,0 +1,23 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetLocalModulePathEntryList.ps1')
+
+    function Get-NovaEnvironmentVariableValue {param($Name) return $null}
+}
+
+Describe 'Get-LocalModulePathEntryList' {
+    It 'returns an empty array when PSModulePath is empty' {
+        Mock Get-NovaEnvironmentVariableValue {return ''}
+        $result = Get-LocalModulePathEntryList
+        @($result).Count | Should -Be 0
+    }
+
+    It 'splits, trims, and deduplicates path entries' {
+        $sep = [IO.Path]::PathSeparator
+        Mock Get-NovaEnvironmentVariableValue {return "/a$sep  /b  $sep/a$sep"}
+        $result = Get-LocalModulePathEntryList
+        @($result).Count | Should -Be 2
+        $result | Should -Contain '/a'
+        $result | Should -Contain '/b'
+    }
+}

tests/private/release/GetLocalModulePathErrorMessage.Tests.ps1

@@ -0,0 +1,19 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetLocalModulePathErrorMessage.ps1')
+}
+
+Describe 'Get-LocalModulePathErrorMessage' {
+    It 'mentions the match pattern in the message' {
+        $message = Get-LocalModulePathErrorMessage -MatchPattern 'PATTERN'
+        $message | Should -Match 'PATTERN'
+    }
+
+    It 'uses the Windows phrasing on Windows' -Skip:(-not $IsWindows) {
+        Get-LocalModulePathErrorMessage -MatchPattern 'p' | Should -Match '^No windows'
+    }
+
+    It 'uses the macOS/Linux phrasing on POSIX' -Skip:$IsWindows {
+        Get-LocalModulePathErrorMessage -MatchPattern 'p' | Should -Match '^No macOS/Linux'
+    }
+}

tests/private/release/GetLocalModulePathPattern.Tests.ps1

@@ -0,0 +1,14 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetLocalModulePathPattern.ps1')
+}
+
+Describe 'Get-LocalModulePathPattern' {
+    It 'returns a Windows pattern on Windows' -Skip:(-not $IsWindows) {
+        Get-LocalModulePathPattern | Should -Be '\\Documents\\PowerShell\\Modules'
+    }
+
+    It 'returns a POSIX pattern on macOS/Linux' -Skip:$IsWindows {
+        Get-LocalModulePathPattern | Should -Be '/\.local/share/powershell/Modules$'
+    }
+}

tests/private/release/GetNovaInstalledProjectManifestPath.Tests.ps1

@@ -0,0 +1,18 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetNovaInstalledProjectManifestPath.ps1')
+
+    function Resolve-NovaLocalPublishPath {param($ModuleDirectoryPath) return '/m'}
+    function Get-NovaPublishedLocalManifestPath {param($PublishInvocation) return $PublishInvocation}
+    function Get-NovaProjectInfo {return [pscustomobject]@{ProjectName='X'}}
+}
+
+Describe 'Get-NovaInstalledProjectManifestPath' {
+    It 'builds a local PublishInvocation and delegates to Get-NovaPublishedLocalManifestPath' {
+        $project = [pscustomobject]@{ProjectName='Sample'}
+        $invocation = Get-NovaInstalledProjectManifestPath -ProjectInfo $project -ModuleDirectoryPath '/m'
+        $invocation.IsLocal | Should -BeTrue
+        $invocation.Target | Should -Be '/m'
+        $invocation.Parameters.ProjectInfo | Should -Be $project
+    }
+}

tests/private/release/GetNovaInstalledProjectVersion.Tests.ps1

@@ -0,0 +1,28 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetNovaInstalledProjectVersion.ps1')
+
+    function Get-NovaInstalledProjectManifestPath {param($ProjectInfo, $ModuleDirectoryPath) return '/nonexistent.psd1'}
+    function Format-NovaCliVersionString {param($Name, $Version) return "$Name $Version"}
+    function Get-NovaProjectInfo {return [pscustomobject]@{ProjectName='X'}}
+    function Stop-NovaOperation {param($Message, $ErrorId, $Category, $TargetObject) throw $Message}
+    function Test-ModuleManifest {param($Path, $ErrorAction) return [pscustomobject]@{Version=[version]'1.2.3'}}
+}
+
+Describe 'Get-NovaInstalledProjectVersion' {
+    It 'throws when manifest does not exist' {
+        Mock Get-NovaInstalledProjectManifestPath {return '/does/not/exist.psd1'}
+        {Get-NovaInstalledProjectVersion -ProjectInfo ([pscustomobject]@{ProjectName='X'})} | Should -Throw '*Local module install not found*'
+    }
+
+    It 'returns formatted name+version when manifest exists' {
+        $tmp = [System.IO.Path]::GetTempFileName()
+        try {
+            Mock Get-NovaInstalledProjectManifestPath {return $tmp}
+            Mock Test-ModuleManifest {return [pscustomobject]@{Version=[version]'2.0.0'}}
+            Get-NovaInstalledProjectVersion -ProjectInfo ([pscustomobject]@{ProjectName='X'}) | Should -Be 'X 2.0.0'
+        } finally {
+            Remove-Item -LiteralPath $tmp -ErrorAction SilentlyContinue
+        }
+    }
+}

tests/private/release/GetNovaLocalPublishActivation.Tests.ps1

@@ -0,0 +1,19 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/release/GetNovaLocalPublishActivation.ps1')
+
+    function Get-NovaPublishedLocalManifestPath {param($PublishInvocation) return '/m/x.psd1'}
+    function Import-NovaPublishedLocalModule {param($ProjectName, $ManifestPath)}
+}
+
+Describe 'Get-NovaLocalPublishActivation' {
+    It 'returns $null when the invocation is not local' {
+        Get-NovaLocalPublishActivation -PublishInvocation ([pscustomobject]@{IsLocal=$false}) | Should -BeNullOrEmpty
+    }
+
+    It 'returns a manifest path and import action when local' {
+        $result = Get-NovaLocalPublishActivation -PublishInvocation ([pscustomobject]@{IsLocal=$true})
+        $result.ManifestPath | Should -Be '/m/x.psd1'
+        $result.ImportAction | Should -Not -BeNullOrEmpty
+    }
+}