fix: restore nested private helper coverage

stiwicourage · stiwicourage · commit 6102679b0c18 · 2026-05-17T17:21:51.000+02:00
- expand Pester CodeCoverage paths so nested src/private folders are included in artifacts/coverage.xml
 - stop build test support files from shadowing manifest helper coverage
 - add mirrored duplicate-validation tests for quality/duplicates helpers
diff --git a/.github/instructions/testing-policy.instructions.md b/.github/instructions/testing-policy.instructions.md
@@ -16,7 +16,7 @@ NovaModuleTools is migrating tests to a 1:1 source-to-test layout per issue #208
 - Tests do **not** `Import-Module $project.OutputModuleDir`.
 - Tests do **not** use `InModuleScope <ModuleName> { ... }`. Mocked functions live in the same scope as the test because they were dot-sourced into it.
 - Shared fixtures and dot-source helpers live in `tests/TestHelpers/`.
-- This makes `project.json` `Pester.CodeCoverage.Path = ["src/public/*.ps1", "src/private/**/*.ps1"]` produce real source-file coverage and means `Test-NovaBuild` does not require a `dist/` folder.
+- This makes `project.json` `Pester.CodeCoverage.Path = ["src/public/*.ps1", "src/private/*.ps1", "src/private/*/*.ps1", "src/private/*/*/*.ps1"]` produce real source-file coverage, including nested helper folders such as `src/private/build/manifest/` and `src/private/quality/duplicates/`, and means `Test-NovaBuild` does not require a `dist/` folder.
 
 Example:
 
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -56,6 +56,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - Code coverage in `Test-NovaBuild` now runs against the source files, instead of the built `dist/<ModuleName>/<ModuleName>.psm1` file so measured coverage percentages and line numbers align with the deployed module.
 - `Invoke-CodeSceneAnalysis.ps1` now normalizes Pester's JaCoCo output before upload so the `<class sourcefilename>` and `<sourcefile name>` entries are bare filenames and `package + sourcefile` resolves to real repository paths. This fixes the CodeScene `cs-coverage upload` failure "The coverage data does not contains any records related to the current repo" that appeared after the source-mirrored coverage migration.
 - `Invoke-CodeSceneAnalysis.ps1` now only invokes the `cs-coverage upload … --metric branch-coverage` step when the JaCoCo report actually contains `<counter type="BRANCH">` entries, so Pester reports that only emit line counters no longer fail the CodeScene step with "Requested metric is not present in coverage data".
+- Pester coverage configuration now uses explicit private-folder depth globs instead of `src/private/**/*.ps1`, so nested helpers such as `src/private/build/manifest/` and `src/private/quality/duplicates/` are included in `artifacts/coverage.xml` during the full `Test-NovaBuild` run.
 
 
 ### Security
diff --git a/RELEASE_NOTE.md b/RELEASE_NOTE.md
@@ -1,7 +1,6 @@
 # Release notes
 
-This file summarizes public cmdlet, CLI, configuration, and migration changes for NovaModuleTools.
-`CHANGELOG.md` remains the exhaustive record of all changes in each release. **UNRELEASED** changes will be included in the next **stable** release!
+This file summarizes the release notes for NovaModuleTools. **UNRELEASED** changes will be included in the next **stable** release!
 
 ## [Unreleased]
 ### Added
diff --git a/project.json b/project.json
@@ -44,7 +44,9 @@
       "Enabled": true,
       "Path": [
         "src/public/*.ps1",
-        "src/private/**/*.ps1"
+        "src/private/*.ps1",
+        "src/private/*/*.ps1",
+        "src/private/*/*/*.ps1"
       ],
       "CoveragePercentTarget": 99,
       "OutputPath": "artifacts/coverage.xml",
diff --git a/src/resources/ProjectTemplate.json b/src/resources/ProjectTemplate.json
@@ -27,7 +27,9 @@
       "Enabled": false,
       "Path": [
         "src/public/*.ps1",
-        "src/private/**/*.ps1",
+        "src/private/*.ps1",
+        "src/private/*/*.ps1",
+        "src/private/*/*/*.ps1",
         "src/classes/*.ps1"
       ],
       "CoveragePercentTarget": 90,
diff --git a/src/resources/agentic-copilot/.github/instructions/testing-policy.instructions.md b/src/resources/agentic-copilot/.github/instructions/testing-policy.instructions.md
@@ -16,7 +16,7 @@ Use this file when changing production code, tests, coverage behavior, or CI tes
 - Tests do **not** `Import-Module $project.OutputModuleDir`.
 - Tests do **not** use `InModuleScope <ModuleName> { ... }`. Mocked functions live in the same scope as the test because they were dot-sourced into it.
 - Shared fixtures and dot-source helpers live in `tests/TestHelpers/`.
-- This makes `project.json` `Pester.CodeCoverage.Path = ["src/public/*.ps1", "src/private/**/*.ps1"]` produce real source-file coverage and means `Test-NovaBuild` does not require a `dist/` folder.
+- This makes `project.json` `Pester.CodeCoverage.Path = ["src/public/*.ps1", "src/private/*.ps1", "src/private/*/*.ps1", "src/private/*/*/*.ps1"]` produce real source-file coverage, including nested helper folders such as `src/private/build/manifest/` and `src/private/quality/duplicates/`, and means `Test-NovaBuild` does not require a `dist/` folder.
 
 Example:
 
diff --git a/src/resources/example/project.json b/src/resources/example/project.json
@@ -86,7 +86,9 @@
       "Enabled": false,
       "Path": [
         "src/public/*.ps1",
-        "src/private/**/*.ps1",
+        "src/private/*.ps1",
+        "src/private/*/*.ps1",
+        "src/private/*/*/*.ps1",
         "src/classes/*.ps1"
       ],
       "CoveragePercentTarget": 90,
diff --git a/tests/private/build/AssertNovaPublicFunctionFileLayout.TestSupport.ps1 b/tests/private/build/AssertNovaPublicFunctionFileLayout.TestSupport.ps1
@@ -4,4 +4,3 @@ function Stop-NovaOperation {
     $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
     throw $record
 }
-function Get-FunctionNameFromFile {param($filePath)}
diff --git a/tests/private/build/AssertNovaPublicFunctionFileLayout.Tests.ps1 b/tests/private/build/AssertNovaPublicFunctionFileLayout.Tests.ps1
@@ -1,6 +1,7 @@
 BeforeAll {
     $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
     . (Join-Path $projectRoot 'src/private/build/AssertNovaPublicFunctionFileLayout.ps1')
+    . (Join-Path $projectRoot 'src/private/build/manifest/GetFunctionNameFromFile.ps1')
 
     . (Join-Path $PSScriptRoot 'AssertNovaPublicFunctionFileLayout.TestSupport.ps1')
 }
diff --git a/tests/private/build/BuildManifest.TestSupport.ps1 b/tests/private/build/BuildManifest.TestSupport.ps1
@@ -5,6 +5,3 @@ function Stop-NovaOperation {
     throw $record
 }
 function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
-function Get-FunctionNameFromFile {param($filePath); return @('Foo')}
-function Get-AliasInFunctionFromFile {param($filePath); return @()}
-function Assert-ManifestSchema {param($Manifest, $AllowedParameter)}
diff --git a/tests/private/build/BuildManifest.Tests.ps1 b/tests/private/build/BuildManifest.Tests.ps1
@@ -1,6 +1,9 @@
 BeforeAll {
     $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
     . (Join-Path $projectRoot 'src/private/build/BuildManifest.ps1')
+    . (Join-Path $projectRoot 'src/private/build/manifest/GetFunctionNameFromFile.ps1')
+    . (Join-Path $projectRoot 'src/private/build/manifest/GetAliasNameFromFunction.ps1')
+    . (Join-Path $projectRoot 'src/private/build/manifest/AssertManifestSchema.ps1')
 
     . (Join-Path $PSScriptRoot 'BuildManifest.TestSupport.ps1')
 }
diff --git a/tests/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.TestSupport.ps1 b/tests/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.TestSupport.ps1
@@ -0,0 +1,44 @@
+function Stop-NovaOperation {
+    param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
+
+    $exception = [System.Exception]::new($Message)
+    $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
+    throw $record
+}
+
+function New-DuplicateValidationProjectInfo {
+    param(
+        [Parameter(Mandatory)][string]$ProjectRoot,
+        [Parameter(Mandatory)][string]$ModuleContent,
+        [Parameter(Mandatory)][hashtable]$SourceFileMap
+    )
+
+    $classesDir = Join-Path $ProjectRoot 'src/classes'
+    $publicDir = Join-Path $ProjectRoot 'src/public'
+    $privateDir = Join-Path $ProjectRoot 'src/private'
+    $outputDir = Join-Path $ProjectRoot 'dist/NovaModuleTools'
+
+    New-Item -ItemType Directory -Path $classesDir, $publicDir, $privateDir, $outputDir -Force | Out-Null
+
+    foreach ($relativePath in $SourceFileMap.Keys) {
+        $filePath = Join-Path $ProjectRoot $relativePath
+        $directory = Split-Path -Parent $filePath
+        if (-not [string]::IsNullOrWhiteSpace($directory)) {
+            New-Item -ItemType Directory -Path $directory -Force | Out-Null
+        }
+
+        Set-Content -LiteralPath $filePath -Value $SourceFileMap[$relativePath]
+    }
+
+    $modulePath = Join-Path $outputDir 'NovaModuleTools.psm1'
+    Set-Content -LiteralPath $modulePath -Value $ModuleContent
+
+    return [pscustomobject]@{
+        BuildRecursiveFolders = $true
+        ProjectRoot = $ProjectRoot
+        ClassesDir = $classesDir
+        PublicDir = $publicDir
+        PrivateDir = $privateDir
+        ModuleFilePSM1 = $modulePath
+    }
+}
diff --git a/tests/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.Tests.ps1 b/tests/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.Tests.ps1
@@ -0,0 +1,73 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot)))
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetOrCreateHashtableList.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/AddFunctionSourceIndexEntry.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetPowerShellAstFromFile.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetTopLevelFunctionAst.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetTopLevelFunctionAstFromFile.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetIndexableFunctionAstFromFile.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/AddFunctionSourceIndexEntryFromFile.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetIndexableSourceFile.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetFunctionSourceIndex.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetDuplicateFunctionGroup.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/GetDuplicateFunctionSourceLine.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/FormatDuplicateFunctionErrorMessage.ps1')
+    . (Join-Path $projectRoot 'src/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.ps1')
+    . (Join-Path $projectRoot 'src/private/build/GetProjectScriptFiles.ps1')
+    . (Join-Path $projectRoot 'src/private/build/GetOrderedScriptFileForDirectory.ps1')
+    . (Join-Path $projectRoot 'src/private/shared/GetNormalizedRelativePath.ps1')
+
+    . (Join-Path $PSScriptRoot 'AssertBuiltModuleHasNoDuplicateFunctionNames.TestSupport.ps1')
+}
+
+Describe 'Assert-BuiltModuleHasNoDuplicateFunctionName' {
+    BeforeEach {
+        $script:projectRoot = Join-Path ([System.IO.Path]::GetTempPath()) ([guid]::NewGuid())
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:projectRoot -Recurse -Force -ErrorAction SilentlyContinue
+    }
+
+    It 'returns when the built module does not contain duplicate function names' {
+        $projectInfo = New-DuplicateValidationProjectInfo -ProjectRoot $script:projectRoot -ModuleContent @'
+function Get-Alpha {}
+function Get-Beta {}
+'@ -SourceFileMap @{
+            'src/public/GetAlpha.ps1' = 'function Get-Alpha {}'
+            'src/public/GetBeta.ps1' = 'function Get-Beta {}'
+        }
+
+        { Assert-BuiltModuleHasNoDuplicateFunctionName -ProjectInfo $projectInfo } | Should -Not -Throw
+    }
+
+    It 'throws a source-mapped error when the built module contains duplicate top-level function names' {
+        $projectInfo = New-DuplicateValidationProjectInfo -ProjectRoot $script:projectRoot -ModuleContent @'
+function Get-Alpha {}
+function get-alpha {}
+'@ -SourceFileMap @{
+            'src/public/GetAlpha.ps1' = @'
+function Get-Alpha {
+    param()
+}
+'@
+            'src/private/GetAlphaOverride.ps1' = @'
+function Get-Alpha {
+    param()
+}
+'@
+        }
+
+        try {
+            Assert-BuiltModuleHasNoDuplicateFunctionName -ProjectInfo $projectInfo
+            throw 'Expected duplicate-function validation to fail.'
+        } catch {
+            $_.FullyQualifiedErrorId | Should -Be 'Nova.Validation.BuiltModuleDuplicateFunctionName'
+            $_.Exception.Message | Should -Match 'Duplicate top-level function names detected'
+            $_.Exception.Message | Should -Match 'dist line'
+            $_.Exception.Message | Should -Match 'source files'
+            $_.Exception.Message | Should -Match 'src/public/GetAlpha\.ps1'
+            $_.Exception.Message | Should -Match 'src/private/GetAlphaOverride\.ps1'
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -4,4 +4,3 @@ function Stop-NovaOperation {`
`4`	`4`	`$record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)`
`5`	`5`	`throw $record`
`6`	`6`	`}`
`7`		`-function Get-FunctionNameFromFile {param($filePath)}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`BeforeAll {`
`2`	`2`	`$projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))`
`3`	`3`	`. (Join-Path $projectRoot 'src/private/build/AssertNovaPublicFunctionFileLayout.ps1')`
	`4`	`+ . (Join-Path $projectRoot 'src/private/build/manifest/GetFunctionNameFromFile.ps1')`
`4`	`5`
`5`	`6`	`. (Join-Path $PSScriptRoot 'AssertNovaPublicFunctionFileLayout.TestSupport.ps1')`
`6`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,3 @@ function Stop-NovaOperation {`
`5`	`5`	`throw $record`
`6`	`6`	`}`
`7`	`7`	`function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}`
`8`		`-function Get-FunctionNameFromFile {param($filePath); return @('Foo')}`
`9`		`-function Get-AliasInFunctionFromFile {param($filePath); return @()}`
`10`		`-function Assert-ManifestSchema {param($Manifest, $AllowedParameter)}`