fix: restore CodeScene-safe mirrored test health

 Refactor the migrated mirrored Pester suite into per-file
 `*.TestSupport.ps1` sidecars and data-driven assertions so the current
 branch change set returns to Code Health 10 without reintroducing
 legacy coverage buckets or dist-module test loading.

 Also harden `Invoke-CodeSceneAnalysis.ps1` so JaCoCo path normalization
 and conditional branch-coverage upload stay maintainable and CI-safe.

Author: stiwicourage

CHANGELOG.md

@@ -32,11 +32,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 
 
 ### Changed
-- Removed the pre-migration broad coverage-bucket suites (`CoverageGaps*`, `CoverageCompletion*`, `Remaining*Coverage*`, broad `NovaCommandModel*`). The mirrored `tests/public/` and `tests/private/<domain>/` suites added in #200 – #206 now own that coverage, and the restored 99% measured coverage confirms no regression, so the parked `tests/_legacy/` reference copies are no longer needed.
+- Removed the pre-migration broad coverage-bucket suites (`CoverageGaps*`, `CoverageCompletion*`, `Remaining*Coverage*`, broad `NovaCommandModel*`). The mirrored `tests/public/` and `tests/private/<domain>/` suites added in now own that coverage, and the restored 99% measured coverage confirms no regression, so the parked `tests/_legacy/` reference copies are no longer needed.
 - Migrated the remaining mirrored private-helper tests (`tests/private/update/`, `tests/private/quality/`, `tests/private/build/InvokeNovaBuildWorkflow.Tests.ps1`, and `tests/private/scaffold/`) off the legacy `Import-Module dist + InModuleScope` pattern to the dot-source-first model, so the full mirrored test suite runs against `src/**/*.ps1` directly and does not require a prior `Invoke-NovaBuild`.
 - Removed the dist-requiring integration and guardrail tests (`Module`, `OutputFiles`, `BuildOptions`, `CiCoverage`, `CliHelperCoverage`, `CliSharedParser`, `PackageLatestPolicy`, `PreambleBuild`, `UpdateNotification`) and their `*TestSupport.ps1` sidecars now that the mirrored suites cover the same behavior and `nova test` no longer depends on `dist/NovaModuleTools` being built first.
 - Test-loading guidance for NovaModuleTools' own tests and for generated Agentic Copilot scaffolds now follows a source-mirrored, dot-source-first pattern: new mirrored tests dot-source the relevant `src/**/*.ps1` files directly in `BeforeAll` instead of importing the built `dist` module or wrapping assertions in `InModuleScope`, so tests run against source files and JaCoCo coverage references real source paths.
 - `project.json` `Pester.CodeCoverage.Enabled` is `true` with a `99` percent target that the migrated, source-mirrored test suite now satisfies; this finalizes the temporary disable from the test-layout migration.
+- Refactored the current branch's source-mirrored test batch into per-file `*.TestSupport.ps1` sidecars and data-driven assertions where needed, so the migrated tests keep Code Health at 10 without falling back to broad legacy buckets or dist-module loading.
 - The architect/design flow now surfaces settled vs unresolved design items before finalization, offers explicit choices for full finalization vs design-package-only handoff, clarifies how to use design notes versus the paste-ready GitHub issue draft, and requires finalization output to follow the project Markdown authoring guidance.
 - `ProjectTemplate.json` and the packaged example `project.json` now include Nova's default Pester `CodeCoverage` block with `Enabled=false`, shared `src/` coverage paths, JaCoCo output, and a `90` percent target so new projects can opt into coverage without hand-authoring the configuration.
 - `Invoke-NovaModuleToolsCI.ps1` now delegates the full test run to a single `Test-NovaBuild` call; the previous second `Invoke-Pester` pass and post-run Cobertura source-path remapping step have been removed.

scripts/build/ci/Invoke-CodeSceneAnalysis.ps1

@@ -107,30 +107,43 @@ function Repair-PesterJaCoCoCoveragePath {
     param([Parameter(Mandatory)][string]$Path)
 
     [xml]$document = Get-Content -LiteralPath $Path -Raw
-    $changed = $false
+    $changed = Repair-CodeSceneJaCoCoNodePathAttribute -Nodes $document.SelectNodes('//class[@sourcefilename]') -AttributeName 'sourcefilename'
+    $changed = (Repair-CodeSceneJaCoCoNodePathAttribute -Nodes $document.SelectNodes('//sourcefile[@name]') -AttributeName 'name') -or $changed
 
-    foreach ($class in $document.SelectNodes('//class[@sourcefilename]')) {
-        $original = $class.GetAttribute('sourcefilename')
-        $normalized = [System.IO.Path]::GetFileName($original)
-        if ($normalized -ne $original) {
-            $class.SetAttribute('sourcefilename', $normalized)
-            $changed = $true
-        }
+    if ($changed) {
+        $document.Save($Path)
+        Write-Host "Normalized JaCoCo sourcefile paths in '$Path' so package + sourcefile resolve to repo files."
     }
+}
 
-    foreach ($sourcefile in $document.SelectNodes('//sourcefile[@name]')) {
-        $original = $sourcefile.GetAttribute('name')
-        $normalized = [System.IO.Path]::GetFileName($original)
-        if ($normalized -ne $original) {
-            $sourcefile.SetAttribute('name', $normalized)
-            $changed = $true
-        }
+function Repair-CodeSceneJaCoCoNodePathAttribute {
+    param(
+        [Parameter(Mandatory)]$Nodes,
+        [Parameter(Mandatory)][string]$AttributeName
+    )
+
+    $changed = $false
+    foreach ($node in $Nodes) {
+        $changed = (Repair-CodeSceneJaCoCoNodeFileName -Node $node -AttributeName $AttributeName) -or $changed
     }
 
-    if ($changed) {
-        $document.Save($Path)
-        Write-Host "Normalized JaCoCo sourcefile paths in '$Path' so package + sourcefile resolve to repo files."
+    return $changed
+}
+
+function Repair-CodeSceneJaCoCoNodeFileName {
+    param(
+        [Parameter(Mandatory)]$Node,
+        [Parameter(Mandatory)][string]$AttributeName
+    )
+
+    $original = $Node.GetAttribute($AttributeName)
+    $normalized = [System.IO.Path]::GetFileName($original)
+    if ($normalized -eq $original) {
+        return $false
     }
+
+    $Node.SetAttribute($AttributeName, $normalized)
+    return $true
 }
 
 function Test-JaCoCoBranchCoverageAvailable {

tests/CodeSceneAnalysis.Tests.ps1

@@ -16,6 +16,34 @@ BeforeAll {
             Output = @($output)
         }
     }
+
+    function New-CodeSceneCoverageUploadRunnerContent {
+        [CmdletBinding()]
+        param(
+            [Parameter(Mandatory)][pscustomobject]$Config
+        )
+
+        $setLocationCommand = ''
+        if ($Config.WorkingDirectory) {
+            $setLocationCommand = "Set-Location '$($Config.WorkingDirectory)'"
+        }
+
+        return @"
+function cs-coverage {
+    param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
+
+    Add-Content -LiteralPath '$($Config.UploadLogPath)' -Value (`$ArgumentList -join ' ') -Encoding utf8
+    `$global:LASTEXITCODE = 0
+}
+
+[Environment]::SetEnvironmentVariable('CS_URL', 'https://codescene.example.test')
+[Environment]::SetEnvironmentVariable('CS_PROJECT_ID', '123')
+[Environment]::SetEnvironmentVariable('CS_ACCESS_TOKEN', 'token')
+$setLocationCommand
+
+& '$codeSceneAnalysisScriptPath' $($Config.Invocation)
+"@
+    }
 }
 
 Describe 'Invoke-CodeSceneAnalysis' {
@@ -81,57 +109,30 @@ function Invoke-WebRequest {
         $outputText | Should -Match '(?s)separate from.*CS_ACCESS_TOKEN'
     }
 
-    It 'still uploads coverage when CoveragePath is provided' {
+    It 'uploads coverage for <Name>' -ForEach @(
+        @{ Name = 'an explicit coverage path'; Mode = 'Explicit'; UploadLogName = 'cs-coverage-upload.txt' }
+        @{ Name = 'the discovered artifacts coverage file'; Mode = 'Discovered'; UploadLogName = 'cs-coverage-upload-discovered.txt' }
+    ) {
+        $artifactsDir = Join-Path $TestDrive 'artifacts'
         $coveragePath = Join-Path $TestDrive 'coverage.xml'
-        $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload.txt'
-        Set-Content -LiteralPath $coveragePath -Value '<report><counter type="BRANCH" missed="1" covered="1" /></report>' -Encoding utf8
-
-        $runnerContent = @"
-function cs-coverage {
-    param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
-
-    Add-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
-    `$global:LASTEXITCODE = 0
-}
-
-[Environment]::SetEnvironmentVariable('CS_URL', 'https://codescene.example.test')
-[Environment]::SetEnvironmentVariable('CS_PROJECT_ID', '123')
-[Environment]::SetEnvironmentVariable('CS_ACCESS_TOKEN', 'token')
-
-& '$codeSceneAnalysisScriptPath' -CoveragePath '$coveragePath'
-"@
-
-        $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
-
-        $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)
-        $uploadLog = Get-Content -LiteralPath $uploadLogPath -Raw
-        $uploadLog | Should -BeLike "upload --format jacoco --metric line-coverage $coveragePath*"
-        $uploadLog | Should -Match 'upload --format jacoco --metric branch-coverage'
-    }
+        $workingDirectory = $null
+        $invocation = "-CoveragePath '$coveragePath'"
+        if ($Mode -eq 'Discovered') {
+            New-Item -ItemType Directory -Path $artifactsDir -Force | Out-Null
+            $coveragePath = Join-Path $artifactsDir 'coverage.xml'
+            $workingDirectory = $TestDrive
+            $invocation = '-UploadCoverage'
+        }
 
-    It 'uploads coverage from the artifacts folder when UploadCoverage is requested without CoveragePath' {
-        $artifactsDir = Join-Path $TestDrive 'artifacts'
-        $coveragePath = Join-Path $artifactsDir 'coverage.xml'
-        $uploadLogPath = Join-Path $TestDrive 'cs-coverage-upload-discovered.txt'
-        New-Item -ItemType Directory -Path $artifactsDir -Force | Out-Null
+        $uploadLogPath = Join-Path $TestDrive $UploadLogName
         Set-Content -LiteralPath $coveragePath -Value '<report><counter type="BRANCH" missed="1" covered="1" /></report>' -Encoding utf8
 
-        $runnerContent = @"
-function cs-coverage {
-    param([Parameter(ValueFromRemainingArguments = `$true)][string[]]`$ArgumentList)
-
-    Add-Content -LiteralPath '$uploadLogPath' -Value (`$ArgumentList -join ' ') -Encoding utf8
-    `$global:LASTEXITCODE = 0
-}
-
-[Environment]::SetEnvironmentVariable('CS_URL', 'https://codescene.example.test')
-[Environment]::SetEnvironmentVariable('CS_PROJECT_ID', '123')
-[Environment]::SetEnvironmentVariable('CS_ACCESS_TOKEN', 'token')
-Set-Location '$TestDrive'
-
-& '$codeSceneAnalysisScriptPath' -UploadCoverage
-"@
-
+        $runnerContent = New-CodeSceneCoverageUploadRunnerContent -Config ([pscustomobject]@{
+            CoveragePath = $coveragePath
+            Invocation = $invocation
+            UploadLogPath = $uploadLogPath
+            WorkingDirectory = $workingDirectory
+        })
         $result = Invoke-CodeSceneAnalysisTestScript -RunnerContent $runnerContent
 
         $result.ExitCode | Should -Be 0 -Because ($result.Output -join [Environment]::NewLine)

tests/private/build/AssertNovaPublicFunctionFileLayout.TestSupport.ps1

@@ -0,0 +1,7 @@
+function Stop-NovaOperation {
+    param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
+    $exception = [System.Exception]::new($Message)
+    $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
+    throw $record
+}
+function Get-FunctionNameFromFile {param($filePath)}

tests/private/build/AssertNovaPublicFunctionFileLayout.Tests.ps1

@@ -2,13 +2,7 @@ BeforeAll {
     $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
     . (Join-Path $projectRoot 'src/private/build/AssertNovaPublicFunctionFileLayout.ps1')
 
-    function Stop-NovaOperation {
-        param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
-        $exception = [System.Exception]::new($Message)
-        $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
-        throw $record
-    }
-    function Get-FunctionNameFromFile {param($filePath)}
+    . (Join-Path $PSScriptRoot 'AssertNovaPublicFunctionFileLayout.TestSupport.ps1')
 }
 
 Describe 'Get-NovaPublicFunctionFileList' {

tests/private/build/BuildHelp.TestSupport.ps1

@@ -0,0 +1,11 @@
+function Stop-NovaOperation {
+    param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
+    $exception = [System.Exception]::new($Message)
+    $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
+    throw $record
+}
+function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
+function Get-NovaHelpLocale {param($HelpMarkdownFiles); return 'en-US'}
+function Measure-PlatyPSMarkdown {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input) process {}}
+function Import-MarkdownCommandHelp {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input, $Path) process {}}
+function Export-MamlCommandHelp {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input, $OutputFolder) process {}}

tests/private/build/BuildHelp.Tests.ps1

@@ -2,17 +2,7 @@ BeforeAll {
     $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
     . (Join-Path $projectRoot 'src/private/build/BuildHelp.ps1')
 
-    function Stop-NovaOperation {
-        param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
-        $exception = [System.Exception]::new($Message)
-        $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
-        throw $record
-    }
-    function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
-    function Get-NovaHelpLocale {param($HelpMarkdownFiles); return 'en-US'}
-    function Measure-PlatyPSMarkdown {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input) process {}}
-    function Import-MarkdownCommandHelp {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input, $Path) process {}}
-    function Export-MamlCommandHelp {[CmdletBinding()] param([Parameter(ValueFromPipeline)]$Input, $OutputFolder) process {}}
+    . (Join-Path $PSScriptRoot 'BuildHelp.TestSupport.ps1')
 }
 
 Describe 'Get-NovaHelpDocsDir' {
@@ -141,33 +131,22 @@ Describe 'Build-Help' {
         Assert-MockCalled Assert-NovaPlatyPSAvailable -Times 0
     }
 
-    It 'returns when no PlatyPS context is found' {
-        $tmp = Join-Path ([IO.Path]::GetTempPath()) ([guid]::NewGuid())
-        New-Item -ItemType Directory -Path $tmp | Out-Null
-        Set-Content -Path (Join-Path $tmp 'X.md') -Value 'help'
-        try {
-            Mock Get-NovaBuildProjectInfo { [pscustomobject]@{DocsDir='/x'; ProjectName='Y'; OutputModuleDir='/o'} }
-            Mock Get-NovaHelpMarkdownItem { @(Get-Item (Join-Path $tmp 'X.md')) }
-            Mock Assert-NovaPlatyPSAvailable {}
-            Mock Get-NovaHelpBuildContext { $null }
-            Mock Export-NovaGeneratedHelp {}
-            Build-Help -ProjectInfo ([pscustomobject]@{})
-            Assert-MockCalled Export-NovaGeneratedHelp -Times 0
-        } finally { Remove-Item $tmp -Recurse -Force -ErrorAction SilentlyContinue }
-    }
-
-    It 'exports help when PlatyPS context is found' {
+    It 'handles PlatyPS help export when context is <Name>' -ForEach @(
+        @{ Name = 'missing'; HelpContext = $null; ExpectedExportCalls = 0 }
+        @{ Name = 'available'; HelpContext = [pscustomobject]@{HelpMarkdownFiles=@(); CommandHelpFiles=@(); Locale='en-US'}; ExpectedExportCalls = 1 }
+    ) {
         $tmp = Join-Path ([IO.Path]::GetTempPath()) ([guid]::NewGuid())
         New-Item -ItemType Directory -Path $tmp | Out-Null
         Set-Content -Path (Join-Path $tmp 'X.md') -Value 'help'
         try {
             Mock Get-NovaBuildProjectInfo { [pscustomobject]@{DocsDir='/x'; ProjectName='Y'; OutputModuleDir='/o'} }
             Mock Get-NovaHelpMarkdownItem { @(Get-Item (Join-Path $tmp 'X.md')) }
             Mock Assert-NovaPlatyPSAvailable {}
-            Mock Get-NovaHelpBuildContext { [pscustomobject]@{HelpMarkdownFiles=@(); CommandHelpFiles=@(); Locale='en-US'} }
+            $script:buildHelpContext = $HelpContext
+            Mock Get-NovaHelpBuildContext { $script:buildHelpContext }
             Mock Export-NovaGeneratedHelp {}
             Build-Help -ProjectInfo ([pscustomobject]@{})
-            Assert-MockCalled Export-NovaGeneratedHelp -Times 1
+            Assert-MockCalled Export-NovaGeneratedHelp -Times $ExpectedExportCalls
         } finally { Remove-Item $tmp -Recurse -Force -ErrorAction SilentlyContinue }
     }
 }

tests/private/build/BuildManifest.TestSupport.ps1

@@ -0,0 +1,10 @@
+function Stop-NovaOperation {
+    param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
+    $exception = [System.Exception]::new($Message)
+    $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
+    throw $record
+}
+function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
+function Get-FunctionNameFromFile {param($filePath); return @('Foo')}
+function Get-AliasInFunctionFromFile {param($filePath); return @()}
+function Assert-ManifestSchema {param($Manifest, $AllowedParameter)}

tests/private/build/BuildManifest.Tests.ps1

@@ -2,16 +2,7 @@ BeforeAll {
     $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
     . (Join-Path $projectRoot 'src/private/build/BuildManifest.ps1')
 
-    function Stop-NovaOperation {
-        param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
-        $exception = [System.Exception]::new($Message)
-        $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
-        throw $record
-    }
-    function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
-    function Get-FunctionNameFromFile {param($filePath); return @('Foo')}
-    function Get-AliasInFunctionFromFile {param($filePath); return @()}
-    function Assert-ManifestSchema {param($Manifest, $AllowedParameter)}
+    . (Join-Path $PSScriptRoot 'BuildManifest.TestSupport.ps1')
 }
 
 Describe 'Build-Manifest' {

tests/private/build/BuildModule.TestSupport.ps1

@@ -0,0 +1,12 @@
+function Stop-NovaOperation {
+    param([string]$Message, [string]$ErrorId, [System.Management.Automation.ErrorCategory]$Category, $TargetObject)
+    $exception = [System.Exception]::new($Message)
+    $record = [System.Management.Automation.ErrorRecord]::new($exception, $ErrorId, $Category, $TargetObject)
+    throw $record
+}
+function Get-NovaBuildProjectInfo {param($ProjectInfo); return $ProjectInfo}
+function Test-ProjectSchema {param([string]$Schema); return $true}
+function Add-ProjectPreambleToModuleBuilder {param($Builder, $ProjectInfo)}
+function Get-ProjectScriptFile {param($ProjectInfo); return @()}
+function Add-ScriptFileContentToModuleBuilder {param($Builder, $ProjectInfo, $File)}
+function Invoke-NovaBuild {} # so (Get-Command Invoke-NovaBuild).Version is resolvable