fix: close remaining new-code coverage gaps

Author: stiwicourage

tests/private/cli/ConfirmNovaCliAction.Tests.ps1

@@ -43,6 +43,14 @@ Describe 'Invoke-NovaCliNativeConsoleReadKey' {
         $result = Invoke-NovaCliNativeConsoleReadKey -Reader $reader
         $result.KeyChar | Should -Be 'Q'
     }
+    It 'uses the default reader when one is not provided' {
+        Mock Get-NovaCliNativeConsoleReadKeyReader { { [pscustomobject]@{KeyChar = [char]'R'} } }
+
+        $result = Invoke-NovaCliNativeConsoleReadKey
+
+        $result.KeyChar | Should -Be 'R'
+        Assert-MockCalled Get-NovaCliNativeConsoleReadKeyReader -Times 1 -Exactly
+    }
 }
 
 Describe 'Invoke-NovaCliConsoleReadKey' {

tests/private/quality/InvokeNovaTestWorkflow.Tests.ps1

@@ -90,6 +90,37 @@ Describe 'Invoke-NovaTestWorkflow' {
         $workflowContext.PesterConfig.TestResult.OutputPath | Should -Be '/tmp/nova-project/artifacts/TestResults.xml'
     }
 
+    It 'falls back to CodeCoverage as the target object when the workflow context has no test result path' {
+        $workflowContext = [pscustomobject]@{
+            ProjectInfo = [pscustomobject]@{
+                Pester = [ordered]@{CodeCoverage = [ordered]@{Enabled = $true; CoveragePercentTarget = 90}}
+            }
+        }
+
+        $assertion = Get-NovaCoverageTargetAssertionScriptBlock -WorkflowContext $workflowContext
+
+        $thrown = $null
+        try {
+            & $assertion -WorkflowContext $workflowContext -TestResult ([pscustomobject]@{Result = 'Passed'})
+        } catch {
+            $thrown = $_
+        }
+
+        $thrown | Should -Not -BeNullOrEmpty
+        $thrown.FullyQualifiedErrorId | Should -Be 'Nova.Workflow.CodeCoveragePercentMissing'
+        $thrown.TargetObject | Should -Be 'CodeCoverage'
+    }
+
+    It 'treats a blank configured coverage target as not configured' {
+        $workflowContext = [pscustomobject]@{
+            ProjectInfo = [pscustomobject]@{
+                Pester = [ordered]@{CodeCoverage = [ordered]@{Enabled = $true; CoveragePercentTarget = ''}}
+            }
+        }
+
+        Get-NovaConfiguredCoveragePercentTarget -WorkflowContext $workflowContext | Should -BeNullOrEmpty
+    }
+
     It 'suppresses global progress output around the Pester run and restores the previous preference' {
         $workflowContext = [pscustomobject]@{
             ProjectInfo = [pscustomobject]@{Pester = [ordered]@{}}

tests/private/quality/duplicates/AssertBuiltModuleHasNoDuplicateFunctionNames.Tests.ps1

@@ -70,4 +70,21 @@ function Get-Alpha {
             $_.Exception.Message | Should -Match 'src/private/GetAlphaOverride\.ps1'
         }
     }
+
+    It 'throws a parse-specific error when the built module cannot be parsed' {
+        $projectInfo = New-DuplicateValidationProjectInfo -ProjectRoot $script:projectRoot -ModuleContent @'
+function Get-Alpha {
+'@ -SourceFileMap @{
+            'src/public/GetAlpha.ps1' = 'function Get-Alpha {}'
+        }
+
+        try {
+            Assert-BuiltModuleHasNoDuplicateFunctionName -ProjectInfo $projectInfo
+            throw 'Expected parse validation to fail.'
+        } catch {
+            $_.FullyQualifiedErrorId | Should -Be 'Nova.Configuration.BuiltModuleDuplicateValidationParseFailed'
+            $_.Exception.Message | Should -Match 'contains parse errors'
+            $_.Exception.Message | Should -Match 'NovaModuleTools\.psm1'
+        }
+    }
 }

tests/private/update/InvokeNovaModuleUpdateNotification.Tests.ps1

@@ -50,4 +50,32 @@ Describe 'Invoke-NovaModuleUpdateNotification' {
         {Invoke-NovaModuleUpdateNotification} | Should -Not -Throw
         Assert-MockCalled Write-NovaAvailableModuleUpdateWarning -Times 0
     }
+
+    It 'warns about a newer prerelease when prerelease notifications are enabled and a prerelease update is available' {
+        Mock Read-NovaUpdateNotificationPreference {[pscustomobject]@{PrereleaseNotificationsEnabled = $true}}
+        Mock Get-NovaInstalledModuleVersionInfo {
+            [pscustomobject]@{
+                ModuleName = 'NovaModuleTools'
+                Version = '1.0.0'
+                SemanticVersion = [semver]'1.0.0'
+                IsPrerelease = $false
+            }
+        }
+        Mock Invoke-NovaModuleUpdateLookup {
+            [pscustomobject]@{
+                Stable = [pscustomobject]@{Version = '1.1.0'}
+                Prerelease = [pscustomobject]@{Version = '1.2.0-preview'}
+            }
+        }
+        Mock Get-NovaAvailableSemanticVersion {[semver]'1.1.0'}
+        Mock Test-NovaStableUpdateAvailable {$false}
+        Mock Test-NovaPrereleaseUpdateAvailable {$true}
+        Mock Write-NovaAvailableModuleUpdateWarning {}
+
+        Invoke-NovaModuleUpdateNotification
+
+        Assert-MockCalled Write-NovaAvailableModuleUpdateWarning -Times 1 -Exactly -ParameterFilter {
+            $CurrentVersion -eq '1.0.0' -and $AvailableVersion -eq '1.2.0-preview' -and $Prerelease
+        }
+    }
 }