feat(#202): mirror build and shared helper tests

- Closes Migrate build and shared domain tests (3)
Fixes #202

Author: stiwicourage

CHANGELOG.md

@@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 - `Test-NovaBuild` and `% nova test` now enforce `Pester.CodeCoverage.CoveragePercentTarget` from `project.json` when `CodeCoverage.Enabled` is `true`, failing the test run when measured coverage drops below the configured target.
 - Added a non-blocking `scripts/build/Get-TestMirrorStatus.ps1` helper that reports `src/**/*.ps1` files without a matching mirrored test file under `tests/`, to support the migration to the source-mirrored, dot-source-first test layout.
 - Added mirrored, dot-source-first Pester test files for scaffold and update private helpers (`src/private/scaffold/*.ps1` and `src/private/update/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/scaffold/` or `tests/private/update/` instead of being covered only through broad legacy coverage files.
+- Added mirrored, dot-source-first Pester test files for build and shared private helpers (`src/private/build/*.ps1`, `src/private/build/manifest/*.ps1`, and `src/private/shared/*.ps1`), so each unit-level helper now has a focused test file under `tests/private/build/`, `tests/private/build/manifest/`, or `tests/private/shared/` instead of being covered only through broad legacy coverage files.
 
 
 ### Changed

tests/private/build/AddProjectPreambleToModuleBuilder.Tests.ps1

@@ -0,0 +1,27 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/AddProjectPreambleToModuleBuilder.ps1')
+}
+
+Describe 'Add-ProjectPreambleToModuleBuilder' {
+    It 'appends each preamble line followed by a blank separator' {
+        $builder = [System.Text.StringBuilder]::new()
+        $projectInfo = [pscustomobject]@{Preamble = @('Set-StrictMode -Version Latest', '$ErrorActionPreference = ''Stop''')}
+
+        Add-ProjectPreambleToModuleBuilder -Builder $builder -ProjectInfo $projectInfo
+
+        $text = $builder.ToString()
+        $text | Should -Match 'Set-StrictMode -Version Latest'
+        $text | Should -Match 'ErrorActionPreference'
+        ($text -split "`r?`n").Count | Should -BeGreaterOrEqual 4
+    }
+
+    It 'returns without writing when preamble is empty' {
+        $builder = [System.Text.StringBuilder]::new()
+        $projectInfo = [pscustomobject]@{Preamble = @()}
+
+        Add-ProjectPreambleToModuleBuilder -Builder $builder -ProjectInfo $projectInfo
+
+        $builder.Length | Should -Be 0
+    }
+}

tests/private/build/AddScriptFileContentToModuleBuilder.Tests.ps1

@@ -0,0 +1,38 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/AddScriptFileContentToModuleBuilder.ps1')
+
+    function Get-NormalizedRelativePath {param([string]$Root, [string]$FullName)}
+}
+
+Describe 'Add-ScriptFileContentToModuleBuilder' {
+    BeforeEach {
+        $script:tempFile = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), [Guid]::NewGuid().ToString('N') + '.ps1')
+        Set-Content -LiteralPath $script:tempFile -Value 'function Get-Foo {}'
+        $script:fileInfo = Get-Item -LiteralPath $script:tempFile
+        $script:builder = [System.Text.StringBuilder]::new()
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:tempFile -ErrorAction SilentlyContinue
+    }
+
+    It 'prepends a source comment when SetSourcePath is enabled' {
+        Mock Get-NormalizedRelativePath {return 'src/public/Get-Foo.ps1'}
+        $info = [pscustomobject]@{SetSourcePath = $true; ProjectRoot = '/proj'}
+
+        Add-ScriptFileContentToModuleBuilder -Builder $script:builder -ProjectInfo $info -File $script:fileInfo
+
+        $script:builder.ToString() | Should -Match '# Source: src/public/Get-Foo\.ps1'
+        $script:builder.ToString() | Should -Match 'function Get-Foo'
+    }
+
+    It 'skips the source comment when SetSourcePath is disabled' {
+        $info = [pscustomobject]@{SetSourcePath = $false; ProjectRoot = '/proj'}
+
+        Add-ScriptFileContentToModuleBuilder -Builder $script:builder -ProjectInfo $info -File $script:fileInfo
+
+        $script:builder.ToString() | Should -Not -Match '# Source:'
+        $script:builder.ToString() | Should -Match 'function Get-Foo'
+    }
+}

tests/private/build/CopyProjectResource.Tests.ps1

@@ -0,0 +1,67 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/CopyProjectResource.ps1')
+
+    function Get-NovaBuildProjectInfo {param([pscustomobject]$ProjectInfo)}
+    function Get-ProjectResourceFolderPath {param([string]$ProjectRoot)}
+    function Get-ProjectResourceItemList {param([string]$ResourceFolder)}
+    function Copy-ProjectResourceContentToModuleRoot {param([System.IO.FileSystemInfo[]]$ItemList, [string]$OutputModuleDir)}
+    function Copy-ProjectResourceFolderToOutputModuleDir {param([string]$ResourceFolder, [string]$OutputModuleDir)}
+}
+
+Describe 'Copy-ProjectResource' {
+    BeforeEach {
+        $script:root = Join-Path ([System.IO.Path]::GetTempPath()) ([Guid]::NewGuid().ToString('N'))
+        $script:resourceFolder = Join-Path $script:root 'resources'
+        $null = New-Item -ItemType Directory -Path $script:resourceFolder -Force
+        Set-Content -LiteralPath (Join-Path $script:resourceFolder 'item.txt') -Value 'x'
+        $script:projectData = [pscustomobject]@{
+            ProjectRoot = $script:root
+            OutputModuleDir = (Join-Path $script:root 'dist')
+            CopyResourcesToModuleRoot = $false
+        }
+        Mock Get-NovaBuildProjectInfo {return $script:projectData}
+        Mock Get-ProjectResourceFolderPath {return $script:resourceFolder}
+        Mock Get-ProjectResourceItemList {return @(Get-ChildItem -LiteralPath $script:resourceFolder)}
+        Mock Copy-ProjectResourceContentToModuleRoot {}
+        Mock Copy-ProjectResourceFolderToOutputModuleDir {}
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:root -Recurse -Force -ErrorAction SilentlyContinue
+    }
+
+    It 'returns silently when the resource folder does not exist' {
+        Mock Get-ProjectResourceFolderPath {return (Join-Path $script:root 'missing')}
+
+        Copy-ProjectResource
+
+        Assert-MockCalled Copy-ProjectResourceContentToModuleRoot -Times 0
+        Assert-MockCalled Copy-ProjectResourceFolderToOutputModuleDir -Times 0
+    }
+
+    It 'returns silently when the resource folder is empty' {
+        Mock Get-ProjectResourceItemList {return @()}
+
+        Copy-ProjectResource
+
+        Assert-MockCalled Copy-ProjectResourceContentToModuleRoot -Times 0
+        Assert-MockCalled Copy-ProjectResourceFolderToOutputModuleDir -Times 0
+    }
+
+    It 'flattens resources when CopyResourcesToModuleRoot is true' {
+        $script:projectData.CopyResourcesToModuleRoot = $true
+
+        Copy-ProjectResource
+
+        Assert-MockCalled Copy-ProjectResourceContentToModuleRoot -Times 1
+        Assert-MockCalled Copy-ProjectResourceFolderToOutputModuleDir -Times 0
+    }
+
+    It 'copies the resource folder when CopyResourcesToModuleRoot is false' {
+        Copy-ProjectResource
+
+        Assert-MockCalled Copy-ProjectResourceFolderToOutputModuleDir -Times 1
+        Assert-MockCalled Copy-ProjectResourceContentToModuleRoot -Times 0
+    }
+}

tests/private/build/CopyProjectResourceContentToModuleRoot.Tests.ps1

@@ -0,0 +1,30 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/CopyProjectResourceContentToModuleRoot.ps1')
+}
+
+Describe 'Copy-ProjectResourceContentToModuleRoot' {
+    BeforeEach {
+        $script:root = Join-Path ([System.IO.Path]::GetTempPath()) ([Guid]::NewGuid().ToString('N'))
+        $script:source = Join-Path $script:root 'resources'
+        $script:target = Join-Path $script:root 'dist'
+        $null = New-Item -ItemType Directory -Path $script:source -Force
+        $null = New-Item -ItemType Directory -Path $script:target -Force
+        Set-Content -LiteralPath (Join-Path $script:source 'a.txt') -Value 'A'
+        $null = New-Item -ItemType Directory -Path (Join-Path $script:source 'sub') -Force
+        Set-Content -LiteralPath (Join-Path $script:source 'sub/b.txt') -Value 'B'
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:root -Recurse -Force -ErrorAction SilentlyContinue
+    }
+
+    It 'copies each item directly into the output module directory' {
+        $items = Get-ChildItem -Path $script:source
+
+        Copy-ProjectResourceContentToModuleRoot -ItemList $items -OutputModuleDir $script:target
+
+        Test-Path -LiteralPath (Join-Path $script:target 'a.txt') | Should -BeTrue
+        Test-Path -LiteralPath (Join-Path $script:target 'sub/b.txt') | Should -BeTrue
+    }
+}

tests/private/build/CopyProjectResourceFolderToOutputModuleDir.Tests.ps1

@@ -0,0 +1,26 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/CopyProjectResourceFolderToOutputModuleDir.ps1')
+}
+
+Describe 'Copy-ProjectResourceFolderToOutputModuleDir' {
+    BeforeEach {
+        $script:root = Join-Path ([System.IO.Path]::GetTempPath()) ([Guid]::NewGuid().ToString('N'))
+        $script:source = Join-Path $script:root 'resources'
+        $script:target = Join-Path $script:root 'dist'
+        $null = New-Item -ItemType Directory -Path $script:source -Force
+        $null = New-Item -ItemType Directory -Path $script:target -Force
+        Set-Content -LiteralPath (Join-Path $script:source 'file.txt') -Value 'hello'
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:root -Recurse -Force -ErrorAction SilentlyContinue
+    }
+
+    It 'recursively copies the resource folder into the output module directory' {
+        Copy-ProjectResourceFolderToOutputModuleDir -ResourceFolder $script:source -OutputModuleDir $script:target
+
+        $copied = Join-Path $script:target 'resources/file.txt'
+        Test-Path -LiteralPath $copied | Should -BeTrue
+    }
+}

tests/private/build/Get-ProjectPreamble.Tests.ps1

@@ -0,0 +1,40 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/Get-ProjectPreamble.ps1')
+
+    function Get-ProjectJsonValueTypeName {param($Value)}
+    function Format-ProjectJsonValue {param($Value)}
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject)
+        throw $Message
+    }
+}
+
+Describe 'Get-ProjectPreamble' {
+    It 'returns an empty array when Preamble is not configured' {
+        $result = Get-ProjectPreamble -ProjectData @{}
+
+        @($result).Count | Should -Be 0
+    }
+
+    It 'returns the configured preamble string array' {
+        $result = Get-ProjectPreamble -ProjectData @{Preamble = @('a', 'b')}
+
+        $result.Count | Should -Be 2
+        $result[0] | Should -Be 'a'
+        $result[1] | Should -Be 'b'
+    }
+
+    It 'throws when Preamble is not an array' {
+        Mock Get-ProjectJsonValueTypeName {return 'String'}
+        Mock Format-ProjectJsonValue {return '"x"'}
+
+        {Get-ProjectPreamble -ProjectData @{Preamble = 'oops'}} | Should -Throw
+    }
+
+    It 'throws when a Preamble entry is not a string' {
+        Mock Get-ProjectJsonValueTypeName {return 'Int32'}
+        Mock Format-ProjectJsonValue {return '7'}
+
+        {Get-ProjectPreamble -ProjectData @{Preamble = @('a', 7)}} | Should -Throw
+    }
+}

tests/private/build/GetNovaBuildProjectInfo.Tests.ps1

@@ -0,0 +1,23 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/GetNovaBuildProjectInfo.ps1')
+
+    function Get-NovaProjectInfo {param([string]$Path)}
+}
+
+Describe 'Get-NovaBuildProjectInfo' {
+    It 'returns the provided ProjectInfo unchanged' {
+        $info = [pscustomobject]@{ProjectRoot = '/tmp'}
+
+        Get-NovaBuildProjectInfo -ProjectInfo $info | Should -Be $info
+    }
+
+    It 'falls back to Get-NovaProjectInfo when ProjectInfo is null' {
+        Mock Get-NovaProjectInfo {return [pscustomobject]@{ProjectRoot = '/from-fallback'}}
+
+        $result = Get-NovaBuildProjectInfo -ProjectInfo $null
+
+        $result.ProjectRoot | Should -Be '/from-fallback'
+        Assert-MockCalled Get-NovaProjectInfo -Times 1
+    }
+}

tests/private/build/GetNovaBuildWorkflowContext.Tests.ps1

@@ -0,0 +1,33 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/GetNovaBuildWorkflowContext.ps1')
+
+    function Get-NovaBuildProjectInfo {param([pscustomobject]$ProjectInfo)}
+}
+
+Describe 'Get-NovaBuildWorkflowContext' {
+    BeforeEach {
+        $script:projectInfo = [pscustomobject]@{
+            ProjectRoot = '/proj'
+            OutputModuleDir = '/proj/dist/Mod'
+        }
+        Mock Get-NovaBuildProjectInfo {return $script:projectInfo}
+    }
+
+    It 'returns a workflow context populated from the resolved project info' {
+        $ctx = Get-NovaBuildWorkflowContext
+
+        $ctx.ProjectInfo | Should -Be $script:projectInfo
+        $ctx.Target | Should -Be '/proj/dist/Mod'
+        $ctx.Operation | Should -Be 'Build Nova module output'
+        $ctx.ContinuousIntegrationRequested | Should -BeFalse
+        $ctx.OverrideWarningRequested | Should -BeFalse
+    }
+
+    It 'reflects the CI and override switches as booleans' {
+        $ctx = Get-NovaBuildWorkflowContext -ContinuousIntegrationRequested -OverrideWarningRequested
+
+        $ctx.ContinuousIntegrationRequested | Should -BeTrue
+        $ctx.OverrideWarningRequested | Should -BeTrue
+    }
+}

tests/private/build/GetNovaHelpLocale.Tests.ps1

@@ -0,0 +1,44 @@
+BeforeAll {
+    $projectRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSScriptRoot))
+    . (Join-Path $projectRoot 'src/private/build/GetNovaHelpLocale.ps1')
+
+    function Stop-NovaOperation {param([string]$Message, [string]$ErrorId, $Category, $TargetObject)
+        throw $Message
+    }
+}
+
+Describe 'Get-NovaHelpLocale' {
+    BeforeEach {
+        $script:root = Join-Path ([System.IO.Path]::GetTempPath()) ([Guid]::NewGuid().ToString('N'))
+        $null = New-Item -ItemType Directory -Path $script:root -Force
+    }
+
+    AfterEach {
+        Remove-Item -LiteralPath $script:root -Recurse -Force -ErrorAction SilentlyContinue
+    }
+
+    It 'returns the locale parsed from the help file' {
+        $file = Join-Path $script:root 'a.md'
+        Set-Content -LiteralPath $file -Value @('Locale: en-US', '')
+        $info = Get-Item -LiteralPath $file
+
+        Get-NovaHelpLocale -HelpMarkdownFiles @($info) | Should -Be 'en-US'
+    }
+
+    It 'returns en-US default when no locale line is found' {
+        $file = Join-Path $script:root 'a.md'
+        Set-Content -LiteralPath $file -Value 'no metadata here'
+        $info = Get-Item -LiteralPath $file
+
+        Get-NovaHelpLocale -HelpMarkdownFiles @($info) | Should -Be 'en-US'
+    }
+
+    It 'throws when files declare conflicting locales' {
+        $a = Join-Path $script:root 'a.md'
+        $b = Join-Path $script:root 'b.md'
+        Set-Content -LiteralPath $a -Value 'Locale: en-US'
+        Set-Content -LiteralPath $b -Value 'Locale: da-DK'
+
+        {Get-NovaHelpLocale -HelpMarkdownFiles @((Get-Item $a), (Get-Item $b))} | Should -Throw
+    }
+}