fix: write normalized JaCoCo without BOM

Author: stiwicourage

scripts/build/ci/Repair-CodeSceneJaCoCoCoverage.ps1

@@ -43,7 +43,17 @@ function Repair-CodeSceneJaCoCoCoverageFile {
     $changed = (Repair-CodeSceneJaCoCoNodePathAttribute -Nodes $document.SelectNodes('//sourcefile[@name]') -AttributeName 'name') -or $changed
 
     if ($changed) {
-        $document.Save($Path)
+        $settings = New-Object System.Xml.XmlWriterSettings
+        $settings.Encoding = New-Object System.Text.UTF8Encoding($false)
+        $settings.Indent = $false
+        $settings.NewLineHandling = [System.Xml.NewLineHandling]::None
+        $writer = [System.Xml.XmlWriter]::Create($Path, $settings)
+        try {
+            $document.Save($writer)
+        } finally {
+            $writer.Dispose()
+        }
+
         Write-Host "Normalized JaCoCo sourcefile paths in '$Path' so package + sourcefile resolve to repo files."
     }
 }

tests/Repair-CodeSceneJaCoCoCoverage.Tests.ps1

@@ -51,6 +51,8 @@ Describe 'Repair-CodeSceneJaCoCoCoverage' {
         [xml]$rewritten = Get-Content -LiteralPath $coveragePath -Raw
         $rewritten.SelectSingleNode('//class[@sourcefilename]').GetAttribute('sourcefilename') | Should -Be 'Foo.ps1'
         $rewritten.SelectSingleNode('//sourcefile[@name]').GetAttribute('name') | Should -Be 'Foo.ps1'
+        [byte[]]$bytes = [System.IO.File]::ReadAllBytes($coveragePath)
+        $bytes[0] | Should -Be 60
     }
 
     It 'leaves already normalized filenames unchanged' {