feat(#259): update to Pester 6.0.0 and improve test assertions

- Added Get-NovaScaffoldModuleVersion function to retrieve module version.
- Updated Pester version requirements in project files and README.
- Refactored test assertions to use Should-Invoke for better clarity.

Author: stiwicourage

README.md

@@ -298,8 +298,8 @@ Notes:
 - if `project.json` sets `Pester.CodeCoverage.CoveragePercentTarget`, `Invoke-NovaTest` fails when the measured coverage percentage is lower than that configured target
 - this repository currently enables coverage with a `99` percent target; the template and packaged example
   `project.json` files ship the same JaCoCo configuration shape with `Enabled=false` and a `90` percent opt-in target
-- make sure `Pester 5.7.1` is available before running `Invoke-NovaTest` or `Test-NovaBuild`
-- the published `NovaModuleTools` manifest also declares `Pester 5.7.1`, so installed end-user workflows can still resolve that dependency automatically
+- make sure `Pester 6.0.0` or newer is available before running `Invoke-NovaTest` or `Test-NovaBuild`
+- the published `NovaModuleTools` manifest now declares `Pester 6.0.0`, so installed end-user workflows and repository validation align on the same supported dependency major version
 
 ### Create a package artifact
 
@@ -640,7 +640,7 @@ Responsibilities currently covered by the release pipeline include:
 - publishing to PowerShell Gallery
 - preparing the next prerelease version on `develop`
 
-The workflow now uses `KeepAChangelog` for changelog release moves, creates annotated git tags named directly from the release version, and bootstraps the local PSResourceGet repository store before calling `Publish-NovaModule`. The shared CI installer also installs `Pester 5.7.1` explicitly before it installs prerelease gallery modules so test workflows do not rely on transitive manifest dependency resolution.
+The workflow now uses `KeepAChangelog` for changelog release moves, creates annotated git tags named directly from the release version, and bootstraps the local PSResourceGet repository store before calling `Publish-NovaModule`. The shared CI installer also installs `Pester 6.0.0` explicitly before it installs prerelease gallery modules so test workflows do not rely on transitive manifest dependency resolution.
 
 ### Where NovaModuleTools cmdlets fit
 

project.json

@@ -14,7 +14,7 @@
     "RequiredModules": [
       {
         "ModuleName": "Pester",
-        "ModuleVersion": "5.7.1"
+        "ModuleVersion": "6.0.0"
       },
       {
         "ModuleName": "Microsoft.PowerShell.PlatyPS",

scripts/build/ci/Install-CiPowerShellModules.ps1

@@ -15,7 +15,7 @@ function Get-CiModuleInstallOption {
 
     if ($Name -eq 'Pester') {
         return [pscustomobject]@{
-            RequiredVersion = '5.7.1'
+            RequiredVersion = '6.0.0'
             AllowPrerelease = $false
         }
     }

src/private/quality/GetNovaPesterRuntimeMajorVersion.ps1

@@ -0,0 +1,18 @@
+function Get-NovaPesterRuntimeMajorVersion {
+    [CmdletBinding()]
+    param()
+
+    $invokePesterCommand = Get-Command -Name Invoke-Pester -ErrorAction SilentlyContinue
+    if ($null -ne $invokePesterCommand -and $null -ne $invokePesterCommand.Version) {
+        return [int]$invokePesterCommand.Version.Major
+    }
+
+    $pesterModule = Get-Module -Name Pester -ListAvailable |
+            Sort-Object Version -Descending |
+            Select-Object -First 1
+    if ($null -eq $pesterModule) {
+        return $null
+    }
+
+    return [int]$pesterModule.Version.Major
+}

src/private/quality/GetNovaTestWorkflowContext.ps1

@@ -16,7 +16,7 @@ function Assert-NovaPesterAvailable {
     param()
 
     if (-not (Get-Module -Name Pester -ListAvailable)) {
-        Stop-NovaOperation -Message 'The module Pester must be installed to run Nova tests. Install Pester 5.7.1 and try again.' -ErrorId 'Nova.Dependency.PesterDependencyMissing' -Category ResourceUnavailable -TargetObject 'Pester'
+        Stop-NovaOperation -Message 'The module Pester must be installed to run Nova tests. Install Pester 6.0.0 or newer and try again.' -ErrorId 'Nova.Dependency.PesterDependencyMissing' -Category ResourceUnavailable -TargetObject 'Pester'
     }
 }
 

src/private/quality/InvokeNovaPester.ps1

@@ -6,3 +6,4 @@ function Invoke-NovaPester {
 
     return Invoke-Pester -Configuration $Configuration
 }
+

src/private/quality/InvokeNovaTestWorkflow.ps1

@@ -9,6 +9,9 @@ function Invoke-NovaTestWorkflow {
     $whatIfEnabled = Test-NovaWhatIfWorkflowContext -WorkflowContext $WorkflowContext
     $testResult = $null
     $shouldRunWorkflow = Test-NovaTestWorkflowShouldRun -WorkflowContext $WorkflowContext -BoundParameters $PSBoundParameters -ShouldRun:$ShouldRun
+    $messageWriter = (Get-Command -Name Write-Message -CommandType Function -ErrorAction Stop).ScriptBlock
+    $propertyReader = (Get-Command -Name Get-NovaPropertyValue -CommandType Function -ErrorAction Stop).ScriptBlock
+    $coverageFormatter = (Get-Command -Name Format-NovaCoveragePercentValue -CommandType Function -ErrorAction Stop).ScriptBlock
 
     try {
         Invoke-NovaTestWorkflowBuildStep -WorkflowContext $WorkflowContext -Activity $progressActivity -WhatIfEnabled:$whatIfEnabled
@@ -28,7 +31,47 @@ function Invoke-NovaTestWorkflow {
         Write-Progress -Activity $progressActivity -Completed
     }
 
-    Write-NovaTestWorkflowResult -WorkflowContext $WorkflowContext -TestResult $testResult
+    & $messageWriter "Pester tests passed for $( $WorkflowContext.ProjectInfo.ProjectName )" -color Green
+    & $messageWriter "Results file: $( $WorkflowContext.TestResultPath )"
+
+    $pesterSettings = & $propertyReader -InputObject $WorkflowContext -Name 'PesterSettings'
+    if ($null -eq $pesterSettings) {
+        $projectInfo = & $propertyReader -InputObject $WorkflowContext -Name 'ProjectInfo'
+        $pesterSettings = & $propertyReader -InputObject $projectInfo -Name 'Pester'
+    }
+
+    $coveragePercentTarget = $null
+    $codeCoverageSettings = & $propertyReader -InputObject $pesterSettings -Name 'CodeCoverage'
+    if ($true -eq [bool](& $propertyReader -InputObject $codeCoverageSettings -Name 'Enabled')) {
+        $configuredCoveragePercentTarget = & $propertyReader -InputObject $codeCoverageSettings -Name 'CoveragePercentTarget'
+        if ($null -ne $configuredCoveragePercentTarget -and -not [string]::IsNullOrWhiteSpace([string]$configuredCoveragePercentTarget)) {
+            $coveragePercentTarget = [double]$configuredCoveragePercentTarget
+        }
+    }
+
+    $coverageMessage = $null
+    $codeCoverage = & $propertyReader -InputObject $testResult -Name 'CodeCoverage'
+    $coveragePercent = & $propertyReader -InputObject $codeCoverage -Name 'CoveragePercent'
+    if ($null -ne $coveragePercent -and -not [string]::IsNullOrWhiteSpace([string]$coveragePercent)) {
+        $formattedCoverage = & $coverageFormatter -Value ([double]$coveragePercent)
+        if ($null -eq $coveragePercentTarget) {
+            $coverageMessage = "Measured code coverage: $formattedCoverage%"
+        } else {
+            $formattedTarget = & $coverageFormatter -Value $coveragePercentTarget
+            $coverageMessage = "Measured code coverage: $formattedCoverage% (target: $formattedTarget%)"
+        }
+    }
+
+    if (-not [string]::IsNullOrWhiteSpace($coverageMessage)) {
+        & $messageWriter $coverageMessage
+    }
+
+    foreach ($line in @(
+        'Next step:'
+        'Publish-NovaModule -Local'
+    )) {
+        & $messageWriter $line
+    }
 }
 
 function Invoke-NovaTestWorkflowBuildStep {
@@ -93,28 +136,46 @@ function Invoke-NovaTestWorkflowExecution {
 
     $WorkflowContext.PesterConfig.TestResult.OutputPath = $WorkflowContext.TestResultPath
     $coverageTargetAssertion = Get-NovaCoverageTargetAssertionScriptBlock -WorkflowContext $WorkflowContext
-    $testProgressContext = [pscustomobject]@{
-        Activity = $Activity
-        StartPercentComplete = 70
-        EndPercentComplete = 94
-    }
-    $testResult = Invoke-NovaPesterWithSuppressedProgress -Configuration $WorkflowContext.PesterConfig -ProgressContext $testProgressContext
+    $testResult = Get-NovaTestWorkflowPesterResult -WorkflowContext $WorkflowContext -Activity $Activity
 
-    Invoke-NovaTestWorkflowStep -Activity $Activity -Status 'Writing the test result report' -PercentComplete 96 -Action {
+    Write-Progress -Activity $Activity -Status 'Writing the test result report' -PercentComplete 96
+    & {
         & $WorkflowContext.TestResultArtifactWriter.ScriptBlock -TestResult $testResult -OutputPath $WorkflowContext.TestResultPath -ReportWriter $WorkflowContext.TestResultReportWriter.ScriptBlock
     }
 
     if ($testResult.Result -ne 'Passed') {
         Stop-NovaOperation -Message (Get-NovaTestWorkflowFailureMessage -WorkflowContext $WorkflowContext) -ErrorId 'Nova.Workflow.TestRunFailed' -Category InvalidOperation -TargetObject $WorkflowContext.TestResultPath
     }
 
-    Invoke-NovaTestWorkflowStep -Activity $Activity -Status 'Checking the configured code coverage target' -PercentComplete 99 -Action {
+    Write-Progress -Activity $Activity -Status 'Checking the configured code coverage target' -PercentComplete 99
+    & {
         & $coverageTargetAssertion -WorkflowContext $WorkflowContext -TestResult $testResult
     }
 
     return $testResult
 }
 
+function Get-NovaTestWorkflowPesterResult {
+    [CmdletBinding()]
+    param(
+        [Parameter(Mandatory)][pscustomobject]$WorkflowContext,
+        [Parameter(Mandatory)][string]$Activity
+    )
+
+    if ((Get-NovaPesterRuntimeMajorVersion) -ge 6) {
+        return Invoke-NovaTestWorkflowStep -Activity $Activity -Status 'Running Pester tests' -PercentComplete 70 -Action {
+            Invoke-NovaPester -Configuration $WorkflowContext.PesterConfig
+        }
+    }
+
+    $testProgressContext = [pscustomobject]@{
+        Activity = $Activity
+        StartPercentComplete = 70
+        EndPercentComplete = 94
+    }
+    return Invoke-NovaPesterWithSuppressedProgress -Configuration $WorkflowContext.PesterConfig -ProgressContext $testProgressContext
+}
+
 function Invoke-NovaTestWorkflowStep {
     [CmdletBinding()]
     param(

src/private/scaffold/GetNovaScaffoldModuleVersion.ps1

@@ -0,0 +1,12 @@
+function Get-NovaScaffoldModuleVersion {
+    [CmdletBinding()]
+    param()
+
+    $module = $ExecutionContext.SessionState.Module
+    if ($null -eq $module) {
+        return $null
+    }
+
+    return $module.Version
+}
+

src/private/scaffold/WriteNovaModuleProjectJson.ps1

@@ -18,7 +18,7 @@ function Write-NovaModuleProjectJson {
         $jsonData.Manifest.GUID = (New-Guid).GUID
     }
 
-    $moduleVersion = $ExecutionContext.SessionState.Module.Version
+    $moduleVersion = Get-NovaScaffoldModuleVersion
     if ($null -ne $moduleVersion) {
         $majorVersion = $moduleVersion.Major
         $jsonData['$schema'] = "https://www.novamoduletools.com/schema/v$majorVersion/project.json"

src/private/scaffold/WriteNovaVsCodeSettings.ps1

@@ -5,7 +5,7 @@ function Write-NovaVsCodeSettings {
         [Parameter(Mandatory)][string]$ProjectRoot
     )
 
-    $moduleVersion = $ExecutionContext.SessionState.Module.Version
+    $moduleVersion = Get-NovaScaffoldModuleVersion
     if ($null -eq $moduleVersion) { return }
 
     $schemaUrl = "https://www.novamoduletools.com/schema/v$($moduleVersion.Major)/project.json"