#151 feat: default prerelease self-update confirmation to no

Author: stiwicourage

CHANGELOG.md

@@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Make prerelease self-update confirmation default to `No`.
+    - `Update-NovaModuleTool`, `Update-NovaModuleTools`, and `% nova update` now require an explicit `Y` before a
+      prerelease self-update continues, so pressing Enter cancels the update instead of accepting it.
+
 ### Deprecated
 
 ### Removed
@@ -358,4 +362,3 @@ Keep stable `Update-NovaModuleVersion` / `% nova bump` releases on the SemVer ma
 [0.0.6]: https://github.com/stiwicourage/NovaModuleTools/compare/Version_0.0.5...Version_0.0.6
 [0.0.5]: https://github.com/stiwicourage/NovaModuleTools/compare/Version_0.0.4...Version_0.0.5
 [0.0.4]: https://github.com/stiwicourage/NovaModuleTools/compare/Version_0.0.3...Version_0.0.4
-

README.md

@@ -110,7 +110,8 @@ Update notification preferences use one shared settings location:
 `Update-NovaModuleTool` (and its `Update-NovaModuleTools` alias), CLI:`% nova update` use that stored prerelease
 preference to decide whether prerelease self-updates are eligible. When prerelease self-updates are disabled,
 self-update stays on stable releases. When they are enabled, self-update may target a prerelease, but it asks for
-explicit confirmation before proceeding.
+explicit confirmation before proceeding and defaults that prerelease prompt to `No`, so pressing Enter cancels the
+update.
 
 
 Successful `Update-NovaModuleTool`, CLI:`% nova update`, and `Install-NovaCli` runs print the release notes link from

docs/NovaModuleTools/en-US/Get-NovaUpdateNotificationPreference.md

@@ -81,7 +81,8 @@ eligible.
 Use `Set-NovaUpdateNotificationPreference -EnablePrereleaseNotifications` to allow prerelease self-updates again.
 
 When prerelease notifications are enabled again, `Update-NovaModuleTool` / `Update-NovaModuleTools` may again select a
-prerelease target. Prerelease self-updates still require explicit confirmation before the update proceeds.
+prerelease target. Prerelease self-updates still require explicit confirmation before the update proceeds, and that
+confirmation defaults to `No` so pressing Enter cancels the update.
 
 ## RELATED LINKS
 

docs/NovaModuleTools/en-US/NovaModuleTools.md

@@ -62,7 +62,8 @@ Runs the project's Pester test workflow using settings from `project.json`.
 ### `PS> Update-NovaModuleTool`
 
 Updates the installed `NovaModuleTools` module by using the stored prerelease preference that also controls whether
-prerelease self-updates are eligible. The compatibility alias `Update-NovaModuleTools` is also available.
+prerelease self-updates are eligible. Prerelease confirmations default to `No`, so pressing Enter cancels the
+update. The compatibility alias `Update-NovaModuleTools` is also available.
 
 ### `PS> Initialize-NovaModule`
 

docs/NovaModuleTools/en-US/Update-NovaModuleTools.md

@@ -37,7 +37,8 @@ When prerelease notifications are disabled, `Update-NovaModuleTool` only conside
 `-AllowPrerelease` to the update flow.
 
 When prerelease notifications are enabled, `Update-NovaModuleTool` may target a prerelease. If the selected target is a
-prerelease, the command always asks for explicit confirmation before it proceeds.
+prerelease, the command always asks for explicit confirmation before it proceeds, and that prerelease confirmation
+defaults to `No` so pressing Enter cancels the update.
 
 Stable updates do not require prerelease confirmation.
 

docs/versioning-and-updates.html

@@ -281,7 +281,7 @@ <h3>What self-update does</h3>
                         <tr>
                             <td>Only prerelease update available and prerelease eligibility is enabled</td>
                             <td>Nova may target the prerelease, but it always asks for explicit confirmation before
-                                updating.
+                                updating, and that prompt defaults to No so pressing Enter cancels the update.
                             </td>
                         </tr>
                         <tr>

src/private/update/ConfirmNovaPrereleaseModuleUpdate.ps1

@@ -7,5 +7,5 @@ function Confirm-NovaPrereleaseModuleUpdate {
     )
 
     $prompt = Get-NovaPrereleaseModuleUpdateConfirmationPrompt -CurrentVersion $CurrentVersion -TargetVersion $TargetVersion
-    return $Cmdlet.ShouldContinue($prompt.Message, $prompt.Caption)
+    return (Read-AwesomeChoicePrompt -Ask $prompt -HostUi $Cmdlet.Host.UI) -eq 'Y'
 }

src/private/update/GetNovaPrereleaseModuleUpdateConfirmationPrompt.ps1

@@ -13,5 +13,10 @@ NovaModuleTools would update from $CurrentVersion to prerelease $TargetVersion.
 Prerelease updates may be less stable than released versions.
 Continue with the prerelease update?
 "@
+        Choice = [ordered]@{
+            Y = 'Yes'
+            N = 'No'
+        }
+        Default = 'N'
     }
 }

tests/UpdateNotification.Tests.ps1

@@ -732,33 +732,45 @@ NovaModuleTools would update from 1.2.3 to prerelease 1.3.0-preview1.
 Prerelease updates may be less stable than released versions.
 Continue with the prerelease update?
 "@
+            $prompt.Choice.Keys | Should -Be @('Y', 'N')
+            $prompt.Default | Should -Be 'N'
         }
     }
 
-    It 'Confirm-NovaPrereleaseModuleUpdate delegates the generated prompt to ShouldContinue and returns the decision' {
-        InModuleScope $script:moduleName {
-            $calls = [System.Collections.Generic.List[object]]::new()
-            $cmdlet = [pscustomobject]@{
-                Calls = $calls
-                ShouldContinueResult = $false
+    It 'Confirm-NovaPrereleaseModuleUpdate uses a choice prompt that defaults prerelease updates to No' -ForEach @(
+        @{ChoiceIndex = 1; Expected = $false}
+        @{ChoiceIndex = 0; Expected = $true}
+    ) {
+        InModuleScope $script:moduleName -Parameters @{TestCase = $_} {
+            param($TestCase)
+
+            $hostUi = [pscustomobject]@{
+                State = [ordered]@{
+                    ChoiceCalls = 0
+                    ChoiceLabels = @()
+                    DefaultChoiceIndex = $null
+                }
             }
-            $cmdlet | Add-Member -MemberType ScriptMethod -Name ShouldContinue -Value {
-                param($Message, $Caption)
+            $hostUi | Add-Member -MemberType ScriptMethod -Name PromptForChoice -Value {
+                param($Caption, $Message, $Choices, $DefaultChoiceIndex)
 
-                $this.Calls.Add([pscustomobject]@{
-                    Message = $Message
-                    Caption = $Caption
-                }) | Out-Null
-                return $this.ShouldContinueResult
+                $this.State.ChoiceCalls += 1
+                $this.State.ChoiceLabels = @($Choices | ForEach-Object Label)
+                $this.State.DefaultChoiceIndex = $DefaultChoiceIndex
+                return $TestCase.ChoiceIndex
+            }
+            $cmdlet = [pscustomobject]@{
+                Host = [pscustomobject]@{
+                    UI = $hostUi
+                }
             }
 
             $result = Confirm-NovaPrereleaseModuleUpdate -Cmdlet $cmdlet -CurrentVersion '1.2.3' -TargetVersion '2.0.0-preview2'
 
-            $result | Should -BeFalse
-            $calls.Count | Should -Be 1
-            $calls[0].Caption | Should -Be 'Confirm prerelease NovaModuleTools update'
-            $calls[0].Message | Should -Match '1.2.3'
-            $calls[0].Message | Should -Match '2.0.0-preview2'
+            $result | Should -Be $TestCase.Expected
+            $hostUi.State.ChoiceCalls | Should -Be 1
+            $hostUi.State.ChoiceLabels | Should -Be @('&Y', '&N')
+            $hostUi.State.DefaultChoiceIndex | Should -Be 1
         }
     }