Feature/133 100 code coverage

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -132,4 +132,3 @@ body:
           required: true
         - label: This is not a bug report or security vulnerability report.
           required: true
-

CHANGELOG.md

@@ -81,6 +81,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fix unsupported `nova` help invocations so they now return Nova's structured CLI validation error instead of a
+  PowerShell parameter-binding failure.
+- Keep manifest/package helper edge cases aligned with their intended behavior.
+    - Manifest settings resolution now accepts ordered dictionary metadata shapes in addition to plain hashtables.
+    - `New-NovaPackageArtifacts` now accepts an empty metadata list and returns an empty artifact result instead of
+      failing during parameter binding.
 - Centralize delivery configuration resolution so raw package upload, update notification settings, and PSGallery
   publishing now follow one explicit precedence model without surfacing configured secrets in error text.
     - Raw upload now resolves command overrides before named repository settings, then package defaults.

codecov.yml

@@ -5,4 +5,4 @@ coverage:
         target: auto
     patch:
       default:
-        target: 100%
+        target: 100%

docs/NovaModuleTools/en-US/Deploy-NovaPackage.md

@@ -377,4 +377,3 @@ If no upload target can be resolved, `Deploy-NovaPackage` fails fast with a clea
 - https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/New-NovaModulePackage.md
 - https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Invoke-NovaCli.md
 - https://github.com/stiwicourage/NovaModuleTools/blob/main/docs/NovaModuleTools/en-US/Publish-NovaModule.md
-

src/private/build/GetNovaBuildProjectInfo.ps1

@@ -10,4 +10,3 @@ function Get-NovaBuildProjectInfo {
 
     return Get-NovaProjectInfo
 }
-

src/private/build/GetNovaBuildWorkflowContext.ps1

@@ -14,4 +14,3 @@ function Get-NovaBuildWorkflowContext {
         Operation = 'Build Nova module output'
     }
 }
-

src/private/build/InvokeNovaBuildWorkflow.ps1

@@ -44,4 +44,3 @@ function Invoke-NovaBuildUpdateNotificationSafely {
         $null = $_
     }
 }
-

src/private/cli/AddNovaCliHeaderOption.ps1

@@ -24,4 +24,3 @@ function Add-NovaCliHeaderOption {
 
     $Options.Headers[$headerName] = $headerValue
 }
-

src/private/cli/AddNovaCliOptionValue.ps1

@@ -13,4 +13,3 @@ function Add-NovaCliOptionValue {
 
     $Options[$Name] = @($existingValue + $Value)
 }
-

src/private/cli/ConvertFromNovaBuildCliArgument.ps1

@@ -9,4 +9,3 @@ function ConvertFrom-NovaBuildCliArgument {
         '-i' = 'ContinuousIntegration'
     }
 }
-

src/private/cli/ConvertFromNovaBumpCliArgument.ps1

@@ -11,4 +11,3 @@ function ConvertFrom-NovaBumpCliArgument {
         '-i' = 'ContinuousIntegration'
     }
 }
-

src/private/cli/ConvertFromNovaCliArgument.ps1

@@ -73,4 +73,3 @@ function ConvertFrom-NovaPackageCliArgument {
 
     return ConvertFrom-NovaCliArgument -Arguments $Arguments -AllowedOptionNameList @('SkipTests')
 }
-

src/private/cli/ConvertFromNovaDeployCliArgument.ps1

@@ -49,5 +49,3 @@ function ConvertFrom-NovaDeployCliArgument {
 
     return $options
 }
-
-

src/private/cli/ConvertFromNovaTestCliArgument.ps1

@@ -9,4 +9,3 @@ function ConvertFrom-NovaTestCliArgument {
         '-b' = 'Build'
     }
 }
-

src/private/cli/FormatNovaCliCommandHelp.ps1

@@ -174,7 +174,3 @@ function Format-NovaCliCommandHelp {
 
     return Format-NovaCliShortCommandHelp -Definition $Definition
 }
-
-
-
-

src/private/cli/FormatNovaCliCommandResult.ps1

@@ -70,4 +70,3 @@ function Format-NovaCliCommandResult {
 
     return $Result
 }
-

src/private/cli/GetNovaCliCommandHelp.ps1

@@ -17,4 +17,3 @@ function Get-NovaCliCommandHelp {
     $definition = Get-NovaCliCommandHelpDefinition -Command $Command
     return Format-NovaCliCommandHelp -Definition $definition -View $View
 }
-

src/private/cli/GetNovaCliCommandHelpDefinition.ps1

@@ -39,4 +39,3 @@ function Get-NovaCliCommandHelpDefinition {
 
     return Import-PowerShellDataFile -Path (Get-NovaCliCommandHelpFilePath -Command $Command)
 }
-

src/private/cli/GetNovaCliHelpRequest.ps1

@@ -44,7 +44,7 @@ function Get-NovaCliRootHelpRequest {
         return Get-NovaCliResolvedHelpRequest -Command $Arguments[0] -View Long -TargetType Command
     }
 
-    Assert-NovaCliHelpUsageSupported -Tokens @('--help') + $Arguments
+    Assert-NovaCliHelpUsageSupported -Tokens (@('--help') + $Arguments)
 }
 
 function Get-NovaCliSubcommandHelpRequest {
@@ -63,7 +63,7 @@ function Get-NovaCliSubcommandHelpRequest {
     }
 
     if (@($Arguments | Where-Object {Test-NovaCliHelpToken -Argument $_}).Count -gt 0) {
-        Assert-NovaCliHelpUsageSupported -Tokens @($Command) + $Arguments
+        Assert-NovaCliHelpUsageSupported -Tokens (@($Command) + $Arguments)
     }
 
     return $null
@@ -83,5 +83,3 @@ function Get-NovaCliHelpRequest {
 
     return Get-NovaCliSubcommandHelpRequest -Command $normalizedCommand -Arguments $Arguments
 }
-
-

src/private/cli/GetNovaCliRequiredArgumentValue.ps1

@@ -13,4 +13,3 @@ function Get-NovaCliRequiredArgumentValue {
 
     return $Arguments[$Index.Value]
 }
-

src/private/cli/InvokeNovaCliDeployCommand.ps1

@@ -8,5 +8,3 @@ function Invoke-NovaCliDeployCommand {
     $options = ConvertFrom-NovaDeployCliArgument -Arguments $Arguments
     return Deploy-NovaPackage @options @ForwardedParameters
 }
-
-

src/private/cli/InvokeNovaCliInitCommand.ps1

@@ -13,4 +13,3 @@ function Invoke-NovaCliInitCommand {
     $options = ConvertFrom-NovaInitCliArgument -Arguments $Arguments
     return Initialize-NovaModule @options @ForwardedParameters
 }
-

src/private/cli/InvokeNovaCliNotificationCommand.ps1

@@ -20,4 +20,3 @@ function Invoke-NovaCliNotificationCommand {
         }
     }
 }
-

src/private/package/AddNovaZipFileEntry.ps1

@@ -17,4 +17,3 @@ function Add-NovaZipFileEntry {
         $entryStream.Dispose()
     }
 }
-

src/private/package/AddNovaZipTextEntry.ps1

@@ -15,4 +15,3 @@ function Add-NovaZipTextEntry {
         $streamWriter.Dispose()
     }
 }
-

src/private/package/AssertNovaPackageMetadata.ps1

@@ -15,4 +15,3 @@ function Assert-NovaPackageMetadata {
         Stop-NovaOperation -Message 'Missing package metadata value: Authors' -ErrorId 'Nova.Configuration.PackageMetadataValueMissing' -Category InvalidData -TargetObject 'Authors'
     }
 }
-

src/private/package/AssertNovaPackageOutputDirectoryCanBeCleared.ps1

@@ -16,4 +16,3 @@ function Assert-NovaPackageOutputDirectoryCanBeCleared {
         }
     }
 }
-

src/private/package/GetNovaManifestValue.ps1

@@ -16,4 +16,3 @@ function Get-NovaManifestValue {
 
     return $property.Value
 }
-

src/private/package/GetNovaPackageArtifactPatternInfo.ps1

@@ -20,4 +20,3 @@ function Get-NovaPackageArtifactPatternInfo {
         ExplicitPackageType = $explicitPackageType
     }
 }
-

src/private/package/GetNovaPackageArtifactSearchPattern.ps1

@@ -12,4 +12,3 @@ function Get-NovaPackageArtifactSearchPattern {
 
     return "$( $patternInfo.Pattern )$( Get-NovaPackageTypeExtension -PackageType $PackageType )"
 }
-

src/private/package/GetNovaPackageArtifactType.ps1

@@ -17,4 +17,3 @@ function Get-NovaPackageArtifactType {
         Stop-NovaOperation -Message $errorMessage -ErrorId 'Nova.Validation.UnsupportedPackageUploadFileType' -Category InvalidArgument -TargetObject $PackagePath
     }
 }
-

src/private/package/GetNovaPackageAuthorList.ps1

@@ -27,4 +27,3 @@ function Get-NovaPackageAuthorList {
             Select-Object -Unique
     )
 }
-

src/private/package/GetNovaPackageContentItemList.ps1

@@ -24,4 +24,3 @@ function Get-NovaPackageContentItemList {
     }
     )
 }
-

src/private/package/GetNovaPackageFileName.ps1

@@ -69,4 +69,3 @@ function ConvertTo-NovaLatestPackageFileName {
 
     return $PackageFileName
 }
-

src/private/package/GetNovaPackageMetadata.ps1

@@ -58,4 +58,3 @@ function Get-NovaPackageMetadata {
         ContentRoot = $contentRoot
     }
 }
-

src/private/package/GetNovaPackageMetadataElement.ps1

@@ -12,4 +12,3 @@ function Get-NovaPackageMetadataElement {
     $escapedValue = [System.Security.SecurityElement]::Escape($Value)
     return "    <$Name>$escapedValue</$Name>"
 }
-

src/private/package/GetNovaPackageOutputDirectory.ps1

@@ -17,4 +17,3 @@ function Get-NovaPackageOutputDirectory {
 
     return [System.IO.Path]::Join($ProjectInfo.ProjectRoot, $outputDirectory)
 }
-

src/private/package/GetNovaPackageRepository.ps1

@@ -26,4 +26,3 @@ function Get-NovaPackageRepository {
 
     Stop-NovaOperation -Message "Package repository not found: $Repository. Define it under Package.Repositories in project.json or provide -Url." -ErrorId 'Nova.Configuration.PackageRepositoryNotFound' -Category InvalidData -TargetObject $Repository
 }
-

src/private/package/GetNovaPackageSettingValue.ps1

@@ -23,4 +23,3 @@ function Get-NovaPackageSettingValue {
 
     return $null
 }
-

src/private/package/GetNovaPackageTypeExtension.ps1

@@ -11,4 +11,3 @@ function Get-NovaPackageTypeExtension {
 
     return '.nupkg'
 }
-

src/private/package/GetNovaPackageUploadArtifact.ps1

@@ -15,4 +15,3 @@ function Get-NovaPackageUploadArtifact {
         UploadUrl = Join-NovaPackageUploadUrl -Url $UploadTarget.Url -UploadPath $UploadTarget.UploadPath -PackageFileName $PackageFileInfo.PackageFileName
     }
 }
-

src/private/package/GetNovaPackageUploadAuthHeaderName.ps1

@@ -11,4 +11,3 @@ function Get-NovaPackageUploadAuthHeaderName {
 
     return "$headerName".Trim()
 }
-

src/private/package/GetNovaPackageUploadAuthHeaderValue.ps1

@@ -24,4 +24,3 @@ function Get-NovaPackageUploadAuthHeaderValue {
 
     return "$("$scheme".Trim() ) $Token"
 }
-

src/private/package/GetNovaPackageUploadFileList.ps1

@@ -14,4 +14,3 @@ function Get-NovaPackageUploadFileList {
 
     return @(Resolve-NovaPackageUploadOutputFileList -ProjectInfo $ProjectInfo -PackageType $PackageType)
 }
-

src/private/package/GetNovaPackageUploadPath.ps1

@@ -14,4 +14,3 @@ function Get-NovaPackageUploadPath {
 
     return "$( $resolvedUploadPath )".Trim()
 }
-

src/private/package/GetNovaPackageUploadStatusCode.ps1

@@ -14,4 +14,3 @@ function Get-NovaPackageUploadStatusCode {
 
     return $null
 }
-

src/private/package/GetNovaPackageUploadTargetSettingBundle.ps1

@@ -11,4 +11,3 @@ function Get-NovaPackageUploadTargetSettingBundle {
         Auth = Merge-NovaPackageSettingTable -BaseSettings (Get-NovaPackageSettingValue -InputObject $PackageSettings -Name 'Auth') -OverrideSettings (Get-NovaPackageSettingValue -InputObject $RepositorySettings -Name 'Auth')
     }
 }
-

src/private/package/GetNovaPackageUploadTargetUrl.ps1

@@ -18,4 +18,3 @@ function Get-NovaPackageUploadTargetUrl {
 
     return "$resolvedUrl".Trim()
 }
-

src/private/package/GetNovaPackageUploadToken.ps1

@@ -13,4 +13,3 @@ function Get-NovaPackageUploadToken {
         ConfiguredValue = Get-NovaPackageSettingValue -InputObject $AuthSettings -Name 'Token'
     })
 }
-

src/private/package/GetNovaPackageUploadWorkflowContext.ps1

@@ -29,4 +29,3 @@ function Get-NovaPackageUploadWorkflowContext {
         Operation = Get-NovaPackageUploadWorkflowOperation -UploadArtifactList $uploadArtifactList
     }
 }
-

src/private/package/GetNovaPackageUploadWorkflowOperation.ps1

@@ -10,4 +10,3 @@ function Get-NovaPackageUploadWorkflowOperation {
 
     return "Upload $( $UploadArtifactList.Count ) package artifacts"
 }
-

src/private/package/GetNovaPackageUploadWorkflowTarget.ps1

@@ -6,4 +6,3 @@ function Get-NovaPackageUploadWorkflowTarget {
 
     return ($UploadArtifactList | ForEach-Object {$_.UploadUrl}) -join ', '
 }
-

src/private/package/JoinNovaPackageUploadUrl.ps1

@@ -14,4 +14,3 @@ function Join-NovaPackageUploadUrl {
     $urlPartList += [System.Uri]::EscapeDataString($PackageFileName)
     return $urlPartList -join '/'
 }
-

src/private/package/NewNovaPackageArtifacts.ps1

@@ -4,7 +4,7 @@ function New-NovaPackageArtifacts {
     [CmdletBinding()]
     param(
         [Parameter(Mandatory)][pscustomobject]$ProjectInfo,
-        [Parameter(Mandatory)][object[]]$PackageMetadataList
+        [Parameter(Mandatory)][AllowEmptyCollection()][object[]]$PackageMetadataList
     )
 
     $resolvedPackageMetadataList = @($PackageMetadataList)

src/private/package/NewNovaPackageContentTypesXml.ps1

@@ -38,4 +38,3 @@ function New-NovaPackageContentTypesXml {
     $xmlLines += '</Types>'
     return $xmlLines -join [Environment]::NewLine
 }
-

src/private/package/NewNovaPackageCorePropertiesXml.ps1

@@ -23,4 +23,3 @@ function New-NovaPackageCorePropertiesXml {
         '</coreProperties>'
     ) -join [Environment]::NewLine
 }
-

src/private/package/NewNovaPackageNuspecXml.ps1

@@ -25,4 +25,3 @@ function New-NovaPackageNuspecXml {
         '</package>'
     ) -join [Environment]::NewLine
 }
-

src/private/package/NewNovaPackageRelationshipsXml.ps1

@@ -14,4 +14,3 @@ function New-NovaPackageRelationshipsXml {
         '</Relationships>'
     ) -join [Environment]::NewLine
 }
-

src/private/package/ResolveNovaPackageUploadAuthHeaderEntry.ps1

@@ -16,4 +16,3 @@ function Resolve-NovaPackageUploadAuthHeaderEntry {
         Value = Get-NovaPackageUploadAuthHeaderValue -AuthSettings $AuthSettings -AuthenticationScheme $UploadOption.AuthenticationScheme -HeaderName $headerName -Token $resolvedToken
     }
 }
-

src/private/package/ResolveNovaPackageUploadHeaders.ps1

@@ -15,4 +15,3 @@ function Resolve-NovaPackageUploadHeaders {
     $resolvedHeaders[$authHeaderEntry.Name] = $authHeaderEntry.Value
     return $resolvedHeaders
 }
-

src/private/package/ResolveNovaPackageUploadTarget.ps1

@@ -21,4 +21,3 @@ function Resolve-NovaPackageUploadTarget {
         Auth = $targetSettings.Auth
     }
 }
-

src/private/package/ResolveNovaPackageUploadTypeList.ps1

@@ -48,4 +48,3 @@ function Resolve-NovaRequestedPackageUploadTypeList {
 
     Stop-NovaOperation -Message "Package.FileNamePattern '$( $PatternInfo.Pattern )' resolves to type '$( $PatternInfo.ExplicitPackageType )', but requested PackageType values are: $( $resolvedTypeList -join ', ' )." -ErrorId 'Nova.Validation.PackageUploadPatternConflict' -Category InvalidArgument -TargetObject $PatternInfo.Pattern
 }
-

src/private/package/TestNovaPathContainsPath.ps1

@@ -13,4 +13,3 @@ function Test-NovaPathContainsPath {
 
     return $normalizedChildPath.StartsWith("$normalizedParentPath$( [System.IO.Path]::DirectorySeparatorChar )", [System.StringComparison]::OrdinalIgnoreCase)
 }
-

src/private/quality/GetNovaTestWorkflowContext.ps1

@@ -60,7 +60,3 @@ function Get-NovaTestOptionValue {
 
     return $null
 }
-
-
-
-

src/private/quality/InvokeNovaTestWorkflow.ps1

@@ -77,5 +77,3 @@ function Initialize-NovaPesterArtifactDirectory {
 
     $null = New-Item -ItemType Directory -Path $WorkflowContext.TestResultDirectory -Force
 }
-
-

src/private/quality/NewNovaTestDynamicParameterDictionary.ps1

@@ -9,4 +9,3 @@ function New-NovaTestDynamicParameterDictionary {
     $dictionary.Add('Build',[System.Management.Automation.RuntimeDefinedParameter]::new('Build', [switch],$attributeCollection))
     return $dictionary
 }
-

src/private/release/GetNovaVersionUpdateCiActivatedCommand.ps1

@@ -15,4 +15,3 @@ function Get-NovaVersionUpdateCiActivatedCommand {
     $importedModule = Import-NovaBuiltModuleForCi -ProjectInfo $projectInfo
     return $importedModule.ExportedCommands['Update-NovaModuleVersion']
 }
-

src/private/release/WriteNovaPublishWorkflowContext.ps1

@@ -7,4 +7,3 @@ function Write-NovaPublishWorkflowContext {
     Write-NovaLocalWorkflowMode -WorkflowName $WorkflowContext.WorkflowName -LocalRequested:$WorkflowContext.LocalRequested
     Write-NovaResolvedLocalPublishTarget -PublishInvocation $WorkflowContext.PublishInvocation
 }
-

src/private/shared/ConvertToNovaPackageType.ps1

@@ -22,4 +22,3 @@ function ConvertTo-NovaPackageType {
         }
     }
 }
-

src/private/shared/GetNovaEnvironmentVariableValue.ps1

@@ -10,4 +10,3 @@ function Get-NovaEnvironmentVariableValue {
 
     return [System.Environment]::GetEnvironmentVariable($Name.Trim())
 }
-

src/private/shared/GetNovaProjectInfoContext.ps1

@@ -16,4 +16,3 @@ function Get-NovaProjectInfoContext {
         JsonData = Read-ProjectJsonData -ProjectJsonPath $projectJson
     }
 }
-