#175 fix: require explicit override for no-git bump fallback#177
Merged
Conversation
Stop `nova bump` and `Update-NovaModuleVersion` from silently presenting `Patch | Commits: 0` when Git-based bump inference is unavailable. Add `-OverrideWarning` / `--override-warning` / `-o` as the explicit opt-in for intentional non-git Patch fallback flows, add regression coverage, and update bump docs and changelog. Closes #175
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Code Coverage Gates Passed
Overall Coverage: 100.0%
(required = 95%)
New & Changed Code Coverage: 100%
(required = 99%)
Review details by gate
-
Overall Coverage
- Pass/Fail Reason:
The overall coverage gate was checked for all code and meets the goal: 100.0% covered >= threshold = 95% - Action:
You have 281 files with a sum of 2862 covered and 1 uncovered lines of code.
- Pass/Fail Reason:
-
New & Changed Code Coverage
- Pass/Fail Reason:
New or changed code meets coverage goal: 100% covered >= threshold = 99% - Action:
You modified 4 files, and covered 13 added/modified lines of code.
- Pass/Fail Reason:
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stiwicourage
added a commit
that referenced
this pull request
May 8, 2026
…178) * chore: prepare develop for next prerelease * fix: Nova's CI/CD test flow installed. * fix: package.json is no longer used. * Add changelog link and badge to README Added a link to the 'Keep a Changelog' website and its badge. * Add 'Keep a Changelog' badge to CONTRIBUTING.md Added a badge for 'Keep a Changelog' to the contributing guidelines. * Update CONTRIBUTING.md with additional badges Added badges for changelog and code health to CONTRIBUTING.md * Rearrange badges in CONTRIBUTING.md Moved CodeScene Average Code Health badge to a new position. * Update CONTRIBUTING.md with consolidated badges Consolidate badge links into the contributing section. * Refactor contributing section with badges Updated the formatting of the contributing section and added badges for changelog, code coverage, and code health. * Update README.md badge formatting Reformatted README.md to improve badge layout. * #174 fix: detect parent git repositories for nova bump (#176) Make nova bump and Update-NovaModuleVersion resolve Git history from parent repositories, so nested project folders infer the correct semantic version instead of falling back to Patch with Commits: 0. Add regression coverage for nested project bump inference and update the changelog. Closes #174 * chore: prepare next prerelease version * #175 fix: require explicit override for no-git bump fallback (#177) Stop `nova bump` and `Update-NovaModuleVersion` from silently presenting `Patch | Commits: 0` when Git-based bump inference is unavailable. Add `-OverrideWarning` / `--override-warning` / `-o` as the explicit opt-in for intentional non-git Patch fallback flows, add regression coverage, and update bump docs and changelog. Closes #175 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
stiwicourage
deleted the
bug/175-bug-nova-bump-should-require-explicit-override-when-git-inference-is-unavailable
branch
May 12, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop
nova bumpandUpdate-NovaModuleVersionfrom silently presentingPatch | Commits: 0when Git-based bump inference is unavailable.Add
-OverrideWarning/--override-warning/-oas the explicit opt-infor intentional non-git Patch fallback flows, add regression coverage, and
update bump docs and changelog.
Closes #175
Summary
Affected area
Review guidance
Validation
% nova publish,
% nova release, % nova update, % nova notification, or % nova init as relevant)
Validation notes:
Ran the repo quality gate with:
pwsh -NoLogo -NoProfile -File ./run.ps1
Result:
PSScriptAnalyzer: no findings
Tests Passed: 674
Failed: 0
Also ran:
git --no-pager diff --check
Targeted bump behavior was covered through the automated cmdlet + standalone CLI regression tests for
Update-NovaModuleVersion / nova bump, including the new override-warning path.
Documentation and release follow-up
changed
Maintainability, compatibility, and risk
Risk, rollout, or rollback notes:
Risk is low and localized to bump inference when Git history is unavailable.
Compatibility note:
-OverrideWarning / --override-warning / -o.
plausible Patch plan.
Rollback is straightforward:
though that would reintroduce the misleading Patch | Commits: 0 behavior.
[!IMPORTANT] Do not use a public pull request to disclose a vulnerability before coordinated handling. Use the private reporting path in SECURITY.md for new security issues.