Enhance Nova CLI workflows, testing, and project.json schema support#254
Merged
Conversation
…ds to enhance version retrieval and user guidance (#239)
…esult handling and updating test cases
* #240 fix: Enhance progress tracking in Nova workflows and tests - Added detailed progress assertions in Invoke-NovaBuildWorkflow, Invoke-NovaPackageUploadWorkflow, Invoke-NovaPackageWorkflow, Invoke-NovaTestWorkflow, Invoke-NovaPublishWorkflow, Invoke-NovaReleaseWorkflow, Invoke-NovaModuleInitializationWorkflow, and Invoke-NovaModuleSelfUpdateWorkflow tests to ensure accurate reporting of workflow states. - Implemented a new test suite to verify that all workflows writing progress have corresponding test files, ensuring consistency and coverage. - Updated mock functions to capture and validate messages related to workflow actions, improving test reliability and output verification. * #240 fix: add tests for Get-NovaPesterExecution and Get-NovaPublishWorkflowPropertyValue functions
* #242 feat: Enhance project.json schema support and VS Code integration - Added `$schema` property injection in `nova init` for new projects, enabling VS Code IntelliSense and autocomplete. - Introduced authoritative `Schema-Project.json` for project.json validation. - Updated `Test-ProjectSchema` to validate against the new schema. - Removed obsolete `Schema-Build.json` and `Schema-Pester.json`. - Implemented `Export-NovaProjectJsonSchema` to copy the schema to the appropriate documentation directory. - Updated documentation to reflect schema changes and IntelliSense support. - Enhanced tests for schema validation and project.json writing functionality. * #242 fix: Update project.json and schema to enhance RequiredModules definition and versioning
* #242 feat: Enhance project.json schema support and VS Code integration - Added `$schema` property injection in `nova init` for new projects, enabling VS Code IntelliSense and autocomplete. - Introduced authoritative `Schema-Project.json` for project.json validation. - Updated `Test-ProjectSchema` to validate against the new schema. - Removed obsolete `Schema-Build.json` and `Schema-Pester.json`. - Implemented `Export-NovaProjectJsonSchema` to copy the schema to the appropriate documentation directory. - Updated documentation to reflect schema changes and IntelliSense support. - Enhanced tests for schema validation and project.json writing functionality. * #242 fix: Update project.json and schema to enhance RequiredModules definition and versioning * #242 feat: Add VS Code settings integration for project.json schema support * #242 feat: Update prompts to require skill invocation before actions for improved workflow clarity * #242 feat: Update prompts to require skill invocation before actions for improved workflow clarity
#248) * #242 feat: Enhance project.json schema support and VS Code integration - Added `$schema` property injection in `nova init` for new projects, enabling VS Code IntelliSense and autocomplete. - Introduced authoritative `Schema-Project.json` for project.json validation. - Updated `Test-ProjectSchema` to validate against the new schema. - Removed obsolete `Schema-Build.json` and `Schema-Pester.json`. - Implemented `Export-NovaProjectJsonSchema` to copy the schema to the appropriate documentation directory. - Updated documentation to reflect schema changes and IntelliSense support. - Enhanced tests for schema validation and project.json writing functionality. * #242 fix: Update project.json and schema to enhance RequiredModules definition and versioning * #242 feat: Add VS Code settings integration for project.json schema support * #242 feat: Update prompts to require skill invocation before actions for improved workflow clarity * #242 feat: Update prompts to require skill invocation before actions for improved workflow clarity * #242 feat: Remove support for boolean values in Package.Latest and update related JSON schema and error handling
…tion (#252) * #247 feat: Enhance Nova CLI Testing and Workflow Functionality - Added tests for Invoke-NovaCliTestRouteCommand to ensure proper routing of test commands. - Improved Get-NovaPesterRunPath to return matching recursive test files based on BuildRecursiveFolders setting. - Updated Get-NovaPesterTestResultPath to allow custom result file names. - Refactored Get-NovaTestWorkflowContext to support new test workflow configurations and parameters. - Introduced new tests for Invoke-NovaTest to validate command options and workflow invocation. - Enhanced Invoke-NovaReleaseWorkflow to track unit and integration test calls separately. - Removed deprecated NewNovaTestDynamicParameterDictionary tests. - Updated scaffolding tests to reflect changes in suggested next steps for workflows. - Refined dynamic parameter handling in Nova testing functions to improve clarity and maintainability. * #247 feat: Add -OverrideWarning parameter to Invoke-NovaTest and related updates for coverage configuration * #247 feat: Refactor testing and validation instructions for Nova-managed projects - Update reviewer and test engineer agents to specify `Invoke-NovaTest` for unit validation and `Test-NovaBuild` for build-validation integration. - Revise documentation to clarify public command unit tests and integration tests structure under `tests/public/<Command>.Tests.ps1` and `tests/public/<Command>.Integration.Tests.ps1`. - Enhance instructions for handling destructive or environment-coupled commands with a preference for safe `-WhatIf` integration coverage. - Adjust various prompts and guidelines to reflect the new testing structure and validation processes. - Ensure consistency across all documentation regarding the use of `Invoke-NovaTest` and `Test-NovaBuild`. * #247 feat: Add integration tests for Nova commands with WhatIf support
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Code Coverage Gates Passed
Overall Coverage: 99.8%
(required = 95%)
New & Changed Code Coverage: 100%
(required = 99%)
Review details by gate
-
Overall Coverage
- Pass/Fail Reason:
The overall coverage gate was checked for all code and meets the goal: 99.8% covered >= threshold = 95% - Action:
You have 294 files with a sum of 4073 covered and 7 uncovered lines of code.
- Pass/Fail Reason:
-
New & Changed Code Coverage
- Pass/Fail Reason:
New or changed code meets coverage goal: 100% covered >= threshold = 99% - Action:
You modified 26 files, and covered 426 added/modified lines of code.
- Pass/Fail Reason:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3.1.1-preview02prerelease line ondeveloprelative to the stable3.1.0line onmain, with the biggest release-facing changes being the newInvoke-NovaTestunit-test entrypoint, theTest-NovaBuildbuild-validation split, hosted single-sourceproject.jsonschema export/injection,Get-NovaProjectInfoversion-surface alignment,Update-NovaModuleToolfollow-up guidance updates, stricterPackage.Latestvalidation, and broad mirrored test/help/docs coverage to lock those contracts in.project.jsonauthoring and VS Code validation, tighten package/config compatibility rules, and make repository, CI, publish, and release quality flows validate unit tests before build-validation integration tests.Closes #123). Release-prep scope only: this diff is the promotion candidate frommainstable3.1.0todevelopprerelease3.1.1-preview02. The behavior described here remains prerelease-only until promoted tomain. No publish, tag, or push actions were performed.Affected area
novaCLI or command routingproject.jsonhandlingREADME.md,CONTRIBUTING.md, repository workflow docs)docs/*.html)docs/NovaModuleTools/en-US/*.md)src/resources/example/project.json, workflow dependencies, release tooling)Review guidance
src/public/InvokeNovaTest.ps1,src/public/TestNovaBuild.ps1,src/private/quality/, andsrc/private/cli/InvokeNovaCliCommandRoute.ps1first.src/resources/Schema-Project.json,docs/schema/v3/project.json,src/private/build/ExportNovaProjectJsonSchema.ps1,src/private/scaffold/WriteNovaModuleProjectJson.ps1, andsrc/private/scaffold/WriteNovaVsCodeSettings.ps1.tests/,docs/,README.md,CONTRIBUTING.md, scaffold mirrors, and release/package workflow helpers. Main trade-off/risk:Package.Latest=true|falseis no longer accepted, so projects still using the old boolean form must migrate to"always"or"never"before stable promotion.Validation
Invoke-NovaBuildInvoke-NovaTestTest-NovaBuild./scripts/build/Invoke-ScriptAnalyzerCI.ps1./scripts/build/ci/Invoke-NovaModuleToolsCI.ps1% nova build,% nova test,% nova merge,% nova deploy,% nova publish,% nova release,% nova update,% nova notification, or% nova initas relevant)Validation notes:
Documentation and release follow-up
README.mdreviewed and updated if contributor workflow, architecture, CI, release, or automation changedCONTRIBUTING.mdreviewed and updated if contribution expectations or review guidance changedCHANGELOG.mdreviewed and updated if the change matters to users, maintainers, or contributorsRELEASE_NOTE.mdreviewed and updated if the change affects public cmdlet usage, CLI usage, configuration semantics, or migration expectationsdocs/NovaModuleTools/en-US/help updated if a public command or CLI behavior changeddocs/*.htmlupdated if end-user workflows or examples changedsrc/resources/example/reviewed and updated if the real-world project layout, package model, or upload workflow changedMaintainability, compatibility, and risk
Risk, rollout, or rollback notes:
Important
Do not use a public pull request to disclose a vulnerability before coordinated handling.
Use the private reporting path in
SECURITY.mdfor new security issues.