feat: workspace/didChangeConfiguration support#1
Open
Serial-ATA wants to merge 3 commits into
Open
Conversation
claymcleod
requested changes
Apr 2, 2026
claymcleod
reviewed
Apr 2, 2026
| }))); | ||
| } | ||
|
|
||
| Ok(None) |
Member
There was a problem hiding this comment.
If a user removes their server settings, returning None here means Sprocket won't receive an update to clear the old configuration. It might be worth returning an empty object as the default so stale settings don't linger.
Suggested change
| Ok(None) | |
| Ok(Some(serde_json::json!({ "sprocket.server": {} }))) |
Author
There was a problem hiding this comment.
Changed it to return the default server config. An empty config also wouldn't update anything since the server applies config changes as patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.