Skip to content

Commit 9aad344

Browse files
committed
Fix CI test project to demonstrate correct usage order
The integration test was calling project() before setting up cpp-library and enabling dependency tracking, which is incorrect and would fail for any library with actual dependencies. Corrected order: 1. cmake_minimum_required(VERSION 3.24) - updated from 3.20 2. include CPM.cmake 3. CPMAddPackage(cpp-library) 4. include cpp-library.cmake 5. cpp_library_enable_dependency_tracking() 6. project() - now called AFTER tracking enabled 7. cpp_library_setup() This matches the documented usage pattern and ensures the test demonstrates best practices for users following the example.
1 parent 31df212 commit 9aad344

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,21 @@ jobs:
3838
3939
# Create CMakeLists.txt that uses cpp-library
4040
cat > CMakeLists.txt << 'EOF'
41-
cmake_minimum_required(VERSION 3.20)
42-
project(mylib VERSION 1.0.0)
41+
cmake_minimum_required(VERSION 3.24)
4342
43+
# Setup CPM before project()
4444
include(../cmake/CPM.cmake)
45+
46+
# Fetch cpp-library before project()
4547
CPMAddPackage(NAME cpp-library SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/..)
4648
include(${cpp-library_SOURCE_DIR}/cpp-library.cmake)
4749
50+
# Enable dependency tracking before project()
51+
cpp_library_enable_dependency_tracking()
52+
53+
# Now call project()
54+
project(mylib VERSION 1.0.0)
55+
4856
# Create a simple test library
4957
cpp_library_setup(
5058
DESCRIPTION "Test library for cpp-library"

0 commit comments

Comments
 (0)