Closed
Conversation
Contributor
Author
|
Hi @fpistm, I have a few questions before the PR is ready (and I need to test it properly):
|
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
…_Core_STM32 into fpistm-PR863-DISCO_G0316
Contributor
Author
|
Hi @fpistm, thank you for your patch. There were many fixes! One of the issues I had is that I misunderstood the comment All pins are digital, analog inputs are a subset of digital pins. from variant.h of the board_template. I interpreted it as I will do some testing in the next few days so you can merge this. If you already tested it and you think it is ready to merge, I marked the PR as ready for review. Many thanks! |
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the STM32G0316-DISCO variant which is based on a STM32G0 in SO8 package.
Fix #858. This is a draft PR as I want to gather some feedback from the maintainers first.