Merged
Conversation
This pinout is formatted the same way as the Generic F401Rx and F411Rx pinout, and is used with the STM32F446RC and STM32F446RE chips
447c33d to
4ad0860
Compare
fpistm
requested changes
Jan 28, 2020
FMP TWI is not supported by this core anyways
Now the main clock is running at 180 MHz. The USB peripheral is also ready to be used since a 48 MHz clock is set up too. This clock config will expect an 8 MHz external clock or crystal (HSE). If not present, it will automatically switch to its internal clock (HSI).
Contributor
Author
|
As a note, I'm using CubeMX's clock config tool together with some of the mbed F446Rx source files to determine the right settings. I've also tested the internal and the external oscillator option on my Nucleo F446RE board |
fpistm
requested changes
Jan 31, 2020
Member
There was a problem hiding this comment.
AStyle failed
--- a/variants/Generic_F446Rx/variant.cpp
+++ b/variants/Generic_F446Rx/variant.cpp
@@ -154,9 +154,9 @@ static uint8_t SetSysClock_PLL_HSE(uint8_t bypass)
}
// Activate the OverDrive to reach the 180 MHz Frequency
- if (HAL_PWREx_EnableOverDrive() != HAL_OK) {
- return 0; // FAIL
- }
+ if (HAL_PWREx_EnableOverDrive() != HAL_OK) {
+ return 0; // FAIL
+ }
// Select PLLSAI output as USB clock source
PeriphClkInitStruct.PLLSAI.PLLSAIM = 8;
@@ -219,7 +219,7 @@ uint8_t SetSysClock_PLL_HSI(void)
// Activate the OverDrive to reach the 180 MHz Frequency
if (HAL_PWREx_EnableOverDrive() != HAL_OK) {
- return 0; // FAIL
+ return 0; // FAIL
}
fpistm
requested changes
Jan 31, 2020
Member
fpistm
left a comment
There was a problem hiding this comment.
You missed one astyle issue
--- a/variants/Generic_F446Rx/variant.cpp
+++ b/variants/Generic_F446Rx/variant.cpp
@@ -154,9 +154,9 @@ static uint8_t SetSysClock_PLL_HSE(uint8_t bypass)
}
// Activate the OverDrive to reach the 180 MHz Frequency
- if (HAL_PWREx_EnableOverDrive() != HAL_OK) {
- return 0; // FAIL
- }
+ if (HAL_PWREx_EnableOverDrive() != HAL_OK) {
+ return 0; // FAIL
+ }178d655 to
80ac35c
Compare
fpistm
reviewed
Jan 31, 2020
fpistm
requested changes
Feb 3, 2020
Since HSE_VALUE can be redefined at compile time, this value also needs to take this into account
fpistm
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout wise this pinout is more or less identical with
Genric_F401RxandGeneric F411Rx, but of course designed to work with the F446Rx series.