Fix SPI mapping for some generic F4 variants#921
Merged
fpistm merged 2 commits intostm32duino:masterfrom Feb 7, 2020
Merged
Conversation
Make use of SPI3 on PA15, PB3, PB4 and PB5. This will make the generic F4 pinouts more similar, so it will be easier to migrate fron one chip to another without beaking code changes due to the pin mapping
fpistm
requested changes
Feb 6, 2020
Member
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
OK for this change.
Anyway, regarding other Generic F4 variant, there are some issues with SPI pin and I2C definitions:
- Generic_F410Cx
- Generic_F410Rx
- Generic_F446Rx
It misses those definitons:
// SPI definitions
#define PIN_SPI_SS PXY
#define PIN_SPI_SS1 PXY
#define PIN_SPI_SS2 PXY
#define PIN_SPI_SS3 PXY
#define PIN_SPI_SS5 PXY
#define PIN_SPI_MOSI PXY
#define PIN_SPI_MISO PXY
#define PIN_SPI_SCK PXY
// I2C definitions
#define PIN_WIRE_SDA PXY
#define PIN_WIRE_SCL PXY
Contributor
Author
|
Thanks for pointing this out. I totally forgot about this. A fix is on its way! |
fpistm
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of SPI3 on PA15, PB3, PB4, and PB5. This will make the generic F4 pinouts more similar, so it will be easier to migrate from one chip to another without breaking code changes due to the pin mapping.
F410Rx and F410Cx do not have SPI3 on these pins, but rather SPI1. These will stay untouched.