Merge pull request Yoast#22832 from Yoast/2604-analysis-error-in-classic-editor

Excludes empty sentences from the analysis of consecutive sentences assessment

Author: vraja-pro

packages/yoastseo/spec/languageProcessing/researches/getSentenceBeginningsSpec.js

@@ -152,6 +152,15 @@ describe( "gets the sentence beginnings and the count of consecutive duplicates.
 		expect( getSentenceBeginnings( mockPaper, researcher )[ 2 ].count ).toBe( 1 );
 	} );
 
+	it( "excludes sentences that contains only shortcodes", function() {
+		mockPaper = new Paper( "[shortcode]. [shortcode]. [shortcode]. First sentence.", { shortcodes: [ "shortcode" ] } );
+		researcher = new EnglishResearcher( mockPaper );
+		buildTree( mockPaper, researcher );
+		const sentenceBeginnings = getSentenceBeginnings( mockPaper, researcher );
+		expect( sentenceBeginnings ).toHaveLength( 1 );
+		expect( getSentenceBeginnings( mockPaper, researcher )[ 0 ].word ).toBe( "first" );
+	} );
+
 	it( "returns an object with English sentence beginnings with paragraph tags - it should match over paragraphs", function() {
 		mockPaper = new Paper( "<p>Sentence 1. Sentence 2.</p><p>Sentence 3.</p>" );
 		researcher = new EnglishResearcher( mockPaper );

packages/yoastseo/src/languageProcessing/researches/getSentenceBeginnings.js

@@ -97,8 +97,9 @@ export default ( paper, researcher ) => {
 	let tree = cloneDeep( paper.getTree() );
 	tree = filterTree( tree, additionalFilters );
 
-	// Get all sentences from the tree, and find their sentence beginnings.
-	const sentences = getSentencesFromTree( tree );
+	// Get all sentences from the tree that contain tokens.
+	const sentences = getSentencesFromTree( tree ).filter( sentence => sentence.tokens.length > 0 );
+	// Get the sentence beginnings.
 	const sentenceBeginnings = sentences.map( sentence => getSentenceBeginning( sentence, firstWordExceptions, secondWordExceptions ) );
 
 	// Turn the sentence beginnings into an array that combines sentences beginning with the same word(s).