Skip to content

Commit dbe2e03

Browse files
committed
📝 Update documentation
1 parent 8cec2e1 commit dbe2e03

2 files changed

Lines changed: 103 additions & 80 deletions

File tree

.github/contributing.md

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Contributing to action-reporting-cli
22

3-
Thank you for your interest in contributing to this project! We welcome contributions from the community and are pleased that you're interested in helping improve action-reporting-cli.
3+
Thanks for your interest in contributing to this project! We welcome contributions from the community and we're glad you're interested in helping improve action-reporting-cli.
44

5-
This document outlines the process for contributing to this project and provides guidelines to make the contribution process smooth and effective.
5+
This document outlines the process for contributing to the project and provides guidelines to make the contribution process smooth and effective.
66

77
## Code of Conduct
88

@@ -19,6 +19,7 @@ Before creating bug reports, please check the existing issues to avoid duplicate
1919
- Expected behavior versus actual behavior
2020
- Screenshots or terminal output (if applicable)
2121
- Environment details (OS, Node.js version, etc.)
22+
- Command line arguments you used with the tool
2223

2324
### Suggesting Enhancements
2425

@@ -41,6 +42,8 @@ Follow these steps to submit your contributions:
4142
6. Push to your branch (`git push origin my-new-feature`)
4243
7. Create a new Pull Request
4344

45+
When submitting pull requests that affect functionality, please make sure to update the relevant documentation in the README.md file as well.
46+
4447
## Development Guidelines
4548

4649
### Getting Started
@@ -66,19 +69,24 @@ Follow these steps to submit your contributions:
6669
### Project Structure
6770

6871
- `src/`: Main source code
69-
- `github/`: GitHub API interaction classes
70-
- `report/`: Report generation modules
71-
- `util/`: Utility functions for logging, caching, etc.
72-
- `test/`: Unit tests
73-
- `cli.js`: Main entry point
72+
- `github/`: GitHub API interaction classes (Enterprise, Owner, Repository, Workflow)
73+
- `report/`: Report generation modules (CSV, JSON, Markdown)
74+
- `util/`: Utility functions for logging, caching, and rate limiting
75+
- `test/`: Unit tests with corresponding structure to src/
76+
- `__fixtures__/`: Test data for unit tests
77+
- `__mocks__/`: Mock implementations for testing
78+
- `cli.js`: Main entry point for the command-line tool
7479

7580
### Coding Standards
7681

7782
- Follow the existing code style (we use prettier and ESLint)
7883
- Write documentation for new methods, classes, and functions
7984
- Include JSDoc comments for public APIs
80-
- Keep functions focused and modular
81-
- Write tests for new functionality
85+
- Keep functions focused and modular (generally under 50 lines)
86+
- Use clear, descriptive variable and function names
87+
- Handle errors consistently throughout the codebase
88+
- Keep all lines, including comments, under 120 characters
89+
- Write tests for all new functionality
8290

8391
### Commit Message Guidelines
8492

@@ -109,12 +117,15 @@ Examples:
109117
- All new features should include corresponding tests
110118
- Run the test suite before submitting a pull request: `npm test`
111119
- Ensure your changes don't break existing functionality
120+
- If you're fixing a bug, consider adding a test that would have caught the bug
112121

113122
## Documentation
114123

115124
- Update the README.md with any necessary changes
116125
- Document new features, options, or behavior changes
117126
- Consider updating examples if relevant
127+
- Use a conversational tone that matches the existing documentation
128+
- For command examples, use the format shown in the README (e.g., `my-org/my-repo` for repository names)
118129

119130
## Review Process
120131

@@ -125,5 +136,6 @@ Examples:
125136
## Additional Resources
126137

127138
- [GitHub Pull Request Documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests)
139+
- [Test documentation](../test/readme.md) for detailed testing information
128140

129-
Thank you for contributing to action-reporting-cli!
141+
Thanks for contributing to action-reporting-cli!

0 commit comments

Comments
 (0)