Fix/148 meow input type error#149
Closed
a-magdy wants to merge 6 commits into
Closed
Conversation
…for help and version flags
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Node.js 22+ runtime crash in the CLI caused by an invalid meow option type, and adds end-to-end CLI smoke tests to exercise the entrypoint.
Changes:
- Remove invalid
meowoption (input: []) that triggers aTypeErroron newer Node.js versions. - Add Jest tests that run the CLI in a child process and validate
--help/--versionbehavior. - Ignore macOS
.DS_Storefiles.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cli.js |
Removes the invalid meow option that caused the Node.js 22+ crash. |
test/cli.test.js |
Adds end-to-end smoke tests by spawning the CLI as a subprocess. |
.gitignore |
Adds .DS_Store to ignored files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Overriding DEBUG env var to 'false' Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ahmed Magdy <a-magdy@users.noreply.github.com>
--version test to filer out the last line before checking for the correct value Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ahmed Magdy <a-magdy@users.noreply.github.com>
stoe
approved these changes
Apr 17, 2026
Owner
|
Hi @a-magdy, thank you for your contribution. To merge, my open source repositories require "Commits must have verified signatures". |
Contributor
Author
|
yeah sure thing |
auto-merge was automatically disabled
April 17, 2026 15:25
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fix usage of meow options
🔗 Related Issues
#148