Fix: Translatable setSkipOnLoad param name on service configuration#521
Merged
Fix: Translatable setSkipOnLoad param name on service configuration#521
Conversation
Owner
|
Good catch. Note that the contributor doing this migration did it by hand. Nowadays, we have tooling built by the Symfony core team that would have avoided such mistakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I just found out after updating to 1.5 that the
parameter stof_doctrine_extensions.skip_translation_on_loadis no longer used by TranslatableListener. Instead, the parameterstof_doctrine_extensions.persist_default_translationis used for the setSkipOnLoad method, which seems to me like a mistake introduced in Migrate service config from XML to PHP.I’ll stick with 1.14 for now, but I’ll gladly upgrade to 1.15 if a quick release is made.
Thank you.