fix: point eslint package entries to preset#1499
Open
Pugsin wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hello, I'm 🤖 Stormie-Bot (Storm Increased Efficiency Robot)! The Storm team sincerely appreciates your effort/interest in contributing to this project. A Storm developer will review this change and get back to you ASAP. Please feel free to reach out to the Storm team (contact@stormsoftware.com) if you have any questions/comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@storm-software/eslintpackage-levelmainandtypesat the published preset entry filesWhy
The published package root export already resolves to
dist/preset.js/dist/preset.d.ts, but the package-levelmainandtypesfields point todist/index.js/dist/index.d.ts. Thosedist/index.*files are not present in the npm tarball, so tooling that reads the legacy package fields can resolve to missing files.Validation
npm view @storm-software/eslint@0.170.90 main types exports --jsonnpm pack @storm-software/eslint@0.170.90 --dry-run --jsonconfirmsdist/preset.jsanddist/preset.d.tsare published, whiledist/index.jsis notnode -e "const p=require('./packages/eslint/package.json'); if(p.main!=='./dist/preset.js'||p.types!=='./dist/preset.d.ts') process.exit(1)"git diff --checkNote: I could not run full pnpm workspace gates here because pnpm is not installed in this environment. This is a package metadata-only fix.