Commit e6b1323
committed
fix(a2a): remove unnecessary duck-typing in cancel(), fix stale comment
- Remove AttributeError/NotImplementedError catch since self.agent is
typed as Agent which always has cancel()
- Update comment from 'we guard with hasattr' to reflect actual impl
- Update docstring to remove 'if available' language
Addresses review feedback from @mkmeral on executor.py:3271 parent a66e210 commit e6b1323
1 file changed
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | | - | |
300 | | - | |
| 299 | + | |
| 300 | + | |
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
| |||
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | | - | |
318 | | - | |
| 317 | + | |
| 318 | + | |
319 | 319 | | |
320 | 320 | | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | 321 | | |
325 | 322 | | |
326 | 323 | | |
| |||
0 commit comments