feat: add concurrent S3 message reading to list_messages#1422
Closed
feat: add concurrent S3 message reading to list_messages#1422
Conversation
Improves performance when listing messages by reading S3 objects concurrently using asyncio.to_thread and asyncio.gather. The list_messages method now spawns a threaded async event loop to perform concurrent reads while maintaining the synchronous external API. This change provides significant performance benefits for sessions with many messages without requiring any changes to consuming code or tests.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
Author
|
No longer relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Session managers that store messages in S3 can experience slow performance when listing many messages, as each message is read sequentially from S3. For sessions with dozens or hundreds of messages, this sequential reading creates a significant performance bottleneck that impacts user experience and system responsiveness.
Changes
This PR modifies the
S3SessionManager.list_messages()method to read S3 objects concurrently, providing substantial performance improvements for sessions with multiple messages.The implementation uses the existing
run_async()utility to spawn a threaded event loop, then leveragesasyncio.to_thread()andasyncio.gather()to perform concurrent S3 reads. The external API remains completely synchronous, requiring no changes to consuming code.Public API Changes
None. The external API signature and behavior of
list_messages()remain unchanged:Breaking Changes
None. This is a backward-compatible performance improvement.
Implementation Notes
Initially explored using
aiobotocorefor native async S3 operations, but discovered that themotolibrary used for testing doesn't fully support aiobotocore's async client. Switched toasyncio.to_thread()approach which:Resolves #1416