feat(session): add endpoint_url parameter to S3SessionManager#2061
Open
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Open
feat(session): add endpoint_url parameter to S3SessionManager#2061Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Conversation
Forwards an optional endpoint_url to the boto3 S3 client, enabling use with S3-compatible backends such as MinIO or LocalStack. Follows the same pattern as BedrockModel, which already accepts endpoint_url as a constructor parameter. Closes strands-agents#1794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
`S3SessionManager` creates its boto3 S3 client without accepting an `endpoint_url` parameter. This makes it impossible to use the session manager with S3-compatible storage backends such as MinIO or LocalStack, which are common in local development and VPC endpoint configurations.
`BedrockModel` already accepts `endpoint_url` as a first-class constructor parameter and forwards it to its boto3 client. This change applies the same pattern to `S3SessionManager`.
Changes:
When `endpoint_url` is not provided (the default), behavior is unchanged.
Related Issues
Fixes #1794
Documentation PR
N/A
Type of Change
New feature
Testing
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.