Skip to content

fix: add gen_ai common attributes to execute_event_loop_cycle spans #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zelys-DFKH wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −4
Open

fix: add gen_ai common attributes to execute_event_loop_cycle spans #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/strands/telemetry/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,10 @@ def start_event_loop_cycle_span(
event_loop_cycle_id = str(invocation_state.get("event_loop_cycle_id"))
parent_span = parent_span if parent_span else invocation_state.get("event_loop_parent_span")

attributes: dict[str, AttributeValue] = {
"event_loop.cycle_id": event_loop_cycle_id,
}
attributes: dict[str, AttributeValue] = self._get_common_attributes(
operation_name="execute_event_loop_cycle"
)
attributes["event_loop.cycle_id"] = event_loop_cycle_id

if custom_trace_attributes:
attributes.update(custom_trace_attributes)
Expand Down
31 changes: 30 additions & 1 deletion tests/strands/telemetry/test_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,8 @@ def test_start_event_loop_cycle_span(mock_tracer):

mock_span.set_attributes.assert_called_once_with(
{
"gen_ai.operation.name": "execute_event_loop_cycle",
"gen_ai.system": "strands-agents",
"event_loop.cycle_id": "cycle-123",
"request_id": "req-456",
"trace_level": "debug",
Expand Down Expand Up @@ -758,7 +760,13 @@ def test_start_event_loop_cycle_span_latest_conventions(mock_tracer, monkeypatch
mock_tracer.start_span.assert_called_once()
assert mock_tracer.start_span.call_args[1]["name"] == "execute_event_loop_cycle"

mock_span.set_attributes.assert_called_once_with({"event_loop.cycle_id": "cycle-123"})
mock_span.set_attributes.assert_called_once_with(
{
"gen_ai.operation.name": "execute_event_loop_cycle",
"gen_ai.provider.name": "strands-agents",
"event_loop.cycle_id": "cycle-123",
}
)
mock_span.add_event.assert_any_call(
"gen_ai.client.inference.operation.details",
attributes={
Expand All @@ -768,6 +776,27 @@ def test_start_event_loop_cycle_span_latest_conventions(mock_tracer, monkeypatch
assert span is not None


def test_start_event_loop_cycle_span_includes_common_attributes(mock_tracer):
"""Test that start_event_loop_cycle_span includes gen_ai common attributes."""
with mock.patch("strands.telemetry.tracer.trace_api.get_tracer", return_value=mock_tracer):
tracer = Tracer()
tracer.tracer = mock_tracer

mock_span = mock.MagicMock()
mock_tracer.start_span.return_value = mock_span

event_loop_kwargs = {"event_loop_cycle_id": "cycle-123"}
messages = [{"role": "user", "content": [{"text": "Hello"}]}]

tracer.start_event_loop_cycle_span(event_loop_kwargs, messages=messages)

set_attrs_call = mock_span.set_attributes.call_args[0][0]
assert "gen_ai.operation.name" in set_attrs_call
assert set_attrs_call["gen_ai.operation.name"] == "execute_event_loop_cycle"
assert "gen_ai.system" in set_attrs_call
assert set_attrs_call["gen_ai.system"] == "strands-agents"


def test_end_event_loop_cycle_span(mock_span):
"""Test ending an event loop cycle span."""
tracer = Tracer()
Expand Down