fix: forward config params to structured_output() in OpenAIResponsesModel#2069
Open
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Open
Conversation
…odel structured_output() called _format_request() but only extracted ["input"], silently dropping all config params (max_output_tokens, reasoning, instructions, etc.). The stream() method does not have this issue because it passes the full request dict to responses.create(). The fix calls _format_request() once, then builds parse_kwargs from the full result excluding "model" and "input" (handled explicitly) and "stream" (hardcoded by _format_request(), incompatible with responses.parse()). Resolves strands-agents#1908
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
structured_output() called _format_request() but only extracted ["input"],
silently dropping all config params (max_output_tokens, reasoning,
instructions, etc.). The stream() method does not have this issue because
it passes the full request dict to responses.create().
The fix calls _format_request() once, then builds parse_kwargs from the
full result excluding "model" and "input" (handled explicitly) and "stream"
(hardcoded by _format_request(), incompatible with responses.parse()).
Related Issues
Resolves #1908
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change?
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.