fix: guard state reset in GraphNode.reset_executor_state() for MultiAgentBase executors#2071
Open
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Conversation
…gentBase executors reset_executor_state() checked hasattr(self.executor, "state") without checking whether the state attribute is an AgentState. Graph (a MultiAgentBase) has a .state attribute of type GraphState, which does not have a .get() method. The method would overwrite GraphState with a blank AgentState(), corrupting the nested executor on every reset (triggered by reset_on_revisit cycles or deserialize_state after a completed run). __post_init__ already has the correct guard: hasattr(self.executor.state, "get") which resolves to True only for AgentState. The fix mirrors that same guard in reset_executor_state(), making the two methods consistent. Resolves strands-agents#1775
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reset_executor_state() checked hasattr(self.executor, "state") without
checking whether the state is an AgentState. Graph (a MultiAgentBase) has
a .state attribute of type GraphState, which does not have a .get() method.
The method would overwrite GraphState with a blank AgentState(), corrupting
the nested executor on every reset -- triggered by reset_on_revisit cycles
or deserialize_state after a completed run.
post_init already has the correct guard:
hasattr(self.executor.state, "get")
which resolves to True only for AgentState. The fix mirrors that same
guard in reset_executor_state(), making the two methods consistent.
Related Issues
Resolves #1775
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change?
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.