addressmore comments

Author: lizradway

strands-ts/src/vended-plugins/context-offloader/__tests__/plugin.test.ts

@@ -3,7 +3,7 @@ import { ContextOffloader } from '../plugin.js'
 import { InMemoryStorage } from '../storage.js'
 import { AfterToolCallEvent } from '../../../hooks/events.js'
 import { TextBlock, JsonBlock, ToolResultBlock } from '../../../types/messages.js'
-import { ImageBlock, DocumentBlock } from '../../../types/media.js'
+import { ImageBlock, VideoBlock, DocumentBlock } from '../../../types/media.js'
 import { createMockAgent, invokeTrackedHook } from '../../../__fixtures__/agent-helpers.js'
 import { MockMessageModel } from '../../../__fixtures__/mock-message-model.js'
 
@@ -14,7 +14,9 @@ function makeMockAgent() {
 }
 
 function makeEvent(
-  content: InstanceType<typeof TextBlock | typeof JsonBlock | typeof ImageBlock | typeof DocumentBlock>[],
+  content: InstanceType<
+    typeof TextBlock | typeof JsonBlock | typeof ImageBlock | typeof VideoBlock | typeof DocumentBlock
+  >[],
   overrides?: { status?: 'success' | 'error'; toolName?: string }
 ) {
   const agent = makeMockAgent()
@@ -312,6 +314,21 @@ describe('ContextOffloader', () => {
       expect((result as ImageBlock).format).toBe('png')
     })
 
+    it('retrieves video content as VideoBlock', async () => {
+      const storage = new InMemoryStorage()
+      const vidBytes = new Uint8Array([0x00, 0x00, 0x00, 0x1c])
+      const ref = await storage.store('k1', vidBytes, 'video/mp4')
+
+      const plugin = new ContextOffloader({ storage, includeRetrievalTool: true })
+      const tools = plugin.getTools()
+      const retrievalTool = tools[0]!
+      const result = await (retrievalTool as unknown as { invoke(input: unknown): Promise<unknown> }).invoke({
+        reference: ref,
+      })
+      expect(result).toBeInstanceOf(VideoBlock)
+      expect((result as VideoBlock).format).toBe('mp4')
+    })
+
     it('retrieves document content as DocumentBlock', async () => {
       const storage = new InMemoryStorage()
       const docBytes = new Uint8Array([0x25, 0x50, 0x44, 0x46])

strands-ts/src/vended-plugins/context-offloader/plugin.ts

@@ -6,6 +6,7 @@ import { AfterToolCallEvent } from '../../hooks/events.js'
 import { TextBlock, JsonBlock, ToolResultBlock, Message } from '../../types/messages.js'
 import type { ToolResultContent } from '../../types/messages.js'
 import { ImageBlock, VideoBlock, DocumentBlock } from '../../types/media.js'
+import type { ImageFormat, VideoFormat, DocumentFormat } from '../../types/media.js'
 import { tool } from '../../tools/tool-factory.js'
 import { z } from 'zod'
 import { logger } from '../../logging/logger.js'
@@ -55,21 +56,21 @@ function decodeStoredContent(content: Uint8Array, contentType: string, reference
   if (contentType.startsWith('image/')) {
     const format = contentType.split('/').pop()!
     return new ImageBlock({
-      format: format as import('../../types/media.js').ImageFormat,
+      format: format as ImageFormat,
       source: { bytes: content },
     }) as unknown as JSONValue
   }
   if (contentType.startsWith('video/')) {
     const format = contentType.split('/').pop()!
     return new VideoBlock({
-      format: format as import('../../types/media.js').VideoFormat,
+      format: format as VideoFormat,
       source: { bytes: content },
     }) as unknown as JSONValue
   }
   if (contentType.startsWith('application/')) {
     const format = contentType.split('/').pop()!
     return new DocumentBlock({
-      format: format as import('../../types/media.js').DocumentFormat,
+      format: format as DocumentFormat,
       name: reference,
       source: { bytes: content },
     }) as unknown as JSONValue
@@ -190,7 +191,7 @@ export class ContextOffloader implements Plugin {
       }
       return { ref: '', contentType, description: `${label}, 0 bytes` }
     }
-    logger.warn(`Unsupported content block type encountered during offloading, skipping`)
+    logger.warn('unsupported content block type encountered during offloading, skipping')
     return { ref: '', contentType: 'unknown', description: 'unknown block type' }
   }